All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Adam Duskett <aduskett@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/gdb: remove python2 support
Date: Thu, 13 Jan 2022 21:38:31 +0100	[thread overview]
Message-ID: <20220113213831.4b7c5a8a@windsurf> (raw)
In-Reply-To: <20220104200904.1422985-1-aduskett@gmail.com>

Hello,

On Tue,  4 Jan 2022 12:09:04 -0800
Adam Duskett <aduskett@gmail.com> wrote:

> According to the GDB 9.2 changelog, python3 has been supported since at least
> 2019.
> 
> - Remove BR2_PACKAGE_HOST_GDB_PYTHON in package/gdb/Config.in.host
> 
> - Add BR2_PACKAGE_HOST_GDB_PYTHON to Config.in.legacy
> 
> - Change depends on BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3 to
>   depends on BR2_PACKAGE_PYTHON3 in package/gdb/Config.in
> 
> Signed-off-by: Adam Duskett <aduskett@gmail.com>

I have applied your patch, after some changes. See below.

> diff --git a/package/gdb/Config.in.host b/package/gdb/Config.in.host
> index a6e1d7f53c..2c6c78f20a 100644
> --- a/package/gdb/Config.in.host
> +++ b/package/gdb/Config.in.host
> @@ -41,11 +41,6 @@ config BR2_PACKAGE_HOST_GDB_NOPYTHON
>  	help
>  	  This option disables Python support in the cross gdb.
>  
> -config BR2_PACKAGE_HOST_GDB_PYTHON
> -	bool "Python 2"
> -	help
> -	  This option enables the Python 2 support in the cross gdb.
> -
>  config BR2_PACKAGE_HOST_GDB_PYTHON3
>  	bool "Python 3"
>  	help

The choice ... endchoice here was no longer needed, so I have only kept
BR2_PACKAGE_HOST_GDB_PYTHON3 as an option.

> diff --git a/package/gdb/gdb.mk b/package/gdb/gdb.mk
> index 4ff498230a..2929eaf058 100644
> --- a/package/gdb/gdb.mk
> +++ b/package/gdb/gdb.mk
> @@ -206,11 +206,6 @@ ifeq ($(BR2_PACKAGE_PYTHON3),y)

This ifeq ($(BR2_PACKAGE_PYTHON3),y) was no longer needed: we know it's
always going to be python3.

Applied with those changes. Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2022-01-13 20:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-04 20:09 [Buildroot] [PATCH 1/1] package/gdb: remove python2 support Adam Duskett
2022-01-06 21:10 ` Romain Naour
2022-01-06 21:37   ` Romain Naour
2022-01-13 20:38 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220113213831.4b7c5a8a@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=aduskett@gmail.com \
    --cc=buildroot@buildroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.