Re: [PATCH v13 1/4] drm/msm/dp: do not initialize phy until plugin interrupt received

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 5310 bytes --]

Hi Kuogee,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm/drm-next]
[also build test WARNING on drm-tip/drm-tip next-20220113]
[cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next airlied/drm-next v5.16]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Kuogee-Hsieh/group-dp-driver-related-patches-into-one-series/20220114-075514
base:   git://anongit.freedesktop.org/drm/drm drm-next
config: csky-allmodconfig (https://download.01.org/0day-ci/archive/20220114/202201141446.nNPQPiCv-lkp(a)intel.com/config)
compiler: csky-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/fbd3a5f531a9b0ad814e36a17b3ba95a20fe52a2
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Kuogee-Hsieh/group-dp-driver-related-patches-into-one-series/20220114-075514
        git checkout fbd3a5f531a9b0ad814e36a17b3ba95a20fe52a2
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=csky SHELL=/bin/bash drivers/gpu/drm/msm/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/msm/dp/dp_display.c: In function 'dp_irq_hpd_handle':
>> drivers/gpu/drm/msm/dp/dp_display.c:682:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
     682 |         int ret;
         |             ^~~


vim +/ret +682 drivers/gpu/drm/msm/dp/dp_display.c

8ede2ecc3e5ee32 Kuogee Hsieh     2020-09-11  678  
8ede2ecc3e5ee32 Kuogee Hsieh     2020-09-11  679  static int dp_irq_hpd_handle(struct dp_display_private *dp, u32 data)
8ede2ecc3e5ee32 Kuogee Hsieh     2020-09-11  680  {
8ede2ecc3e5ee32 Kuogee Hsieh     2020-09-11  681  	u32 state;
c58eb1b54feefc3 Kuogee Hsieh     2020-11-18 @682  	int ret;
8ede2ecc3e5ee32 Kuogee Hsieh     2020-09-11  683  
8ede2ecc3e5ee32 Kuogee Hsieh     2020-09-11  684  	mutex_lock(&dp->event_mutex);
8ede2ecc3e5ee32 Kuogee Hsieh     2020-09-11  685  
8ede2ecc3e5ee32 Kuogee Hsieh     2020-09-11  686  	/* irq_hpd can happen at either connected or disconnected state */
19e52bcb27c2ba1 Kuogee Hsieh     2020-11-03  687  	state =  dp->hpd_state;
f21c8a276c2dadd Kuogee Hsieh     2021-05-21  688  	if (state == ST_DISPLAY_OFF || state == ST_SUSPENDED) {
8ede2ecc3e5ee32 Kuogee Hsieh     2020-09-11  689  		mutex_unlock(&dp->event_mutex);
8ede2ecc3e5ee32 Kuogee Hsieh     2020-09-11  690  		return 0;
8ede2ecc3e5ee32 Kuogee Hsieh     2020-09-11  691  	}
8ede2ecc3e5ee32 Kuogee Hsieh     2020-09-11  692  
2b5f09cadfc5768 Kuogee Hsieh     2020-12-18  693  	if (state == ST_CONNECT_PENDING) {
2b5f09cadfc5768 Kuogee Hsieh     2020-12-18  694  		/* wait until ST_CONNECTED */
2b5f09cadfc5768 Kuogee Hsieh     2020-12-18  695  		dp_add_event(dp, EV_IRQ_HPD_INT, 0, 1); /* delay = 1 */
2b5f09cadfc5768 Kuogee Hsieh     2020-12-18  696  		mutex_unlock(&dp->event_mutex);
2b5f09cadfc5768 Kuogee Hsieh     2020-12-18  697  		return 0;
2b5f09cadfc5768 Kuogee Hsieh     2020-12-18  698  	}
2b5f09cadfc5768 Kuogee Hsieh     2020-12-18  699  
ea9f337ce81e315 Kuogee Hsieh     2021-02-05  700  	if (state == ST_CONNECT_PENDING || state == ST_DISCONNECT_PENDING) {
9fc418430c65848 Kuogee Hsieh     2021-01-13  701  		/* wait until ST_CONNECTED */
9fc418430c65848 Kuogee Hsieh     2021-01-13  702  		dp_add_event(dp, EV_IRQ_HPD_INT, 0, 1); /* delay = 1 */
9fc418430c65848 Kuogee Hsieh     2021-01-13  703  		mutex_unlock(&dp->event_mutex);
9fc418430c65848 Kuogee Hsieh     2021-01-13  704  		return 0;
9fc418430c65848 Kuogee Hsieh     2021-01-13  705  	}
9fc418430c65848 Kuogee Hsieh     2021-01-13  706  
f61550b3864b957 Kuogee Hsieh     2021-12-08  707  	/*
f61550b3864b957 Kuogee Hsieh     2021-12-08  708  	 * dp core (ahb/aux clks) must be initialized before
f61550b3864b957 Kuogee Hsieh     2021-12-08  709  	 * irq_hpd be handled
f61550b3864b957 Kuogee Hsieh     2021-12-08  710  	 */
fbd3a5f531a9b0a Kuogee Hsieh     2022-01-13  711  	if (dp->core_initialized)
c58eb1b54feefc3 Kuogee Hsieh     2020-11-18  712  		ret = dp_display_usbpd_attention_cb(&dp->pdev->dev);
fbd3a5f531a9b0a Kuogee Hsieh     2022-01-13  713  
601f0479c583603 Maitreyee Rao    2021-07-26  714  	DRM_DEBUG_DP("hpd_state=%d\n", state);
8ede2ecc3e5ee32 Kuogee Hsieh     2020-09-11  715  
8ede2ecc3e5ee32 Kuogee Hsieh     2020-09-11  716  	mutex_unlock(&dp->event_mutex);
8ede2ecc3e5ee32 Kuogee Hsieh     2020-09-11  717  
8ede2ecc3e5ee32 Kuogee Hsieh     2020-09-11  718  	return 0;
c943b4948b5848f Chandan Uddaraju 2020-08-27  719  }
c943b4948b5848f Chandan Uddaraju 2020-08-27  720  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org