From: Simon Horman <horms@verge.net.au>
To: kexec@lists.infradead.org
Subject: [PATCHv3 0/4] arm64: make phys_to_virt() correct
Date: Fri, 14 Jan 2022 15:47:55 +0100 [thread overview]
Message-ID: <20220114144755.GE16732@vergenet.net> (raw)
In-Reply-To: <20211228132659.40102-1-piliu@redhat.com>
Hi Pingfan,
On Tue, Dec 28, 2021 at 09:26:55PM +0800, Pingfan Liu wrote:
> Currently phys_to_virt() does not work well on 52-bits VA arm64 kernel.
> One issue is contributed by phys_offset not signed.
> The other is contributed by wrong page_offset.
>
> v2 -> v3:
> Discussed with Kairui off-list, 48-bits VA kernel can not handle flipped
> mm yet. So introducing [4/4], which judges whether the kernel is with
> flipped mm layout and adopt different formula accordingly.
>
> As for [1-3/4], they are the same as [1-3/3] in V2.
>
> v1 -> v2
> Fix broken patch [2/3] in v1
> Move arch_scan_vmcoreinfo declaration to util_lib/include/elf_info.h
> Using UINT64_MAX instread of 0xffffffffffffffff
Thanks for the updated patches and sorry for the delay in reviewing them.
I responded with some minor nits on patches 1/4 and 2/4.
The other patches 3/4 and 4/4 look good to me.
Modulo any feedback from others I'd be happy to move forwards
with applying this series once my nits have been addressed
(via email or fresh patches).
Thanks again,
Simon
next prev parent reply other threads:[~2022-01-14 14:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-28 13:26 [PATCHv3 0/4] arm64: make phys_to_virt() correct Pingfan Liu
2021-12-28 13:26 ` [PATCHv3 1/4] arm64: make phys_offset signed Pingfan Liu
2022-01-14 14:35 ` Simon Horman
2021-12-28 13:26 ` [PATCHv3 2/4] arm64/crashdump: unify routine to get page_offset Pingfan Liu
2022-01-14 14:41 ` Simon Horman
2021-12-28 13:26 ` [PATCHv3 3/4] arm64: read VA_BITS from kcore for 52-bits VA kernel Pingfan Liu
2021-12-28 13:26 ` [PATCHv3 4/4] arm64: fix PAGE_OFFSET calc for flipped mm Pingfan Liu
2022-01-12 3:39 ` [PATCHv3 0/4] arm64: make phys_to_virt() correct Pingfan Liu
2022-01-14 14:47 ` Simon Horman [this message]
2022-01-18 1:52 ` Pingfan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220114144755.GE16732@vergenet.net \
--to=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.