From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9895C433F5 for ; Fri, 14 Jan 2022 22:19:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230429AbiANWTg (ORCPT ); Fri, 14 Jan 2022 17:19:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230330AbiANWTc (ORCPT ); Fri, 14 Jan 2022 17:19:32 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77D28C061574; Fri, 14 Jan 2022 14:19:31 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1753B61ED2; Fri, 14 Jan 2022 22:19:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 660B5C36AE9; Fri, 14 Jan 2022 22:19:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642198770; bh=zWsLY3ky24QWmemKhcAlVIHzefIeXpr+gm+UbQH9Zj0=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=V6VondQqTNiZd9F9fU2EjAEbUMVRmQVCbtezr9MVQFnl4Mnp2uxgZYnoZcOUKKK2F 6dzm5E+3rfNEoRqrue//pOwZF/+ZWN8roOhLfH9cBBEggjsztjWPrvRjsHZEqKFn/8 JHyTkE/bmlBPL1ScCULbFBRiLpsegVMhLV6qvDUEsf+0O3+E/sh31DVkvGuXA87AQI yBpfZY6QhUcuvgT/VzxKpujFyAT/2y0XAM1IxHeUB1Emn5Vcq5L4yApkKFHptue+dt YpRdknoghrcNUJGXXsGT9oTSHKUksxTWpwDMghlLII1MU6Hi7YucpPj3K1hIn/L+QJ 625XrLnUZcQ0A== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220114083511.18906-1-miles.chen@mediatek.com> References: <20220114021131.1F7C9C36AEA@smtp.kernel.org> <20220114083511.18906-1-miles.chen@mediatek.com> Subject: Re: [PATCH 3/3] clk: mediatek: support COMMON_CLK_MT8192 module build From: Stephen Boyd Cc: chun-jie.chen@mediatek.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, miles.chen@mediatek.com, mturquette@baylibre.com, wenst@chromium.org To: Matthias Brugger , Miles Chen Date: Fri, 14 Jan 2022 14:19:28 -0800 User-Agent: alot/0.10 Message-Id: <20220114221930.660B5C36AE9@smtp.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Miles Chen (2022-01-14 00:35:10) > Hi, >=20 > >Have you tried removing the modules? And then reloading them? I also see >=20 > Thanks for the comment. > I did not try it because we do not unload our clk modules. > After testing I understand that the clock driver does not unregister clks= so=20 > we cannot remove then unload it. >=20 > I think I have to add some unregister logic to these drivers. Yes >=20 > >that mtk_clk_simple_probe() doesn't actually unregister anything, it > >just frees some allocations. Please fix this before making these > >modules. >=20 > You meant that mtk_clk_simple_probe() has no unregister logic in error pa= th? >=20 Yes From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0715C433F5 for ; Fri, 14 Jan 2022 22:19:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C5QO3JYO96gbtFFgLNiGZRPkbXs2ho71Y1kVgJWkxrE=; b=1SPGkjkCMdiRZM rE777QdtJTDG3u6nuBkiqNTZp/ihZKQotJkHCNy86voan96Vgjf5WygXp5HP9NuzU3jYfBNX0CTUk sphGUCFM6r7HW7wgQ5aLtTWeb4BapSbulOLr0VuUFFG69Wxorua8hgiRgh3Pp6DExto3ArfnlTh0d cx5Y6EsyBQ3CZChZc17cag1/sdpjeWFGkN4huZuwltgMfGubHJx+PCRCnz477qdmfFdaEIpNqLqd4 zALzGzM/MpfrVXn5ma6lEgAgsWRzVmbXqLsEqmm92zVAzqWZ4EDzDVvV7Su4HpYswOCVpfKnpSAd+ xpyeq//DFdbcDE7Cfpsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n8UvD-00AJnh-AT; Fri, 14 Jan 2022 22:19:47 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n8Uuz-00AJmg-IM; Fri, 14 Jan 2022 22:19:34 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A8426B825F5; Fri, 14 Jan 2022 22:19:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 660B5C36AE9; Fri, 14 Jan 2022 22:19:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642198770; bh=zWsLY3ky24QWmemKhcAlVIHzefIeXpr+gm+UbQH9Zj0=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=V6VondQqTNiZd9F9fU2EjAEbUMVRmQVCbtezr9MVQFnl4Mnp2uxgZYnoZcOUKKK2F 6dzm5E+3rfNEoRqrue//pOwZF/+ZWN8roOhLfH9cBBEggjsztjWPrvRjsHZEqKFn/8 JHyTkE/bmlBPL1ScCULbFBRiLpsegVMhLV6qvDUEsf+0O3+E/sh31DVkvGuXA87AQI yBpfZY6QhUcuvgT/VzxKpujFyAT/2y0XAM1IxHeUB1Emn5Vcq5L4yApkKFHptue+dt YpRdknoghrcNUJGXXsGT9oTSHKUksxTWpwDMghlLII1MU6Hi7YucpPj3K1hIn/L+QJ 625XrLnUZcQ0A== MIME-Version: 1.0 In-Reply-To: <20220114083511.18906-1-miles.chen@mediatek.com> References: <20220114021131.1F7C9C36AEA@smtp.kernel.org> <20220114083511.18906-1-miles.chen@mediatek.com> Subject: Re: [PATCH 3/3] clk: mediatek: support COMMON_CLK_MT8192 module build From: Stephen Boyd Cc: chun-jie.chen@mediatek.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, miles.chen@mediatek.com, mturquette@baylibre.com, wenst@chromium.org To: Matthias Brugger , Miles Chen Date: Fri, 14 Jan 2022 14:19:28 -0800 User-Agent: alot/0.10 Message-Id: <20220114221930.660B5C36AE9@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220114_141933_790572_6DAA694D X-CRM114-Status: GOOD ( 13.63 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Quoting Miles Chen (2022-01-14 00:35:10) > Hi, > > >Have you tried removing the modules? And then reloading them? I also see > > Thanks for the comment. > I did not try it because we do not unload our clk modules. > After testing I understand that the clock driver does not unregister clks so > we cannot remove then unload it. > > I think I have to add some unregister logic to these drivers. Yes > > >that mtk_clk_simple_probe() doesn't actually unregister anything, it > >just frees some allocations. Please fix this before making these > >modules. > > You meant that mtk_clk_simple_probe() has no unregister logic in error path? > Yes _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 182FDC433EF for ; Fri, 14 Jan 2022 22:21:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QJtDGwakML86ej8npwRdU0UTBl8J9ZevCxJwDgQLQtI=; b=EZZKSrESUFdhHD cxYcYvllFjzwbWYWCcL+8OB9RgHtlqFoUiVROqiKqDzfk/jvXy71u36xY3Zp1ASau3N8gGUiMl5lu KdX7HlbQwHWjeMYrC+RYfABKhkYgBpRmgJZ3mRQM76dw/qUysx5XQzMtt7ZE2ye3+e3KciliVAtJw Mgcn56nvznVC1C0X9sllZTuJtYXmrH0gJKD8TDrVfwyZWQlM70QhfpoqFX/kycxOZ1a5HkDaxatwE yoMZ1r2lcvgE6OncsKA5/LiVYQuFilPviFiqPJ/qU/2ciGcIoTZ4YhDbLB0UnIwU/bD8z33XUkHXW byXVGV4GDZgo2CMnEHCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n8Uv3-00AJn5-9V; Fri, 14 Jan 2022 22:19:37 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n8Uuz-00AJmg-IM; Fri, 14 Jan 2022 22:19:34 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A8426B825F5; Fri, 14 Jan 2022 22:19:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 660B5C36AE9; Fri, 14 Jan 2022 22:19:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642198770; bh=zWsLY3ky24QWmemKhcAlVIHzefIeXpr+gm+UbQH9Zj0=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=V6VondQqTNiZd9F9fU2EjAEbUMVRmQVCbtezr9MVQFnl4Mnp2uxgZYnoZcOUKKK2F 6dzm5E+3rfNEoRqrue//pOwZF/+ZWN8roOhLfH9cBBEggjsztjWPrvRjsHZEqKFn/8 JHyTkE/bmlBPL1ScCULbFBRiLpsegVMhLV6qvDUEsf+0O3+E/sh31DVkvGuXA87AQI yBpfZY6QhUcuvgT/VzxKpujFyAT/2y0XAM1IxHeUB1Emn5Vcq5L4yApkKFHptue+dt YpRdknoghrcNUJGXXsGT9oTSHKUksxTWpwDMghlLII1MU6Hi7YucpPj3K1hIn/L+QJ 625XrLnUZcQ0A== MIME-Version: 1.0 In-Reply-To: <20220114083511.18906-1-miles.chen@mediatek.com> References: <20220114021131.1F7C9C36AEA@smtp.kernel.org> <20220114083511.18906-1-miles.chen@mediatek.com> Subject: Re: [PATCH 3/3] clk: mediatek: support COMMON_CLK_MT8192 module build From: Stephen Boyd Cc: chun-jie.chen@mediatek.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, miles.chen@mediatek.com, mturquette@baylibre.com, wenst@chromium.org To: Matthias Brugger , Miles Chen Date: Fri, 14 Jan 2022 14:19:28 -0800 User-Agent: alot/0.10 Message-Id: <20220114221930.660B5C36AE9@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220114_141933_790572_6DAA694D X-CRM114-Status: GOOD ( 13.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Miles Chen (2022-01-14 00:35:10) > Hi, > > >Have you tried removing the modules? And then reloading them? I also see > > Thanks for the comment. > I did not try it because we do not unload our clk modules. > After testing I understand that the clock driver does not unregister clks so > we cannot remove then unload it. > > I think I have to add some unregister logic to these drivers. Yes > > >that mtk_clk_simple_probe() doesn't actually unregister anything, it > >just frees some allocations. Please fix this before making these > >modules. > > You meant that mtk_clk_simple_probe() has no unregister logic in error path? > Yes _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel