All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seiderer <ps.report@gmx.net>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: buildroot@busybox.net, "Julien Corjon" <corjon.j@ecagroup.com>,
	"Gaël Portay" <gael.portay@collabora.com>
Subject: Re: [Buildroot] [PATCH v3 2/2] package/qt5webengine: use buildroot cflags/ldflags for arm
Date: Sat, 15 Jan 2022 23:57:58 +0100	[thread overview]
Message-ID: <20220115235758.069ce087@gmx.net> (raw)
In-Reply-To: <20220109150359.1c4a717b@windsurf>

Hello Thomas,

On Sun, 9 Jan 2022 15:03:59 +0100, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:

> On Fri,  6 Mar 2020 21:34:10 +0100
> Peter Seiderer <ps.report@gmx.net> wrote:
>
> > +define QT5WEBENGINE_CONFIGURE_COMPILER_FLAGS
> > +	$(SED) 's%@TARGET_CXXFLAGS@%$(call make-comma-list,$(TARGET_CXXFLAGS))%g' $(@D)/src/3rdparty/chromium/build/config/compiler/BUILD.gn
> > +	$(SED) 's%@TARGET_LDFLAGS@%$(call make-comma-list,$(TARGET_LDFLAGS))%g' $(@D)/src/3rdparty/chromium/build/config/compiler/BUILD.gn
> > +endef
>
> This looks like a good thing. Could it replace the ARM-specific logic
> you had in your PATCH 1/2 ?

Not sure as there is more optional and/or compile defines logic depending on
the various arm-options logic..., the save way seems to be the right setting
of the various arm-options (but did not find a better way as to edit/sed the
GN files...

Regards,
Peter

>
> Thomas

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-01-15 22:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-06 20:34 [Buildroot] [PATCH v3 1/2] package/qt5webengine: fix compile flags for arm Peter Seiderer
2020-03-06 20:34 ` [Buildroot] [PATCH v3 2/2] package/qt5webengine: use buildroot cflags/ldflags " Peter Seiderer
2022-01-09 14:03   ` Thomas Petazzoni
2022-01-15 22:57     ` Peter Seiderer [this message]
2022-01-09 14:03 ` [Buildroot] [PATCH v3 1/2] package/qt5webengine: fix compile flags " Thomas Petazzoni
2022-01-15 22:53   ` Peter Seiderer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220115235758.069ce087@gmx.net \
    --to=ps.report@gmx.net \
    --cc=buildroot@busybox.net \
    --cc=corjon.j@ecagroup.com \
    --cc=gael.portay@collabora.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.