From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============1036397910902793813==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings Date: Sun, 16 Jan 2022 19:34:57 +0800 Message-ID: <20220116113457.GA34989@60e032481831> In-Reply-To: <202201161925.6QTzwT86-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============1036397910902793813== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org CC: linux-kernel(a)vger.kernel.org TO: Krzysztof Kozlowski CC: Julia Lawall CC: Support Opensource CC: Liam Girdwood CC: Mark Brown CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/regulator/slg51000-regulator.c:480:8-33: WARNING: Threaded IRQ with= no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. So pass the IRQF_ONESHOT flag in this case. Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci CC: Krzysztof Kozlowski Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = master head: 4d66020dcef83314092f2c8c89152a8d122627e2 commit: 5d2db9bb5f8a850d037983f0df72ad59cefa9e3d coccinelle: irqf_oneshot: = reduce the severity due to false positives :::::: branch date: 3 hours ago :::::: commit date: 9 months ago Please take the patch only if it's a positive warning. Thanks! slg51000-regulator.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/regulator/slg51000-regulator.c +++ b/drivers/regulator/slg51000-regulator.c @@ -479,8 +479,7 @@ static int slg51000_i2c_probe(struct i2c if (chip->chip_irq) { ret =3D devm_request_threaded_irq(dev, chip->chip_irq, NULL, slg51000_irq_handler, - (IRQF_TRIGGER_HIGH | - IRQF_ONESHOT), + (IRQF_TRIGGER_HIGH | IRQF_ONESHOT) | IRQF_ONESHOT, "slg51000-irq", chip); if (ret !=3D 0) { dev_err(dev, "Failed to request IRQ: %d\n", --===============1036397910902793813==--