From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============0303500368387696920==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings Date: Sun, 16 Jan 2022 19:35:00 +0800 Message-ID: <20220116113500.GA35948@60e032481831> In-Reply-To: <202201161925.6QTzwT86-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============0303500368387696920== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org CC: linux-kernel(a)vger.kernel.org TO: Krzysztof Kozlowski CC: Julia Lawall CC: Maximilian Luz CC: Hans de Goede CC: Mark Gross CC: platform-driver-x86(a)vger.kernel.org CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/platform/surface/surface_hotplug.c:180:10-35: WARNING: Threaded IRQ= with no primary handler requested without IRQF_ONESHOT (unless it is neste= d IRQ) Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. So pass the IRQF_ONESHOT flag in this case. Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci CC: Krzysztof Kozlowski Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = master head: 4d66020dcef83314092f2c8c89152a8d122627e2 commit: 5d2db9bb5f8a850d037983f0df72ad59cefa9e3d coccinelle: irqf_oneshot: = reduce the severity due to false positives :::::: branch date: 3 hours ago :::::: commit date: 9 months ago Please take the patch only if it's a positive warning. Thanks! surface_hotplug.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/platform/surface/surface_hotplug.c +++ b/drivers/platform/surface/surface_hotplug.c @@ -178,7 +178,8 @@ static int shps_setup_irq(struct platfor return -ENOMEM; = status =3D devm_request_threaded_irq(&pdev->dev, irq, NULL, shps_handle_i= rq, - flags, irq_name, pdev); + flags | IRQF_ONESHOT, irq_name, + pdev); if (status) return status; =20 --===============0303500368387696920==--