All of lore.kernel.org
 help / color / mirror / Atom feed
diff for duplicates of <202201170744.uress2oV-lkp@intel.com>

diff --git a/a/1.txt b/N1/1.txt
index 62b0d9a..711f60e 100644
--- a/a/1.txt
+++ b/N1/1.txt
@@ -1,14 +1,6 @@
-CC: kbuild-all(a)lists.01.org
-CC: linux-kernel(a)vger.kernel.org
-TO: Maxime Ripard <maxime@cerno.tech>
-CC: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
-
 tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
 head:   79e06c4c4950be2abd8ca5d2428a8c915aa62c24
 commit: dec92020671c48da231189eb06a5f755f492f87f drm: Use the state pointer directly in planes atomic_check
-date:   11 months ago
-:::::: branch date: 9 hours ago
-:::::: commit date: 11 months ago
 config: arm-randconfig-m031-20220116 (https://download.01.org/0day-ci/archive/20220117/202201170744.uress2oV-lkp(a)intel.com/config)
 compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
 
@@ -21,11 +13,13 @@ drivers/gpu/drm/armada/armada_plane.c:124 armada_drm_plane_atomic_check() warn:
 
 vim +/state +124 drivers/gpu/drm/armada/armada_plane.c
 
-d40af7b1ae23da Russell King  2018-07-30  107  
 d40af7b1ae23da Russell King  2018-07-30  108  int armada_drm_plane_atomic_check(struct drm_plane *plane,
 7c11b99a8e58c0 Maxime Ripard 2021-02-19  109  	struct drm_atomic_state *state)
 d40af7b1ae23da Russell King  2018-07-30  110  {
 7c11b99a8e58c0 Maxime Ripard 2021-02-19 @111  	struct drm_plane_state *new_plane_state = drm_atomic_get_new_plane_state(state,
+                                                                                                                         ^^^^^^
+Dereference
+
 7c11b99a8e58c0 Maxime Ripard 2021-02-19  112  										 plane);
 ba5c1649465d40 Maxime Ripard 2021-02-19  113  	struct armada_plane_state *st = to_armada_plane_state(new_plane_state);
 ba5c1649465d40 Maxime Ripard 2021-02-19  114  	struct drm_crtc *crtc = new_plane_state->crtc;
@@ -39,6 +33,9 @@ ba5c1649465d40 Maxime Ripard 2021-02-19  120  		new_plane_state->visible = false
 1d1547ec12bc7d Russell King  2019-01-25  122  	}
 d40af7b1ae23da Russell King  2018-07-30  123  
 dec92020671c48 Maxime Ripard 2021-02-19 @124  	if (state)
+                                                    ^^^^^
+Checked too late
+
 dec92020671c48 Maxime Ripard 2021-02-19  125  		crtc_state = drm_atomic_get_existing_crtc_state(state,
 ba5c1649465d40 Maxime Ripard 2021-02-19  126  								crtc);
 d40af7b1ae23da Russell King  2018-07-30  127  	else
@@ -48,35 +45,6 @@ ba5c1649465d40 Maxime Ripard 2021-02-19  130  	ret = drm_atomic_helper_check_pla
 ba5c1649465d40 Maxime Ripard 2021-02-19  131  						  0,
 1d1547ec12bc7d Russell King  2019-01-25  132  						  INT_MAX, true, false);
 1d1547ec12bc7d Russell King  2019-01-25  133  	if (ret)
-1d1547ec12bc7d Russell King  2019-01-25  134  		return ret;
-1d1547ec12bc7d Russell King  2019-01-25  135  
-1d1547ec12bc7d Russell King  2019-01-25  136  	interlace = crtc_state->adjusted_mode.flags & DRM_MODE_FLAG_INTERLACE;
-1d1547ec12bc7d Russell King  2019-01-25  137  	if (interlace) {
-ba5c1649465d40 Maxime Ripard 2021-02-19  138  		if ((new_plane_state->dst.y1 | new_plane_state->dst.y2) & 1)
-1d1547ec12bc7d Russell King  2019-01-25  139  			return -EINVAL;
-ba5c1649465d40 Maxime Ripard 2021-02-19  140  		st->src_hw = drm_rect_height(&new_plane_state->src) >> 17;
-ba5c1649465d40 Maxime Ripard 2021-02-19  141  		st->dst_yx = new_plane_state->dst.y1 >> 1;
-ba5c1649465d40 Maxime Ripard 2021-02-19  142  		st->dst_hw = drm_rect_height(&new_plane_state->dst) >> 1;
-d40af7b1ae23da Russell King  2018-07-30  143  	} else {
-ba5c1649465d40 Maxime Ripard 2021-02-19  144  		st->src_hw = drm_rect_height(&new_plane_state->src) >> 16;
-ba5c1649465d40 Maxime Ripard 2021-02-19  145  		st->dst_yx = new_plane_state->dst.y1;
-ba5c1649465d40 Maxime Ripard 2021-02-19  146  		st->dst_hw = drm_rect_height(&new_plane_state->dst);
-d40af7b1ae23da Russell King  2018-07-30  147  	}
-1d1547ec12bc7d Russell King  2019-01-25  148  
-1d1547ec12bc7d Russell King  2019-01-25  149  	st->src_hw <<= 16;
-ba5c1649465d40 Maxime Ripard 2021-02-19  150  	st->src_hw |= drm_rect_width(&new_plane_state->src) >> 16;
-1d1547ec12bc7d Russell King  2019-01-25  151  	st->dst_yx <<= 16;
-ba5c1649465d40 Maxime Ripard 2021-02-19  152  	st->dst_yx |= new_plane_state->dst.x1 & 0x0000ffff;
-1d1547ec12bc7d Russell King  2019-01-25  153  	st->dst_hw <<= 16;
-ba5c1649465d40 Maxime Ripard 2021-02-19  154  	st->dst_hw |= drm_rect_width(&new_plane_state->dst) & 0x0000ffff;
-1d1547ec12bc7d Russell King  2019-01-25  155  
-ba5c1649465d40 Maxime Ripard 2021-02-19  156  	armada_drm_plane_calc(new_plane_state, st->addrs, st->pitches,
-ba5c1649465d40 Maxime Ripard 2021-02-19  157  			      interlace);
-7d62237da6ec07 Russell King  2019-01-25  158  	st->interlace = interlace;
-7d62237da6ec07 Russell King  2019-01-25  159  
-d40af7b1ae23da Russell King  2018-07-30  160  	return 0;
-d40af7b1ae23da Russell King  2018-07-30  161  }
-d40af7b1ae23da Russell King  2018-07-30  162  
 
 ---
 0-DAY CI Kernel Test Service, Intel Corporation
diff --git a/a/content_digest b/N1/content_digest
index d11083e..7b004d4 100644
--- a/a/content_digest
+++ b/N1/content_digest
@@ -1,20 +1,12 @@
- "From\0kernel test robot <lkp@intel.com>\0"
+ "From\0Dan Carpenter <dan.carpenter@oracle.com>\0"
  "Subject\0drivers/gpu/drm/armada/armada_plane.c:124 armada_drm_plane_atomic_check() warn: variable dereferenced before check 'state' (see line 111)\0"
- "Date\0Mon, 17 Jan 2022 07:46:18 +0800\0"
- "To\0kbuild@lists.01.org\0"
+ "Date\0Tue, 18 Jan 2022 18:18:35 +0300\0"
+ "To\0kbuild-all@lists.01.org\0"
  "\01:1\0"
  "b\0"
- "CC: kbuild-all(a)lists.01.org\n"
- "CC: linux-kernel(a)vger.kernel.org\n"
- "TO: Maxime Ripard <maxime@cerno.tech>\n"
- "CC: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n"
- "\n"
  "tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master\n"
  "head:   79e06c4c4950be2abd8ca5d2428a8c915aa62c24\n"
  "commit: dec92020671c48da231189eb06a5f755f492f87f drm: Use the state pointer directly in planes atomic_check\n"
- "date:   11 months ago\n"
- ":::::: branch date: 9 hours ago\n"
- ":::::: commit date: 11 months ago\n"
  "config: arm-randconfig-m031-20220116 (https://download.01.org/0day-ci/archive/20220117/202201170744.uress2oV-lkp(a)intel.com/config)\n"
  "compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0\n"
  "\n"
@@ -27,11 +19,13 @@
  "\n"
  "vim +/state +124 drivers/gpu/drm/armada/armada_plane.c\n"
  "\n"
- "d40af7b1ae23da Russell King  2018-07-30  107  \n"
  "d40af7b1ae23da Russell King  2018-07-30  108  int armada_drm_plane_atomic_check(struct drm_plane *plane,\n"
  "7c11b99a8e58c0 Maxime Ripard 2021-02-19  109  \tstruct drm_atomic_state *state)\n"
  "d40af7b1ae23da Russell King  2018-07-30  110  {\n"
  "7c11b99a8e58c0 Maxime Ripard 2021-02-19 @111  \tstruct drm_plane_state *new_plane_state = drm_atomic_get_new_plane_state(state,\n"
+ "                                                                                                                         ^^^^^^\n"
+ "Dereference\n"
+ "\n"
  "7c11b99a8e58c0 Maxime Ripard 2021-02-19  112  \t\t\t\t\t\t\t\t\t\t plane);\n"
  "ba5c1649465d40 Maxime Ripard 2021-02-19  113  \tstruct armada_plane_state *st = to_armada_plane_state(new_plane_state);\n"
  "ba5c1649465d40 Maxime Ripard 2021-02-19  114  \tstruct drm_crtc *crtc = new_plane_state->crtc;\n"
@@ -45,6 +39,9 @@
  "1d1547ec12bc7d Russell King  2019-01-25  122  \t}\n"
  "d40af7b1ae23da Russell King  2018-07-30  123  \n"
  "dec92020671c48 Maxime Ripard 2021-02-19 @124  \tif (state)\n"
+ "                                                    ^^^^^\n"
+ "Checked too late\n"
+ "\n"
  "dec92020671c48 Maxime Ripard 2021-02-19  125  \t\tcrtc_state = drm_atomic_get_existing_crtc_state(state,\n"
  "ba5c1649465d40 Maxime Ripard 2021-02-19  126  \t\t\t\t\t\t\t\tcrtc);\n"
  "d40af7b1ae23da Russell King  2018-07-30  127  \telse\n"
@@ -54,38 +51,9 @@
  "ba5c1649465d40 Maxime Ripard 2021-02-19  131  \t\t\t\t\t\t  0,\n"
  "1d1547ec12bc7d Russell King  2019-01-25  132  \t\t\t\t\t\t  INT_MAX, true, false);\n"
  "1d1547ec12bc7d Russell King  2019-01-25  133  \tif (ret)\n"
- "1d1547ec12bc7d Russell King  2019-01-25  134  \t\treturn ret;\n"
- "1d1547ec12bc7d Russell King  2019-01-25  135  \n"
- "1d1547ec12bc7d Russell King  2019-01-25  136  \tinterlace = crtc_state->adjusted_mode.flags & DRM_MODE_FLAG_INTERLACE;\n"
- "1d1547ec12bc7d Russell King  2019-01-25  137  \tif (interlace) {\n"
- "ba5c1649465d40 Maxime Ripard 2021-02-19  138  \t\tif ((new_plane_state->dst.y1 | new_plane_state->dst.y2) & 1)\n"
- "1d1547ec12bc7d Russell King  2019-01-25  139  \t\t\treturn -EINVAL;\n"
- "ba5c1649465d40 Maxime Ripard 2021-02-19  140  \t\tst->src_hw = drm_rect_height(&new_plane_state->src) >> 17;\n"
- "ba5c1649465d40 Maxime Ripard 2021-02-19  141  \t\tst->dst_yx = new_plane_state->dst.y1 >> 1;\n"
- "ba5c1649465d40 Maxime Ripard 2021-02-19  142  \t\tst->dst_hw = drm_rect_height(&new_plane_state->dst) >> 1;\n"
- "d40af7b1ae23da Russell King  2018-07-30  143  \t} else {\n"
- "ba5c1649465d40 Maxime Ripard 2021-02-19  144  \t\tst->src_hw = drm_rect_height(&new_plane_state->src) >> 16;\n"
- "ba5c1649465d40 Maxime Ripard 2021-02-19  145  \t\tst->dst_yx = new_plane_state->dst.y1;\n"
- "ba5c1649465d40 Maxime Ripard 2021-02-19  146  \t\tst->dst_hw = drm_rect_height(&new_plane_state->dst);\n"
- "d40af7b1ae23da Russell King  2018-07-30  147  \t}\n"
- "1d1547ec12bc7d Russell King  2019-01-25  148  \n"
- "1d1547ec12bc7d Russell King  2019-01-25  149  \tst->src_hw <<= 16;\n"
- "ba5c1649465d40 Maxime Ripard 2021-02-19  150  \tst->src_hw |= drm_rect_width(&new_plane_state->src) >> 16;\n"
- "1d1547ec12bc7d Russell King  2019-01-25  151  \tst->dst_yx <<= 16;\n"
- "ba5c1649465d40 Maxime Ripard 2021-02-19  152  \tst->dst_yx |= new_plane_state->dst.x1 & 0x0000ffff;\n"
- "1d1547ec12bc7d Russell King  2019-01-25  153  \tst->dst_hw <<= 16;\n"
- "ba5c1649465d40 Maxime Ripard 2021-02-19  154  \tst->dst_hw |= drm_rect_width(&new_plane_state->dst) & 0x0000ffff;\n"
- "1d1547ec12bc7d Russell King  2019-01-25  155  \n"
- "ba5c1649465d40 Maxime Ripard 2021-02-19  156  \tarmada_drm_plane_calc(new_plane_state, st->addrs, st->pitches,\n"
- "ba5c1649465d40 Maxime Ripard 2021-02-19  157  \t\t\t      interlace);\n"
- "7d62237da6ec07 Russell King  2019-01-25  158  \tst->interlace = interlace;\n"
- "7d62237da6ec07 Russell King  2019-01-25  159  \n"
- "d40af7b1ae23da Russell King  2018-07-30  160  \treturn 0;\n"
- "d40af7b1ae23da Russell King  2018-07-30  161  }\n"
- "d40af7b1ae23da Russell King  2018-07-30  162  \n"
  "\n"
  "---\n"
  "0-DAY CI Kernel Test Service, Intel Corporation\n"
  https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
 
-e38b55a749915b433560fa23a4a3a3c722f5b548ca3b48fb4ebfc0f4c57d584f
+08a32aa288e7789c29994c29e6722208a8aa12fe6b3b9a48adac1290bbd09420

diff --git a/a/1.txt b/N2/1.txt
index 62b0d9a..f00931a 100644
--- a/a/1.txt
+++ b/N2/1.txt
@@ -1,15 +1,7 @@
-CC: kbuild-all(a)lists.01.org
-CC: linux-kernel(a)vger.kernel.org
-TO: Maxime Ripard <maxime@cerno.tech>
-CC: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
-
 tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
 head:   79e06c4c4950be2abd8ca5d2428a8c915aa62c24
 commit: dec92020671c48da231189eb06a5f755f492f87f drm: Use the state pointer directly in planes atomic_check
-date:   11 months ago
-:::::: branch date: 9 hours ago
-:::::: commit date: 11 months ago
-config: arm-randconfig-m031-20220116 (https://download.01.org/0day-ci/archive/20220117/202201170744.uress2oV-lkp(a)intel.com/config)
+config: arm-randconfig-m031-20220116 (https://download.01.org/0day-ci/archive/20220117/202201170744.uress2oV-lkp@intel.com/config)
 compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
 
 If you fix the issue, kindly add following tag as appropriate
@@ -21,11 +13,13 @@ drivers/gpu/drm/armada/armada_plane.c:124 armada_drm_plane_atomic_check() warn:
 
 vim +/state +124 drivers/gpu/drm/armada/armada_plane.c
 
-d40af7b1ae23da Russell King  2018-07-30  107  
 d40af7b1ae23da Russell King  2018-07-30  108  int armada_drm_plane_atomic_check(struct drm_plane *plane,
 7c11b99a8e58c0 Maxime Ripard 2021-02-19  109  	struct drm_atomic_state *state)
 d40af7b1ae23da Russell King  2018-07-30  110  {
 7c11b99a8e58c0 Maxime Ripard 2021-02-19 @111  	struct drm_plane_state *new_plane_state = drm_atomic_get_new_plane_state(state,
+                                                                                                                         ^^^^^^
+Dereference
+
 7c11b99a8e58c0 Maxime Ripard 2021-02-19  112  										 plane);
 ba5c1649465d40 Maxime Ripard 2021-02-19  113  	struct armada_plane_state *st = to_armada_plane_state(new_plane_state);
 ba5c1649465d40 Maxime Ripard 2021-02-19  114  	struct drm_crtc *crtc = new_plane_state->crtc;
@@ -39,6 +33,9 @@ ba5c1649465d40 Maxime Ripard 2021-02-19  120  		new_plane_state->visible = false
 1d1547ec12bc7d Russell King  2019-01-25  122  	}
 d40af7b1ae23da Russell King  2018-07-30  123  
 dec92020671c48 Maxime Ripard 2021-02-19 @124  	if (state)
+                                                    ^^^^^
+Checked too late
+
 dec92020671c48 Maxime Ripard 2021-02-19  125  		crtc_state = drm_atomic_get_existing_crtc_state(state,
 ba5c1649465d40 Maxime Ripard 2021-02-19  126  								crtc);
 d40af7b1ae23da Russell King  2018-07-30  127  	else
@@ -48,36 +45,7 @@ ba5c1649465d40 Maxime Ripard 2021-02-19  130  	ret = drm_atomic_helper_check_pla
 ba5c1649465d40 Maxime Ripard 2021-02-19  131  						  0,
 1d1547ec12bc7d Russell King  2019-01-25  132  						  INT_MAX, true, false);
 1d1547ec12bc7d Russell King  2019-01-25  133  	if (ret)
-1d1547ec12bc7d Russell King  2019-01-25  134  		return ret;
-1d1547ec12bc7d Russell King  2019-01-25  135  
-1d1547ec12bc7d Russell King  2019-01-25  136  	interlace = crtc_state->adjusted_mode.flags & DRM_MODE_FLAG_INTERLACE;
-1d1547ec12bc7d Russell King  2019-01-25  137  	if (interlace) {
-ba5c1649465d40 Maxime Ripard 2021-02-19  138  		if ((new_plane_state->dst.y1 | new_plane_state->dst.y2) & 1)
-1d1547ec12bc7d Russell King  2019-01-25  139  			return -EINVAL;
-ba5c1649465d40 Maxime Ripard 2021-02-19  140  		st->src_hw = drm_rect_height(&new_plane_state->src) >> 17;
-ba5c1649465d40 Maxime Ripard 2021-02-19  141  		st->dst_yx = new_plane_state->dst.y1 >> 1;
-ba5c1649465d40 Maxime Ripard 2021-02-19  142  		st->dst_hw = drm_rect_height(&new_plane_state->dst) >> 1;
-d40af7b1ae23da Russell King  2018-07-30  143  	} else {
-ba5c1649465d40 Maxime Ripard 2021-02-19  144  		st->src_hw = drm_rect_height(&new_plane_state->src) >> 16;
-ba5c1649465d40 Maxime Ripard 2021-02-19  145  		st->dst_yx = new_plane_state->dst.y1;
-ba5c1649465d40 Maxime Ripard 2021-02-19  146  		st->dst_hw = drm_rect_height(&new_plane_state->dst);
-d40af7b1ae23da Russell King  2018-07-30  147  	}
-1d1547ec12bc7d Russell King  2019-01-25  148  
-1d1547ec12bc7d Russell King  2019-01-25  149  	st->src_hw <<= 16;
-ba5c1649465d40 Maxime Ripard 2021-02-19  150  	st->src_hw |= drm_rect_width(&new_plane_state->src) >> 16;
-1d1547ec12bc7d Russell King  2019-01-25  151  	st->dst_yx <<= 16;
-ba5c1649465d40 Maxime Ripard 2021-02-19  152  	st->dst_yx |= new_plane_state->dst.x1 & 0x0000ffff;
-1d1547ec12bc7d Russell King  2019-01-25  153  	st->dst_hw <<= 16;
-ba5c1649465d40 Maxime Ripard 2021-02-19  154  	st->dst_hw |= drm_rect_width(&new_plane_state->dst) & 0x0000ffff;
-1d1547ec12bc7d Russell King  2019-01-25  155  
-ba5c1649465d40 Maxime Ripard 2021-02-19  156  	armada_drm_plane_calc(new_plane_state, st->addrs, st->pitches,
-ba5c1649465d40 Maxime Ripard 2021-02-19  157  			      interlace);
-7d62237da6ec07 Russell King  2019-01-25  158  	st->interlace = interlace;
-7d62237da6ec07 Russell King  2019-01-25  159  
-d40af7b1ae23da Russell King  2018-07-30  160  	return 0;
-d40af7b1ae23da Russell King  2018-07-30  161  }
-d40af7b1ae23da Russell King  2018-07-30  162  
 
 ---
 0-DAY CI Kernel Test Service, Intel Corporation
-https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
+https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
diff --git a/a/content_digest b/N2/content_digest
index d11083e..598007e 100644
--- a/a/content_digest
+++ b/N2/content_digest
@@ -1,21 +1,18 @@
- "From\0kernel test robot <lkp@intel.com>\0"
+ "From\0Dan Carpenter <dan.carpenter@oracle.com>\0"
  "Subject\0drivers/gpu/drm/armada/armada_plane.c:124 armada_drm_plane_atomic_check() warn: variable dereferenced before check 'state' (see line 111)\0"
- "Date\0Mon, 17 Jan 2022 07:46:18 +0800\0"
- "To\0kbuild@lists.01.org\0"
- "\01:1\0"
+ "Date\0Tue, 18 Jan 2022 18:18:35 +0300\0"
+ "To\0kbuild@lists.01.org"
+ " Maxime Ripard <maxime@cerno.tech>\0"
+ "Cc\0lkp@intel.com"
+  kbuild-all@lists.01.org
+  linux-kernel@vger.kernel.org
+ " Laurent Pinchart <laurent.pinchart@ideasonboard.com>\0"
+ "\00:1\0"
  "b\0"
- "CC: kbuild-all(a)lists.01.org\n"
- "CC: linux-kernel(a)vger.kernel.org\n"
- "TO: Maxime Ripard <maxime@cerno.tech>\n"
- "CC: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n"
- "\n"
  "tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master\n"
  "head:   79e06c4c4950be2abd8ca5d2428a8c915aa62c24\n"
  "commit: dec92020671c48da231189eb06a5f755f492f87f drm: Use the state pointer directly in planes atomic_check\n"
- "date:   11 months ago\n"
- ":::::: branch date: 9 hours ago\n"
- ":::::: commit date: 11 months ago\n"
- "config: arm-randconfig-m031-20220116 (https://download.01.org/0day-ci/archive/20220117/202201170744.uress2oV-lkp(a)intel.com/config)\n"
+ "config: arm-randconfig-m031-20220116 (https://download.01.org/0day-ci/archive/20220117/202201170744.uress2oV-lkp@intel.com/config)\n"
  "compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0\n"
  "\n"
  "If you fix the issue, kindly add following tag as appropriate\n"
@@ -27,11 +24,13 @@
  "\n"
  "vim +/state +124 drivers/gpu/drm/armada/armada_plane.c\n"
  "\n"
- "d40af7b1ae23da Russell King  2018-07-30  107  \n"
  "d40af7b1ae23da Russell King  2018-07-30  108  int armada_drm_plane_atomic_check(struct drm_plane *plane,\n"
  "7c11b99a8e58c0 Maxime Ripard 2021-02-19  109  \tstruct drm_atomic_state *state)\n"
  "d40af7b1ae23da Russell King  2018-07-30  110  {\n"
  "7c11b99a8e58c0 Maxime Ripard 2021-02-19 @111  \tstruct drm_plane_state *new_plane_state = drm_atomic_get_new_plane_state(state,\n"
+ "                                                                                                                         ^^^^^^\n"
+ "Dereference\n"
+ "\n"
  "7c11b99a8e58c0 Maxime Ripard 2021-02-19  112  \t\t\t\t\t\t\t\t\t\t plane);\n"
  "ba5c1649465d40 Maxime Ripard 2021-02-19  113  \tstruct armada_plane_state *st = to_armada_plane_state(new_plane_state);\n"
  "ba5c1649465d40 Maxime Ripard 2021-02-19  114  \tstruct drm_crtc *crtc = new_plane_state->crtc;\n"
@@ -45,6 +44,9 @@
  "1d1547ec12bc7d Russell King  2019-01-25  122  \t}\n"
  "d40af7b1ae23da Russell King  2018-07-30  123  \n"
  "dec92020671c48 Maxime Ripard 2021-02-19 @124  \tif (state)\n"
+ "                                                    ^^^^^\n"
+ "Checked too late\n"
+ "\n"
  "dec92020671c48 Maxime Ripard 2021-02-19  125  \t\tcrtc_state = drm_atomic_get_existing_crtc_state(state,\n"
  "ba5c1649465d40 Maxime Ripard 2021-02-19  126  \t\t\t\t\t\t\t\tcrtc);\n"
  "d40af7b1ae23da Russell King  2018-07-30  127  \telse\n"
@@ -54,38 +56,9 @@
  "ba5c1649465d40 Maxime Ripard 2021-02-19  131  \t\t\t\t\t\t  0,\n"
  "1d1547ec12bc7d Russell King  2019-01-25  132  \t\t\t\t\t\t  INT_MAX, true, false);\n"
  "1d1547ec12bc7d Russell King  2019-01-25  133  \tif (ret)\n"
- "1d1547ec12bc7d Russell King  2019-01-25  134  \t\treturn ret;\n"
- "1d1547ec12bc7d Russell King  2019-01-25  135  \n"
- "1d1547ec12bc7d Russell King  2019-01-25  136  \tinterlace = crtc_state->adjusted_mode.flags & DRM_MODE_FLAG_INTERLACE;\n"
- "1d1547ec12bc7d Russell King  2019-01-25  137  \tif (interlace) {\n"
- "ba5c1649465d40 Maxime Ripard 2021-02-19  138  \t\tif ((new_plane_state->dst.y1 | new_plane_state->dst.y2) & 1)\n"
- "1d1547ec12bc7d Russell King  2019-01-25  139  \t\t\treturn -EINVAL;\n"
- "ba5c1649465d40 Maxime Ripard 2021-02-19  140  \t\tst->src_hw = drm_rect_height(&new_plane_state->src) >> 17;\n"
- "ba5c1649465d40 Maxime Ripard 2021-02-19  141  \t\tst->dst_yx = new_plane_state->dst.y1 >> 1;\n"
- "ba5c1649465d40 Maxime Ripard 2021-02-19  142  \t\tst->dst_hw = drm_rect_height(&new_plane_state->dst) >> 1;\n"
- "d40af7b1ae23da Russell King  2018-07-30  143  \t} else {\n"
- "ba5c1649465d40 Maxime Ripard 2021-02-19  144  \t\tst->src_hw = drm_rect_height(&new_plane_state->src) >> 16;\n"
- "ba5c1649465d40 Maxime Ripard 2021-02-19  145  \t\tst->dst_yx = new_plane_state->dst.y1;\n"
- "ba5c1649465d40 Maxime Ripard 2021-02-19  146  \t\tst->dst_hw = drm_rect_height(&new_plane_state->dst);\n"
- "d40af7b1ae23da Russell King  2018-07-30  147  \t}\n"
- "1d1547ec12bc7d Russell King  2019-01-25  148  \n"
- "1d1547ec12bc7d Russell King  2019-01-25  149  \tst->src_hw <<= 16;\n"
- "ba5c1649465d40 Maxime Ripard 2021-02-19  150  \tst->src_hw |= drm_rect_width(&new_plane_state->src) >> 16;\n"
- "1d1547ec12bc7d Russell King  2019-01-25  151  \tst->dst_yx <<= 16;\n"
- "ba5c1649465d40 Maxime Ripard 2021-02-19  152  \tst->dst_yx |= new_plane_state->dst.x1 & 0x0000ffff;\n"
- "1d1547ec12bc7d Russell King  2019-01-25  153  \tst->dst_hw <<= 16;\n"
- "ba5c1649465d40 Maxime Ripard 2021-02-19  154  \tst->dst_hw |= drm_rect_width(&new_plane_state->dst) & 0x0000ffff;\n"
- "1d1547ec12bc7d Russell King  2019-01-25  155  \n"
- "ba5c1649465d40 Maxime Ripard 2021-02-19  156  \tarmada_drm_plane_calc(new_plane_state, st->addrs, st->pitches,\n"
- "ba5c1649465d40 Maxime Ripard 2021-02-19  157  \t\t\t      interlace);\n"
- "7d62237da6ec07 Russell King  2019-01-25  158  \tst->interlace = interlace;\n"
- "7d62237da6ec07 Russell King  2019-01-25  159  \n"
- "d40af7b1ae23da Russell King  2018-07-30  160  \treturn 0;\n"
- "d40af7b1ae23da Russell King  2018-07-30  161  }\n"
- "d40af7b1ae23da Russell King  2018-07-30  162  \n"
  "\n"
  "---\n"
  "0-DAY CI Kernel Test Service, Intel Corporation\n"
- https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
+ https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
 
-e38b55a749915b433560fa23a4a3a3c722f5b548ca3b48fb4ebfc0f4c57d584f
+af9087c406193fbaabcd54ccc5eb4f645eeee76de0812a6533b1a74aeeef19d2

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.