From: Christoph Hellwig <hch@lst.de>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Jan Kara <jack@suse.cz>, Christoph Hellwig <hch@lst.de>,
Jens Axboe <axboe@kernel.dk>,
Dan Schatzberg <schatzberg.dan@gmail.com>,
kernel test robot <oliver.sang@intel.com>,
Jan Stancek <jstancek@redhat.com>,
linux-block <linux-block@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] loop: use task_work for autoclear operation
Date: Mon, 17 Jan 2022 09:15:54 +0100 [thread overview]
Message-ID: <20220117081554.GA22708@lst.de> (raw)
In-Reply-To: <33f360ca-d3e1-7070-654e-26ef22109a61@I-love.SAKURA.ne.jp>
On Sat, Jan 15, 2022 at 09:34:10AM +0900, Tetsuo Handa wrote:
> Christoph is not a fan of proliferating the use of task_work_add(). Can we go with exporting task_work_add()
Not a fan != NAK. If we can't think of anything better we'll have to do
that. Note that I also have a task_work_add API cleanup pending that makes
it a lot less ugly.
> for this release cycle? Or instead can we go with providing release() callback without disk->open_mutex held
> ( https://lkml.kernel.org/r/08d703d1-8b32-ec9b-2b50-54b8376d3d40@i-love.sakura.ne.jp ) ?
This one OTOH is a hard NAK as this is an API that will just cause a lot
of problems.
next prev parent reply other threads:[~2022-01-17 8:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 11:00 [PATCH v2 1/2] block: export task_work_add() Tetsuo Handa
2022-01-07 11:04 ` [PATCH v2 2/2] loop: use task_work for autoclear operation Tetsuo Handa
2022-01-10 6:20 ` Jan Stancek
2022-01-10 10:30 ` Jan Kara
2022-01-10 11:28 ` Tetsuo Handa
2022-01-10 13:42 ` Jan Kara
2022-01-10 15:08 ` Tetsuo Handa
2022-01-12 13:16 ` Jan Kara
2022-01-12 14:00 ` Tetsuo Handa
2022-01-13 15:23 ` Jan Kara
2022-01-14 11:05 ` Tetsuo Handa
2022-01-14 16:05 ` Jan Kara
2022-01-13 10:44 ` Jan Kara
2022-01-14 15:50 ` Tetsuo Handa
2022-01-14 19:58 ` Jan Kara
2022-01-15 0:34 ` Tetsuo Handa
2022-01-17 8:15 ` Christoph Hellwig [this message]
2022-01-17 9:34 ` Tetsuo Handa
2022-01-17 14:10 ` Tetsuo Handa
2022-01-18 15:58 ` Tetsuo Handa
2022-01-18 16:15 ` Christoph Hellwig
2022-01-20 14:20 ` Christoph Hellwig
2022-01-20 15:42 ` Jan Kara
2022-01-10 16:40 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220117081554.GA22708@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=jack@suse.cz \
--cc=jstancek@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=oliver.sang@intel.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=schatzberg.dan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.