diff for duplicates of <202201170928.GcIhOWMI-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index 85887ba..c1fffc7 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,13 +1,6 @@ -CC: kbuild-all(a)lists.01.org -CC: "Darrick J. Wong" <darrick.wong@oracle.com> -CC: linux-kernel(a)vger.kernel.org -TO: "Darrick J. Wong" <djwong@kernel.org> - tree: https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git vectorized-scrub head: 8427da8e62fbcf9a04e5b2663fe60b97d6911417 commit: 8dd594d12f08acc6c6fa388b2cae3e270bf8effc [99/334] xfs: stabilize fs summary counters for online fsck -:::::: branch date: 2 days ago -:::::: commit date: 2 days ago config: ia64-randconfig-m031-20220116 (https://download.01.org/0day-ci/archive/20220117/202201170928.GcIhOWMI-lkp(a)intel.com/config) compiler: ia64-linux-gcc (GCC) 11.2.0 @@ -20,14 +13,6 @@ fs/xfs/scrub/fscounters.c:198 xchk_fscounters_freeze() warn: inconsistent return vim +198 fs/xfs/scrub/fscounters.c -8dd594d12f08acc Darrick J. Wong 2022-01-06 117 -8dd594d12f08acc Darrick J. Wong 2022-01-06 118 /* -8dd594d12f08acc Darrick J. Wong 2022-01-06 119 * We couldn't stabilize the filesystem long enough to sample all the variables -8dd594d12f08acc Darrick J. Wong 2022-01-06 120 * that comprise the summary counters and compare them to the percpu counters. -8dd594d12f08acc Darrick J. Wong 2022-01-06 121 * We need to disable all writer threads, which means taking the first two -8dd594d12f08acc Darrick J. Wong 2022-01-06 122 * freeze levels to put userspace to sleep, and the third freeze level to -8dd594d12f08acc Darrick J. Wong 2022-01-06 123 * prevent background threads from starting new transactions. -8dd594d12f08acc Darrick J. Wong 2022-01-06 124 */ 8dd594d12f08acc Darrick J. Wong 2022-01-06 125 STATIC int 8dd594d12f08acc Darrick J. Wong 2022-01-06 126 xchk_fscounters_freeze( 8dd594d12f08acc Darrick J. Wong 2022-01-06 127 struct xfs_scrub *sc) @@ -81,6 +66,9 @@ vim +198 fs/xfs/scrub/fscounters.c 8dd594d12f08acc Darrick J. Wong 2022-01-06 175 for (level = SB_FREEZE_PAGEFAULT; level >= 0; level--) 8dd594d12f08acc Darrick J. Wong 2022-01-06 176 percpu_up_write(sb->s_writers.rw_sem + level); 8dd594d12f08acc Darrick J. Wong 2022-01-06 177 wake_up(&sb->s_writers.wait_unfrozen); + +Smatch wanted an up_write(&sb->s_umount); but this looks intentional? + 8dd594d12f08acc Darrick J. Wong 2022-01-06 178 return error; 8dd594d12f08acc Darrick J. Wong 2022-01-06 179 } 8dd594d12f08acc Darrick J. Wong 2022-01-06 180 @@ -103,7 +91,6 @@ vim +198 fs/xfs/scrub/fscounters.c 8dd594d12f08acc Darrick J. Wong 2022-01-06 197 up_write(&sb->s_umount); 8dd594d12f08acc Darrick J. Wong 2022-01-06 @198 return 0; 8dd594d12f08acc Darrick J. Wong 2022-01-06 199 } -8dd594d12f08acc Darrick J. Wong 2022-01-06 200 --- 0-DAY CI Kernel Test Service, Intel Corporation diff --git a/a/content_digest b/N1/content_digest index 5656368..dc8803f 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,19 +1,12 @@ - "From\0kernel test robot <lkp@intel.com>\0" + "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0[djwong-xfs:vectorized-scrub 99/334] fs/xfs/scrub/fscounters.c:198 xchk_fscounters_freeze() warn: inconsistent returns '&sb->s_umount'.\0" - "Date\0Mon, 17 Jan 2022 09:48:51 +0800\0" - "To\0kbuild@lists.01.org\0" + "Date\0Wed, 19 Jan 2022 06:58:29 +0300\0" + "To\0kbuild-all@lists.01.org\0" "\01:1\0" "b\0" - "CC: kbuild-all(a)lists.01.org\n" - "CC: \"Darrick J. Wong\" <darrick.wong@oracle.com>\n" - "CC: linux-kernel(a)vger.kernel.org\n" - "TO: \"Darrick J. Wong\" <djwong@kernel.org>\n" - "\n" "tree: https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git vectorized-scrub\n" "head: 8427da8e62fbcf9a04e5b2663fe60b97d6911417\n" "commit: 8dd594d12f08acc6c6fa388b2cae3e270bf8effc [99/334] xfs: stabilize fs summary counters for online fsck\n" - ":::::: branch date: 2 days ago\n" - ":::::: commit date: 2 days ago\n" "config: ia64-randconfig-m031-20220116 (https://download.01.org/0day-ci/archive/20220117/202201170928.GcIhOWMI-lkp(a)intel.com/config)\n" "compiler: ia64-linux-gcc (GCC) 11.2.0\n" "\n" @@ -26,14 +19,6 @@ "\n" "vim +198 fs/xfs/scrub/fscounters.c\n" "\n" - "8dd594d12f08acc Darrick J. Wong 2022-01-06 117 \n" - "8dd594d12f08acc Darrick J. Wong 2022-01-06 118 /*\n" - "8dd594d12f08acc Darrick J. Wong 2022-01-06 119 * We couldn't stabilize the filesystem long enough to sample all the variables\n" - "8dd594d12f08acc Darrick J. Wong 2022-01-06 120 * that comprise the summary counters and compare them to the percpu counters.\n" - "8dd594d12f08acc Darrick J. Wong 2022-01-06 121 * We need to disable all writer threads, which means taking the first two\n" - "8dd594d12f08acc Darrick J. Wong 2022-01-06 122 * freeze levels to put userspace to sleep, and the third freeze level to\n" - "8dd594d12f08acc Darrick J. Wong 2022-01-06 123 * prevent background threads from starting new transactions.\n" - "8dd594d12f08acc Darrick J. Wong 2022-01-06 124 */\n" "8dd594d12f08acc Darrick J. Wong 2022-01-06 125 STATIC int\n" "8dd594d12f08acc Darrick J. Wong 2022-01-06 126 xchk_fscounters_freeze(\n" "8dd594d12f08acc Darrick J. Wong 2022-01-06 127 \tstruct xfs_scrub\t*sc)\n" @@ -87,6 +72,9 @@ "8dd594d12f08acc Darrick J. Wong 2022-01-06 175 \t\tfor (level = SB_FREEZE_PAGEFAULT; level >= 0; level--)\n" "8dd594d12f08acc Darrick J. Wong 2022-01-06 176 \t\t\tpercpu_up_write(sb->s_writers.rw_sem + level);\n" "8dd594d12f08acc Darrick J. Wong 2022-01-06 177 \t\twake_up(&sb->s_writers.wait_unfrozen);\n" + "\n" + "Smatch wanted an up_write(&sb->s_umount); but this looks intentional?\n" + "\n" "8dd594d12f08acc Darrick J. Wong 2022-01-06 178 \t\treturn error;\n" "8dd594d12f08acc Darrick J. Wong 2022-01-06 179 \t}\n" "8dd594d12f08acc Darrick J. Wong 2022-01-06 180 \n" @@ -109,10 +97,9 @@ "8dd594d12f08acc Darrick J. Wong 2022-01-06 197 \tup_write(&sb->s_umount);\n" "8dd594d12f08acc Darrick J. Wong 2022-01-06 @198 \treturn 0;\n" "8dd594d12f08acc Darrick J. Wong 2022-01-06 199 }\n" - "8dd594d12f08acc Darrick J. Wong 2022-01-06 200 \n" "\n" "---\n" "0-DAY CI Kernel Test Service, Intel Corporation\n" https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org -197fe5cb2a191703d68a86c71f3f4182029f1defeb9d2883946c33669a4c10a1 +019204d5e612f9a0d93ad9d75c6a8af101c66b29a14895aaf77f48a44651635b
diff --git a/a/1.txt b/N2/1.txt index 85887ba..09d4f74 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,14 +1,7 @@ -CC: kbuild-all(a)lists.01.org -CC: "Darrick J. Wong" <darrick.wong@oracle.com> -CC: linux-kernel(a)vger.kernel.org -TO: "Darrick J. Wong" <djwong@kernel.org> - tree: https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git vectorized-scrub head: 8427da8e62fbcf9a04e5b2663fe60b97d6911417 commit: 8dd594d12f08acc6c6fa388b2cae3e270bf8effc [99/334] xfs: stabilize fs summary counters for online fsck -:::::: branch date: 2 days ago -:::::: commit date: 2 days ago -config: ia64-randconfig-m031-20220116 (https://download.01.org/0day-ci/archive/20220117/202201170928.GcIhOWMI-lkp(a)intel.com/config) +config: ia64-randconfig-m031-20220116 (https://download.01.org/0day-ci/archive/20220117/202201170928.GcIhOWMI-lkp@intel.com/config) compiler: ia64-linux-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate @@ -20,14 +13,6 @@ fs/xfs/scrub/fscounters.c:198 xchk_fscounters_freeze() warn: inconsistent return vim +198 fs/xfs/scrub/fscounters.c -8dd594d12f08acc Darrick J. Wong 2022-01-06 117 -8dd594d12f08acc Darrick J. Wong 2022-01-06 118 /* -8dd594d12f08acc Darrick J. Wong 2022-01-06 119 * We couldn't stabilize the filesystem long enough to sample all the variables -8dd594d12f08acc Darrick J. Wong 2022-01-06 120 * that comprise the summary counters and compare them to the percpu counters. -8dd594d12f08acc Darrick J. Wong 2022-01-06 121 * We need to disable all writer threads, which means taking the first two -8dd594d12f08acc Darrick J. Wong 2022-01-06 122 * freeze levels to put userspace to sleep, and the third freeze level to -8dd594d12f08acc Darrick J. Wong 2022-01-06 123 * prevent background threads from starting new transactions. -8dd594d12f08acc Darrick J. Wong 2022-01-06 124 */ 8dd594d12f08acc Darrick J. Wong 2022-01-06 125 STATIC int 8dd594d12f08acc Darrick J. Wong 2022-01-06 126 xchk_fscounters_freeze( 8dd594d12f08acc Darrick J. Wong 2022-01-06 127 struct xfs_scrub *sc) @@ -81,6 +66,9 @@ vim +198 fs/xfs/scrub/fscounters.c 8dd594d12f08acc Darrick J. Wong 2022-01-06 175 for (level = SB_FREEZE_PAGEFAULT; level >= 0; level--) 8dd594d12f08acc Darrick J. Wong 2022-01-06 176 percpu_up_write(sb->s_writers.rw_sem + level); 8dd594d12f08acc Darrick J. Wong 2022-01-06 177 wake_up(&sb->s_writers.wait_unfrozen); + +Smatch wanted an up_write(&sb->s_umount); but this looks intentional? + 8dd594d12f08acc Darrick J. Wong 2022-01-06 178 return error; 8dd594d12f08acc Darrick J. Wong 2022-01-06 179 } 8dd594d12f08acc Darrick J. Wong 2022-01-06 180 @@ -103,8 +91,7 @@ vim +198 fs/xfs/scrub/fscounters.c 8dd594d12f08acc Darrick J. Wong 2022-01-06 197 up_write(&sb->s_umount); 8dd594d12f08acc Darrick J. Wong 2022-01-06 @198 return 0; 8dd594d12f08acc Darrick J. Wong 2022-01-06 199 } -8dd594d12f08acc Darrick J. Wong 2022-01-06 200 --- 0-DAY CI Kernel Test Service, Intel Corporation -https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org +https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org diff --git a/a/content_digest b/N2/content_digest index 5656368..12fe650 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,20 +1,18 @@ - "From\0kernel test robot <lkp@intel.com>\0" + "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0[djwong-xfs:vectorized-scrub 99/334] fs/xfs/scrub/fscounters.c:198 xchk_fscounters_freeze() warn: inconsistent returns '&sb->s_umount'.\0" - "Date\0Mon, 17 Jan 2022 09:48:51 +0800\0" - "To\0kbuild@lists.01.org\0" - "\01:1\0" + "Date\0Wed, 19 Jan 2022 06:58:29 +0300\0" + "To\0kbuild@lists.01.org" + " Darrick J. Wong <djwong@kernel.org>\0" + "Cc\0lkp@intel.com" + kbuild-all@lists.01.org + Darrick J. Wong <darrick.wong@oracle.com> + " linux-kernel@vger.kernel.org\0" + "\00:1\0" "b\0" - "CC: kbuild-all(a)lists.01.org\n" - "CC: \"Darrick J. Wong\" <darrick.wong@oracle.com>\n" - "CC: linux-kernel(a)vger.kernel.org\n" - "TO: \"Darrick J. Wong\" <djwong@kernel.org>\n" - "\n" "tree: https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git vectorized-scrub\n" "head: 8427da8e62fbcf9a04e5b2663fe60b97d6911417\n" "commit: 8dd594d12f08acc6c6fa388b2cae3e270bf8effc [99/334] xfs: stabilize fs summary counters for online fsck\n" - ":::::: branch date: 2 days ago\n" - ":::::: commit date: 2 days ago\n" - "config: ia64-randconfig-m031-20220116 (https://download.01.org/0day-ci/archive/20220117/202201170928.GcIhOWMI-lkp(a)intel.com/config)\n" + "config: ia64-randconfig-m031-20220116 (https://download.01.org/0day-ci/archive/20220117/202201170928.GcIhOWMI-lkp@intel.com/config)\n" "compiler: ia64-linux-gcc (GCC) 11.2.0\n" "\n" "If you fix the issue, kindly add following tag as appropriate\n" @@ -26,14 +24,6 @@ "\n" "vim +198 fs/xfs/scrub/fscounters.c\n" "\n" - "8dd594d12f08acc Darrick J. Wong 2022-01-06 117 \n" - "8dd594d12f08acc Darrick J. Wong 2022-01-06 118 /*\n" - "8dd594d12f08acc Darrick J. Wong 2022-01-06 119 * We couldn't stabilize the filesystem long enough to sample all the variables\n" - "8dd594d12f08acc Darrick J. Wong 2022-01-06 120 * that comprise the summary counters and compare them to the percpu counters.\n" - "8dd594d12f08acc Darrick J. Wong 2022-01-06 121 * We need to disable all writer threads, which means taking the first two\n" - "8dd594d12f08acc Darrick J. Wong 2022-01-06 122 * freeze levels to put userspace to sleep, and the third freeze level to\n" - "8dd594d12f08acc Darrick J. Wong 2022-01-06 123 * prevent background threads from starting new transactions.\n" - "8dd594d12f08acc Darrick J. Wong 2022-01-06 124 */\n" "8dd594d12f08acc Darrick J. Wong 2022-01-06 125 STATIC int\n" "8dd594d12f08acc Darrick J. Wong 2022-01-06 126 xchk_fscounters_freeze(\n" "8dd594d12f08acc Darrick J. Wong 2022-01-06 127 \tstruct xfs_scrub\t*sc)\n" @@ -87,6 +77,9 @@ "8dd594d12f08acc Darrick J. Wong 2022-01-06 175 \t\tfor (level = SB_FREEZE_PAGEFAULT; level >= 0; level--)\n" "8dd594d12f08acc Darrick J. Wong 2022-01-06 176 \t\t\tpercpu_up_write(sb->s_writers.rw_sem + level);\n" "8dd594d12f08acc Darrick J. Wong 2022-01-06 177 \t\twake_up(&sb->s_writers.wait_unfrozen);\n" + "\n" + "Smatch wanted an up_write(&sb->s_umount); but this looks intentional?\n" + "\n" "8dd594d12f08acc Darrick J. Wong 2022-01-06 178 \t\treturn error;\n" "8dd594d12f08acc Darrick J. Wong 2022-01-06 179 \t}\n" "8dd594d12f08acc Darrick J. Wong 2022-01-06 180 \n" @@ -109,10 +102,9 @@ "8dd594d12f08acc Darrick J. Wong 2022-01-06 197 \tup_write(&sb->s_umount);\n" "8dd594d12f08acc Darrick J. Wong 2022-01-06 @198 \treturn 0;\n" "8dd594d12f08acc Darrick J. Wong 2022-01-06 199 }\n" - "8dd594d12f08acc Darrick J. Wong 2022-01-06 200 \n" "\n" "---\n" "0-DAY CI Kernel Test Service, Intel Corporation\n" - https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org + https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org -197fe5cb2a191703d68a86c71f3f4182029f1defeb9d2883946c33669a4c10a1 +c964a653a36ccf95f74234089b04ec4ebf7f4a7bb2df42aff56f91a940b94a76
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.