From: Stephen Hemminger <stephen@networkplumber.org>
To: Wen Liang <liangwen12year@gmail.com>
Cc: netdev@vger.kernel.org, dsahern@gmail.com, aclaudi@redhat.com
Subject: Re: [PATCH iproute2 v4 1/2] tc: u32: add support for json output
Date: Mon, 17 Jan 2022 20:30:44 -0800 [thread overview]
Message-ID: <20220117203044.0950e959@hermes.local> (raw)
In-Reply-To: <5d67bd669fe97a9a797263e18718cec3dab88cc4.1642472827.git.wenliang@redhat.com>
On Mon, 17 Jan 2022 21:42:20 -0500
Wen Liang <liangwen12year@gmail.com> wrote:
> Currently u32 filter output does not support json. This commit uses
> proper json functions to add support for it.
>
> Signed-off-by: Wen Liang <liangwen12year@gmail.com>
Minor warnings from checkpatch, please fix:
WARNING: Missing a blank line after declarations
#88: FILE: tc/f_u32.c:1231:
+ __u32 htdivisor = rta_getattr_u32(tb[TCA_U32_DIVISOR]);
+ print_int(PRINT_ANY, "ht_divisor", "ht divisor %d ", htdivisor);
ERROR: space required after that ',' (ctx:VxV)
#114: FILE: tc/f_u32.c:1250:
+ char *link = sprint_u32_handle(rta_getattr_u32(tb[TCA_U32_LINK]),b1);
^
WARNING: Missing a blank line after declarations
#115: FILE: tc/f_u32.c:1251:
+ char *link = sprint_u32_handle(rta_getattr_u32(tb[TCA_U32_LINK]),b1);
+ print_string(PRINT_ANY, "link", "link %s ", link);
WARNING: Missing a blank line after declarations
#202: FILE: tc/f_u32.c:1323:
+ unsigned int hmask = (unsigned int)htonl(sel->hmask);
+ print_hex(PRINT_ANY, "hash_mask", " hash mask %08x ", hmask);
total: 1 errors, 3 warnings, 151 lines checked
next prev parent reply other threads:[~2022-01-18 4:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 2:42 [PATCH iproute2 v4 0/2] add json support on tc u32 Wen Liang
2022-01-18 2:42 ` [PATCH iproute2 v4 1/2] tc: u32: add support for json output Wen Liang
2022-01-18 4:30 ` Stephen Hemminger [this message]
2022-01-18 20:04 ` David Ahern
2022-01-18 2:42 ` [PATCH iproute2 v4 2/2] tc: u32: add json support in `print_raw`, `print_ipv4`, `print_ipv6` Wen Liang
2022-01-18 4:32 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220117203044.0950e959@hermes.local \
--to=stephen@networkplumber.org \
--cc=aclaudi@redhat.com \
--cc=dsahern@gmail.com \
--cc=liangwen12year@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.