From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CE0BC433FE for ; Tue, 18 Jan 2022 03:02:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352294AbiARC7k (ORCPT ); Mon, 17 Jan 2022 21:59:40 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:56672 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344518AbiARCsB (ORCPT ); Mon, 17 Jan 2022 21:48:01 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3F55BB81258; Tue, 18 Jan 2022 02:48:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06CAEC36AF2; Tue, 18 Jan 2022 02:47:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642474079; bh=ToQmvWXHSHE2XdXe3ciESHrugSQBmGxe7tlPv0Rn18M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=a1QJ/3Yb8eXq5XmyDqTraHvS3v1oETVR8Nu2oMrHCj4NB2r3YSd01+dIZ9AFko2LG 7mPA/gdLTm2bqMtACxnY3TAxOUCNPWVOGTUc09lr+o1/177lCvzx/MobVTrVh6KFmU ZpNgwoNptt9+PoR93OV/jOu8KEeYRXqyF5ygvvpdlZeWxsMTiBvtFXk6NCazkTFXgC JiWjUuhRRMdk/JiQ4IN4SPuQbmYsH+XdZ7QhAO/mKAll4YmkF1anRXF7KCn3Mo3AYX 7osgXLkeoNmaXUuI6cJBcuLUqGiyLxFzilMM1R4TwmybfU0On8vH0k7O6xhgwQa+87 e+C9Y6hNaqnDQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Borislav Petkov , Sasha Levin , tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org Subject: [PATCH AUTOSEL 4.19 25/59] x86/mce: Mark mce_end() noinstr Date: Mon, 17 Jan 2022 21:46:26 -0500 Message-Id: <20220118024701.1952911-25-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220118024701.1952911-1-sashal@kernel.org> References: <20220118024701.1952911-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Borislav Petkov [ Upstream commit b4813539d37fa31fed62cdfab7bd2dd8929c5b2e ] It is called by the #MC handler which is noinstr. Fixes vmlinux.o: warning: objtool: do_machine_check()+0xbd6: call to memset() leaves .noinstr.text section Signed-off-by: Borislav Petkov Link: https://lore.kernel.org/r/20211208111343.8130-9-bp@alien8.de Signed-off-by: Sasha Levin --- arch/x86/kernel/cpu/mcheck/mce.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c index 56c4456434a82..26adaad3f2587 100644 --- a/arch/x86/kernel/cpu/mcheck/mce.c +++ b/arch/x86/kernel/cpu/mcheck/mce.c @@ -1030,10 +1030,13 @@ static int mce_start(int *no_way_out) * Synchronize between CPUs after main scanning loop. * This invokes the bulk of the Monarch processing. */ -static int mce_end(int order) +static noinstr int mce_end(int order) { - int ret = -1; u64 timeout = (u64)mca_cfg.monarch_timeout * NSEC_PER_USEC; + int ret = -1; + + /* Allow instrumentation around external facilities. */ + instrumentation_begin(); if (!timeout) goto reset; @@ -1077,7 +1080,8 @@ static int mce_end(int order) /* * Don't reset anything. That's done by the Monarch. */ - return 0; + ret = 0; + goto out; } /* @@ -1092,6 +1096,10 @@ static int mce_end(int order) * Let others run again. */ atomic_set(&mce_executing, 0); + +out: + instrumentation_end(); + return ret; } -- 2.34.1