From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58D9AC433EF for ; Tue, 18 Jan 2022 03:06:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353768AbiARDEf (ORCPT ); Mon, 17 Jan 2022 22:04:35 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:57488 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346119AbiARCsn (ORCPT ); Mon, 17 Jan 2022 21:48:43 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6B578B81249; Tue, 18 Jan 2022 02:48:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3CDE3C36AEF; Tue, 18 Jan 2022 02:48:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642474120; bh=qa0QEdGV5FAnk2I76Z96dramduwgsfY90rMZMTFx/SQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SK3j4fzN8lUmLMrzYUoLU0Hnpwq5Y7zEndx+gw7NwVe5+doWB4O1sD8lRVPylkU8F 9fv+rWL+EHScksk8YtksQs7CB5cJcMgepsOCQd1oqg4xl3dmSbqQk75KwRkxl0aaxe k/wMpI+plFfhoUMRhLCG9r64cFyRe9f3cH44qX/KVmG15j7suNF8WCiRR1qe3J62I2 mTl9Tz3YjmLNAtKBi9m++69mq+Wu9lih8SmaOUn7PhARTs4VJ1sqnd9Mw7/u3Me2/J I6z3KxaFdsEbSKmUlC0aCtQRXp7adjNl0MxhAX2xcr4dxoGMe5e9Md/X1PwY9Zvd2z daoDAQ4zNqfxQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: "Rafael J. Wysocki" , Mark Asselstine , Bob Moore , Sasha Levin , linux-acpi@vger.kernel.org, devel@acpica.org Subject: [PATCH AUTOSEL 4.19 43/59] ACPICA: Utilities: Avoid deleting the same object twice in a row Date: Mon, 17 Jan 2022 21:46:44 -0500 Message-Id: <20220118024701.1952911-43-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220118024701.1952911-1-sashal@kernel.org> References: <20220118024701.1952911-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org From: "Rafael J. Wysocki" [ Upstream commit 1cdfe9e346b4c5509ffe19ccde880fd259d9f7a3 ] ACPICA commit c11af67d8f7e3d381068ce7771322f2b5324d687 If original_count is 0 in acpi_ut_update_ref_count (), acpi_ut_delete_internal_obj () is invoked for the target object, which is incorrect, because that object has been deleted once already and the memory allocated to store it may have been reclaimed and allocated for a different purpose by the host OS. Moreover, a confusing debug message following the "Reference Count is already zero, cannot decrement" warning is printed in that case. To fix this issue, make acpi_ut_update_ref_count () return after finding that original_count is 0 and printing the above warning. Link: https://github.com/acpica/acpica/commit/c11af67d Link: https://github.com/acpica/acpica/pull/652 Reported-by: Mark Asselstine Signed-off-by: Rafael J. Wysocki Signed-off-by: Bob Moore Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/acpi/acpica/utdelete.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/acpi/acpica/utdelete.c b/drivers/acpi/acpica/utdelete.c index 0dc8dea815823..db79a826e6b8d 100644 --- a/drivers/acpi/acpica/utdelete.c +++ b/drivers/acpi/acpica/utdelete.c @@ -410,6 +410,7 @@ acpi_ut_update_ref_count(union acpi_operand_object *object, u32 action) ACPI_WARNING((AE_INFO, "Obj %p, Reference Count is already zero, cannot decrement\n", object)); + return; } ACPI_DEBUG_PRINT_RAW((ACPI_DB_ALLOCATIONS, -- 2.34.1