From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7236AC433F5 for ; Tue, 18 Jan 2022 03:07:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349006AbiARDHR (ORCPT ); Mon, 17 Jan 2022 22:07:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353439AbiARDBs (ORCPT ); Mon, 17 Jan 2022 22:01:48 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D2E9C08EA40; Mon, 17 Jan 2022 18:47:15 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0A2D06130D; Tue, 18 Jan 2022 02:47:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2D70C36AE3; Tue, 18 Jan 2022 02:47:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642474034; bh=+aGuwueJniqiioIn5b6jEmBIotGjO8kDhMbexpL+TjI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bml8VLfsYr9QEZz5QcKetdRATpyDoQl2+IhS+7pnIoILl0UtQtjF8i7wVP3a0t+q3 5tZQLM6wnEs/d/ubzjNw+aKLvrPCywYegxWj0iC7k9XM5M3R1yuJZ/cxSP6zdg9QjI 9aVeQPvw96qbZEpDB2fNVPwjtXbOJj2ADE47xsUMtrUw5Pb2UdG/EnrRgAA9gBCnPn gGF03KpTR1eIfEq/jywzWVKsl0Fnmwdl6KiiKsg8eDjAympYBgi6fm6mlQ7zO+uacv yC5q/hUxmEy/3V9qKWVo7PjLgpvhANiLSagTiF4pHEwSdvnKKR1imPNSL70/RyZpxu iuHS7B1mgj9ww== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Pavankumar Kondeti , John Keeping , Greg Kroah-Hartman , Sasha Levin , balbi@kernel.org, axboe@kernel.dk, jj251510319013@gmail.com, salah.triki@gmail.com, plr.vincent@gmail.com, andrew_gabbasov@mentor.com, dean@sensoray.com, lkp@intel.com, wcheng@codeaurora.org, linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 05/59] usb: gadget: f_fs: Use stream_open() for endpoint files Date: Mon, 17 Jan 2022 21:46:06 -0500 Message-Id: <20220118024701.1952911-5-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220118024701.1952911-1-sashal@kernel.org> References: <20220118024701.1952911-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: Pavankumar Kondeti [ Upstream commit c76ef96fc00eb398c8fc836b0eb2f82bcc619dc7 ] Function fs endpoint file operations are synchronized via an interruptible mutex wait. However we see threads that do ep file operations concurrently are getting blocked for the mutex lock in __fdget_pos(). This is an uninterruptible wait and we see hung task warnings and kernel panic if hung_task_panic systcl is enabled if host does not send/receive the data for long time. The reason for threads getting blocked in __fdget_pos() is due to the file position protection introduced by the commit 9c225f2655e3 ("vfs: atomic f_pos accesses as per POSIX"). Since function fs endpoint files does not have the notion of the file position, switch to the stream mode. This will bypass the file position mutex and threads will be blocked in interruptible state for the function fs mutex. It should not affects user space as we are only changing the task state changes the task state from UNINTERRUPTIBLE to INTERRUPTIBLE while waiting for the USB transfers to be finished. However there is a slight change to the O_NONBLOCK behavior. Earlier threads that are using O_NONBLOCK are also getting blocked inside fdget_pos(). Now they reach to function fs and error code is returned. The non blocking behavior is actually honoured now. Reviewed-by: John Keeping Signed-off-by: Pavankumar Kondeti Link: https://lore.kernel.org/r/1636712682-1226-1-git-send-email-quic_pkondeti@quicinc.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/gadget/function/f_fs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c index f070082124742..9271a7009a00f 100644 --- a/drivers/usb/gadget/function/f_fs.c +++ b/drivers/usb/gadget/function/f_fs.c @@ -607,7 +607,7 @@ static int ffs_ep0_open(struct inode *inode, struct file *file) file->private_data = ffs; ffs_data_opened(ffs); - return 0; + return stream_open(inode, file); } static int ffs_ep0_release(struct inode *inode, struct file *file) @@ -1071,7 +1071,7 @@ ffs_epfile_open(struct inode *inode, struct file *file) file->private_data = epfile; ffs_data_opened(epfile->ffs); - return 0; + return stream_open(inode, file); } static int ffs_aio_cancel(struct kiocb *kiocb) -- 2.34.1