From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B02FC4321E for ; Tue, 18 Jan 2022 03:23:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357412AbiARDVB (ORCPT ); Mon, 17 Jan 2022 22:21:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245560AbiARDIZ (ORCPT ); Mon, 17 Jan 2022 22:08:25 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68C81C061772; Mon, 17 Jan 2022 18:49:48 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2CF3DB811CE; Tue, 18 Jan 2022 02:49:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4DBEDC36AEB; Tue, 18 Jan 2022 02:49:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642474186; bh=8JYy8KLrdmJzlsmiDpIK0DRnY+qIHzoKESt35xIokH8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eim4IWhe1hyYT3drzlDuyb7ohixIwf1jUI+54jZpHZgAv6WV9H5dQEHn3pbVTh5Zu n3zc6IrKTSI19HlEoN9BIzon6uhHiHhY4ey8QAsKoT5JZbnPjYlX4Gg7ai+aRyQW6e oeWeApMZGfkYDaePVE4hk6rwZ4EoHnpP7WmkQ1yseNdBb20aiV8xPhdYuM2jCmjwKl FRcwpf+QvxCoPgs3jjZCIewOCTZB8YJz3+eBupC4Iv/yR1kuVWiPmyKM/olTunNuJp fLrd1szGSbVL6eEex3LAt4kqKbivb54g1f6VpYvy2Dk4/cWWe9XJEJtjHEAS1lmj2G 1liz00r2Q/gvw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jakub Kicinski , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 12/56] cirrus: mac89x0: use eth_hw_addr_set() Date: Mon, 17 Jan 2022 21:48:24 -0500 Message-Id: <20220118024908.1953673-12-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220118024908.1953673-1-sashal@kernel.org> References: <20220118024908.1953673-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jakub Kicinski [ Upstream commit 9a962aedd30f7fceb828d3161a80e0526e358eb5 ] Byte by byte assignments. Fixes build on m68k. Signed-off-by: Jakub Kicinski Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/cirrus/mac89x0.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cirrus/mac89x0.c b/drivers/net/ethernet/cirrus/mac89x0.c index f910f0f386d63..fae97ebb4ba07 100644 --- a/drivers/net/ethernet/cirrus/mac89x0.c +++ b/drivers/net/ethernet/cirrus/mac89x0.c @@ -268,12 +268,15 @@ struct net_device * __init mac89x0_probe(int unit) printk("\nmac89x0: No EEPROM, giving up now.\n"); goto out1; } else { + u8 addr[ETH_ALEN]; + for (i = 0; i < ETH_ALEN; i += 2) { /* Big-endian (why??!) */ unsigned short s = readreg(dev, PP_IA + i); - dev->dev_addr[i] = s >> 8; - dev->dev_addr[i+1] = s & 0xff; + addr[i] = s >> 8; + addr[i+1] = s & 0xff; } + eth_hw_addr_set(dev, addr); } dev->irq = SLOT2IRQ(slot); -- 2.34.1