From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B8EAC433FE for ; Tue, 18 Jan 2022 03:15:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350012AbiARDOj (ORCPT ); Mon, 17 Jan 2022 22:14:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350041AbiARDIJ (ORCPT ); Mon, 17 Jan 2022 22:08:09 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A17BC06176C; Mon, 17 Jan 2022 18:49:24 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1C5B0B811D6; Tue, 18 Jan 2022 02:49:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34227C36AE3; Tue, 18 Jan 2022 02:49:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642474161; bh=UUCikyKIDcs3Go+mASe8ngo1/9EOj+3ZGtzTSW63IPc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=o/NzaM6I0d7MgbVsKx4RcGIQmoDWOkU4Go7OoyMi/fyrrtdzJPPgBIx1g7v+bkh4V A2bFP/ZPiakyqZi/KrS0ww75AxKJgX8LYsYD42CypjdqcVCfuN+LrBfo+2t8WiMkdd E+dz0qafaQzEta+FME0WMvEgwBVZAsh+mTZgaxLVq7Na3zeQ//0Gjsv5L5ZIhJc3jE qyZhPjy7kbcyPZ4MN9aBk/dkc8ch7rCLy3qdZzds83sUNFbKXzGo39CZ/r7NN0nbt5 DXBCUZ9nD9b8IOhSGXKZkx/Q4FDh+qI80CCrnM/p0OZQ8ye/LqfyDyts0w4ekCyeQg GCNGqEerEeBXQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Pavankumar Kondeti , John Keeping , Greg Kroah-Hartman , Sasha Levin , balbi@kernel.org, axboe@kernel.dk, jj251510319013@gmail.com, erosca@de.adit-jv.com, andrew_gabbasov@mentor.com, lkp@intel.com, salah.triki@gmail.com, dean@sensoray.com, plr.vincent@gmail.com, wcheng@codeaurora.org, linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 05/56] usb: gadget: f_fs: Use stream_open() for endpoint files Date: Mon, 17 Jan 2022 21:48:17 -0500 Message-Id: <20220118024908.1953673-5-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220118024908.1953673-1-sashal@kernel.org> References: <20220118024908.1953673-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: Pavankumar Kondeti [ Upstream commit c76ef96fc00eb398c8fc836b0eb2f82bcc619dc7 ] Function fs endpoint file operations are synchronized via an interruptible mutex wait. However we see threads that do ep file operations concurrently are getting blocked for the mutex lock in __fdget_pos(). This is an uninterruptible wait and we see hung task warnings and kernel panic if hung_task_panic systcl is enabled if host does not send/receive the data for long time. The reason for threads getting blocked in __fdget_pos() is due to the file position protection introduced by the commit 9c225f2655e3 ("vfs: atomic f_pos accesses as per POSIX"). Since function fs endpoint files does not have the notion of the file position, switch to the stream mode. This will bypass the file position mutex and threads will be blocked in interruptible state for the function fs mutex. It should not affects user space as we are only changing the task state changes the task state from UNINTERRUPTIBLE to INTERRUPTIBLE while waiting for the USB transfers to be finished. However there is a slight change to the O_NONBLOCK behavior. Earlier threads that are using O_NONBLOCK are also getting blocked inside fdget_pos(). Now they reach to function fs and error code is returned. The non blocking behavior is actually honoured now. Reviewed-by: John Keeping Signed-off-by: Pavankumar Kondeti Link: https://lore.kernel.org/r/1636712682-1226-1-git-send-email-quic_pkondeti@quicinc.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/gadget/function/f_fs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c index 6029f9b00b4a0..61795025f11b6 100644 --- a/drivers/usb/gadget/function/f_fs.c +++ b/drivers/usb/gadget/function/f_fs.c @@ -608,7 +608,7 @@ static int ffs_ep0_open(struct inode *inode, struct file *file) file->private_data = ffs; ffs_data_opened(ffs); - return 0; + return stream_open(inode, file); } static int ffs_ep0_release(struct inode *inode, struct file *file) @@ -1072,7 +1072,7 @@ ffs_epfile_open(struct inode *inode, struct file *file) file->private_data = epfile; ffs_data_opened(epfile->ffs); - return 0; + return stream_open(inode, file); } static int ffs_aio_cancel(struct kiocb *kiocb) -- 2.34.1