From: Stephen Hemminger <stephen@networkplumber.org>
To: kumaraparameshwaran rathinavel <kumaraparamesh92@gmail.com>
Cc: Kumara Parameshwaran <kparameshwar@vmware.com>,
"keith.wiles@intel.com" <keith.wiles@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH] net/tap: Bug fix to populate fds in secondary process
Date: Tue, 18 Jan 2022 20:51:12 -0800 [thread overview]
Message-ID: <20220118205112.20506a2a@hermes.local> (raw)
In-Reply-To: <CANxNyatkNyKb+mKAANY+tL+c0zZFaX1TcSsqhPrmMDZfGOsheQ@mail.gmail.com>
On Wed, 19 Jan 2022 10:03:49 +0530
kumaraparameshwaran rathinavel <kumaraparamesh92@gmail.com> wrote:
> > > Why is this necessary? dev->data is already in memory shared between
> > primary
> > > and secondary process.
> >
> > > The question is about the two assignments that happen in secondary proces
> > > that change dev->data->nb_rx_queues and dev->data->nb_tx_queues. These
> > are
> > > shared and should not need to be modified here.
> >
> Sure my bad. Misunderstood the comment. Yes, this should not be done, will
> remove the assignments.
No problem, primary/secondary process support is a bug farm because it
is too easy to have pointer that is from primary process leak into secondary.
I just wanted to make sure there wasn't something wrong in the infrastructure.
next prev parent reply other threads:[~2022-01-19 4:51 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 4:15 [PATCH] net/tap: Bug fix to populate fds in secondary process Kumara Parameshwaran
2022-01-17 18:22 ` Ferruh Yigit
2022-01-18 4:39 ` Kumara Parameshwaran
2022-01-18 9:10 ` Ferruh Yigit
2022-01-18 10:52 ` kumaraparameshwaran rathinavel
2022-01-18 12:14 ` Ferruh Yigit
2022-01-17 18:28 ` Ferruh Yigit
2022-01-17 18:33 ` Thomas Monjalon
2022-01-18 9:47 ` Ferruh Yigit
2022-01-18 11:21 ` kumaraparameshwaran rathinavel
2022-01-18 12:12 ` Ferruh Yigit
2022-01-18 12:31 ` Thomas Monjalon
2022-01-17 22:16 ` Stephen Hemminger
2022-01-18 5:22 ` Kumara Parameshwaran
2022-01-18 16:21 ` Stephen Hemminger
2022-01-19 4:33 ` kumaraparameshwaran rathinavel
2022-01-19 4:51 ` Stephen Hemminger [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-01-21 4:29 Kumara Parameshwaran
2022-01-24 9:47 ` Ferruh Yigit
2022-01-20 13:38 Kumara Parameshwaran
2022-01-20 13:26 Kumara Parameshwaran
2022-01-20 11:12 Kumara Parameshwaran
2022-01-20 15:49 ` Stephen Hemminger
2022-01-24 9:32 ` Ferruh Yigit
2021-11-25 12:25 Kumara Parameshwaran
2021-11-25 12:23 Kumara Parameshwaran
2021-11-25 12:04 Kumara Parameshwaran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220118205112.20506a2a@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
--cc=kparameshwar@vmware.com \
--cc=kumaraparamesh92@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.