From: Jason Gunthorpe <jgg@ziepe.ca>
To: Kees Cook <keescook@chromium.org>
Cc: Jann Horn <jannh@google.com>, Peter Huewe <peterhuewe@gmx.de>,
Jarkko Sakkinen <jarkko@kernel.org>,
linux-integrity@vger.kernel.org,
Stefan Berger <stefanb@linux.ibm.com>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2] tpm: vtpm_proxy: Double-check to avoid buffer overflow
Date: Tue, 18 Jan 2022 19:33:53 -0400 [thread overview]
Message-ID: <20220118233353.GI8034@ziepe.ca> (raw)
In-Reply-To: <202201181255.DB5D38F6AA@keescook>
On Tue, Jan 18, 2022 at 01:20:40PM -0800, Kees Cook wrote:
> I haven't been able to reproduce the specific cause of why GCC decided to
> do the bounds checking, but it's not an unreasonable thing to check for,
> just for robustness.
Well, the commit message should explain this is to silence a compiler
bug and maybe put some colour on what version(s) are actually buggy..
Jason
next prev parent reply other threads:[~2022-01-18 23:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 18:36 [PATCH v2] tpm: vtpm_proxy: Double-check to avoid buffer overflow Kees Cook
2022-01-18 19:32 ` Jann Horn
2022-01-18 19:39 ` Jason Gunthorpe
2022-01-18 21:20 ` Kees Cook
2022-01-18 23:33 ` Jason Gunthorpe [this message]
2022-01-19 0:42 ` Jann Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220118233353.GI8034@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=jannh@google.com \
--cc=jarkko@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=stefanb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.