diff for duplicates of <202201190048.qRDA3uFx-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index a6a83e9..2c37cbb 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,14 +1,6 @@ -CC: kbuild-all(a)lists.01.org -CC: linux-kernel(a)vger.kernel.org -TO: Ohad Sharabi <osharabi@habana.ai> -CC: Oded Gabbay <ogabbay@kernel.org> - tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 99613159ad749543621da8238acf1a122880144e commit: e2558f0f84d85bfe2407b91d57798f133d8ad32a habanalabs: prevent wait if CS in multi-CS list completed -date: 3 weeks ago -:::::: branch date: 5 hours ago -:::::: commit date: 3 weeks ago config: s390-randconfig-m031-20220117 (https://download.01.org/0day-ci/archive/20220119/202201190048.qRDA3uFx-lkp(a)intel.com/config) compiler: s390-linux-gcc (GCC) 11.2.0 @@ -21,22 +13,6 @@ drivers/misc/habanalabs/common/command_submission.c:2457 hl_cs_poll_fences() err vim +/fence +2457 drivers/misc/habanalabs/common/command_submission.c -eff6f4a0e70b7b drivers/misc/habanalabs/command_submission.c Oded Gabbay 2019-02-16 2367 -215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2368 /* -215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2369 * hl_cs_poll_fences - iterate CS fences to check for CS completion -215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2370 * -215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2371 * @mcs_data: multi-CS internal data -e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2372 * @mcs_compl: multi-CS completion structure -215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2373 * -215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2374 * @return 0 on success, otherwise non 0 error code -215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2375 * -215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2376 * The function iterates on all CS sequence in the list and set bit in -215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2377 * completion_bitmap for each completed CS. -e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2378 * While iterating, the function sets the stream map of each fence in the fence -e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2379 * array in the completion QID stream map to be used by CSs to perform -e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2380 * completion to the multi-CS context. -e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2381 * This function shall be called after taking context ref -215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2382 */ e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2383 static int hl_cs_poll_fences(struct multi_cs_data *mcs_data, struct multi_cs_completion *mcs_compl) 215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2384 { 215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2385 struct hl_fence **fence_ptr = mcs_data->fence_arr; @@ -85,6 +61,9 @@ e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2428 * wake up the completion. e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2429 */ e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 @2430 if (fence) + ^^^^^ + + e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2431 mcs_compl->stream_master_qid_map |= fence->stream_master_qid_map; e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2432 215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2433 /* @@ -112,6 +91,9 @@ ea6eb91c09cd4f drivers/misc/habanalabs/common/command_submission.c Dani Liberman ea6eb91c09cd4f drivers/misc/habanalabs/common/command_submission.c Dani Liberman 2021-10-03 2455 * user waits for mcs. ea6eb91c09cd4f drivers/misc/habanalabs/common/command_submission.c Dani Liberman 2021-10-03 2456 */ b2faac3887df87 drivers/misc/habanalabs/common/command_submission.c Dani Liberman 2021-10-12 @2457 if (!fence->mcs_handling_done) + ^^^^^^^ +Unchecked derereference + b2faac3887df87 drivers/misc/habanalabs/common/command_submission.c Dani Liberman 2021-10-12 2458 break; 215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2459 215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2460 mcs_data->completion_bitmap |= BIT(i); @@ -150,13 +132,6 @@ b2faac3887df87 drivers/misc/habanalabs/common/command_submission.c Dani Liberman 215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2493 215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2494 return rc; 215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2495 } -215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2496 - -:::::: The code at line 2457 was first introduced by commit -:::::: b2faac3887df87a6e4bc3356280ea35dc7459c0b habanalabs: refactor fence handling in hl_cs_poll_fences - -:::::: TO: Dani Liberman <dliberman@habana.ai> -:::::: CC: Oded Gabbay <ogabbay@kernel.org> --- 0-DAY CI Kernel Test Service, Intel Corporation diff --git a/a/content_digest b/N1/content_digest index 8233ac2..9251a88 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,20 +1,12 @@ - "From\0kernel test robot <lkp@intel.com>\0" + "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0drivers/misc/habanalabs/common/command_submission.c:2457 hl_cs_poll_fences() error: we previously assumed 'fence' could be null (see line 2430)\0" - "Date\0Wed, 19 Jan 2022 01:09:18 +0800\0" - "To\0kbuild@lists.01.org\0" + "Date\0Wed, 19 Jan 2022 08:39:58 +0300\0" + "To\0kbuild-all@lists.01.org\0" "\01:1\0" "b\0" - "CC: kbuild-all(a)lists.01.org\n" - "CC: linux-kernel(a)vger.kernel.org\n" - "TO: Ohad Sharabi <osharabi@habana.ai>\n" - "CC: Oded Gabbay <ogabbay@kernel.org>\n" - "\n" "tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master\n" "head: 99613159ad749543621da8238acf1a122880144e\n" "commit: e2558f0f84d85bfe2407b91d57798f133d8ad32a habanalabs: prevent wait if CS in multi-CS list completed\n" - "date: 3 weeks ago\n" - ":::::: branch date: 5 hours ago\n" - ":::::: commit date: 3 weeks ago\n" "config: s390-randconfig-m031-20220117 (https://download.01.org/0day-ci/archive/20220119/202201190048.qRDA3uFx-lkp(a)intel.com/config)\n" "compiler: s390-linux-gcc (GCC) 11.2.0\n" "\n" @@ -27,22 +19,6 @@ "\n" "vim +/fence +2457 drivers/misc/habanalabs/common/command_submission.c\n" "\n" - "eff6f4a0e70b7b drivers/misc/habanalabs/command_submission.c Oded Gabbay 2019-02-16 2367 \n" - "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2368 /*\n" - "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2369 * hl_cs_poll_fences - iterate CS fences to check for CS completion\n" - "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2370 *\n" - "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2371 * @mcs_data: multi-CS internal data\n" - "e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2372 * @mcs_compl: multi-CS completion structure\n" - "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2373 *\n" - "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2374 * @return 0 on success, otherwise non 0 error code\n" - "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2375 *\n" - "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2376 * The function iterates on all CS sequence in the list and set bit in\n" - "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2377 * completion_bitmap for each completed CS.\n" - "e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2378 * While iterating, the function sets the stream map of each fence in the fence\n" - "e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2379 * array in the completion QID stream map to be used by CSs to perform\n" - "e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2380 * completion to the multi-CS context.\n" - "e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2381 * This function shall be called after taking context ref\n" - "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2382 */\n" "e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2383 static int hl_cs_poll_fences(struct multi_cs_data *mcs_data, struct multi_cs_completion *mcs_compl)\n" "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2384 {\n" "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2385 \tstruct hl_fence **fence_ptr = mcs_data->fence_arr;\n" @@ -91,6 +67,9 @@ "e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2428 \t\t * wake up the completion.\n" "e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2429 \t\t */\n" "e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 @2430 \t\tif (fence)\n" + " ^^^^^\n" + "\n" + "\n" "e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2431 \t\t\tmcs_compl->stream_master_qid_map |= fence->stream_master_qid_map;\n" "e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2432 \n" "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2433 \t\t/*\n" @@ -118,6 +97,9 @@ "ea6eb91c09cd4f drivers/misc/habanalabs/common/command_submission.c Dani Liberman 2021-10-03 2455 \t\t\t * user waits for mcs.\n" "ea6eb91c09cd4f drivers/misc/habanalabs/common/command_submission.c Dani Liberman 2021-10-03 2456 \t\t\t */\n" "b2faac3887df87 drivers/misc/habanalabs/common/command_submission.c Dani Liberman 2021-10-12 @2457 \t\t\tif (!fence->mcs_handling_done)\n" + " ^^^^^^^\n" + "Unchecked derereference\n" + "\n" "b2faac3887df87 drivers/misc/habanalabs/common/command_submission.c Dani Liberman 2021-10-12 2458 \t\t\t\tbreak;\n" "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2459 \n" "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2460 \t\t\tmcs_data->completion_bitmap |= BIT(i);\n" @@ -156,16 +138,9 @@ "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2493 \n" "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2494 \treturn rc;\n" "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2495 }\n" - "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2496 \n" - "\n" - ":::::: The code at line 2457 was first introduced by commit\n" - ":::::: b2faac3887df87a6e4bc3356280ea35dc7459c0b habanalabs: refactor fence handling in hl_cs_poll_fences\n" - "\n" - ":::::: TO: Dani Liberman <dliberman@habana.ai>\n" - ":::::: CC: Oded Gabbay <ogabbay@kernel.org>\n" "\n" "---\n" "0-DAY CI Kernel Test Service, Intel Corporation\n" https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org -b782334adc695ab15194e734104cd3cb692f21e113aa1e7d7f0a3a563530e680 +70684676f83fa32bd032fe99a07452c9d300dcf030205a6b4c432aa71311fe81
diff --git a/a/1.txt b/N2/1.txt index a6a83e9..1afc908 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,15 +1,7 @@ -CC: kbuild-all(a)lists.01.org -CC: linux-kernel(a)vger.kernel.org -TO: Ohad Sharabi <osharabi@habana.ai> -CC: Oded Gabbay <ogabbay@kernel.org> - tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 99613159ad749543621da8238acf1a122880144e commit: e2558f0f84d85bfe2407b91d57798f133d8ad32a habanalabs: prevent wait if CS in multi-CS list completed -date: 3 weeks ago -:::::: branch date: 5 hours ago -:::::: commit date: 3 weeks ago -config: s390-randconfig-m031-20220117 (https://download.01.org/0day-ci/archive/20220119/202201190048.qRDA3uFx-lkp(a)intel.com/config) +config: s390-randconfig-m031-20220117 (https://download.01.org/0day-ci/archive/20220119/202201190048.qRDA3uFx-lkp@intel.com/config) compiler: s390-linux-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate @@ -21,22 +13,6 @@ drivers/misc/habanalabs/common/command_submission.c:2457 hl_cs_poll_fences() err vim +/fence +2457 drivers/misc/habanalabs/common/command_submission.c -eff6f4a0e70b7b drivers/misc/habanalabs/command_submission.c Oded Gabbay 2019-02-16 2367 -215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2368 /* -215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2369 * hl_cs_poll_fences - iterate CS fences to check for CS completion -215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2370 * -215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2371 * @mcs_data: multi-CS internal data -e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2372 * @mcs_compl: multi-CS completion structure -215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2373 * -215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2374 * @return 0 on success, otherwise non 0 error code -215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2375 * -215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2376 * The function iterates on all CS sequence in the list and set bit in -215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2377 * completion_bitmap for each completed CS. -e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2378 * While iterating, the function sets the stream map of each fence in the fence -e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2379 * array in the completion QID stream map to be used by CSs to perform -e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2380 * completion to the multi-CS context. -e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2381 * This function shall be called after taking context ref -215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2382 */ e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2383 static int hl_cs_poll_fences(struct multi_cs_data *mcs_data, struct multi_cs_completion *mcs_compl) 215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2384 { 215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2385 struct hl_fence **fence_ptr = mcs_data->fence_arr; @@ -78,13 +54,16 @@ e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2421 * 1. for each fence set it's QID map in the multi-CS completion QID map. This way e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2422 * any CS can, potentially, complete the multi CS for the specific QID (note e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2423 * that once completion is initialized, calling complete* and then wait on the -e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2424 * completion will cause it to return@once) +e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2424 * completion will cause it to return at once) e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2425 * 2. only after allowing multi-CS completion for the specific QID we check whether e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2426 * the specific CS already completed (and thus the wait for completion part will e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2427 * be skipped). if the CS not completed it is guaranteed that completing CS will e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2428 * wake up the completion. e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2429 */ e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 @2430 if (fence) + ^^^^^ + + e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2431 mcs_compl->stream_master_qid_map |= fence->stream_master_qid_map; e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2432 215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2433 /* @@ -112,6 +91,9 @@ ea6eb91c09cd4f drivers/misc/habanalabs/common/command_submission.c Dani Liberman ea6eb91c09cd4f drivers/misc/habanalabs/common/command_submission.c Dani Liberman 2021-10-03 2455 * user waits for mcs. ea6eb91c09cd4f drivers/misc/habanalabs/common/command_submission.c Dani Liberman 2021-10-03 2456 */ b2faac3887df87 drivers/misc/habanalabs/common/command_submission.c Dani Liberman 2021-10-12 @2457 if (!fence->mcs_handling_done) + ^^^^^^^ +Unchecked derereference + b2faac3887df87 drivers/misc/habanalabs/common/command_submission.c Dani Liberman 2021-10-12 2458 break; 215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2459 215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2460 mcs_data->completion_bitmap |= BIT(i); @@ -150,14 +132,7 @@ b2faac3887df87 drivers/misc/habanalabs/common/command_submission.c Dani Liberman 215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2493 215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2494 return rc; 215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2495 } -215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2496 - -:::::: The code at line 2457 was first introduced by commit -:::::: b2faac3887df87a6e4bc3356280ea35dc7459c0b habanalabs: refactor fence handling in hl_cs_poll_fences - -:::::: TO: Dani Liberman <dliberman@habana.ai> -:::::: CC: Oded Gabbay <ogabbay@kernel.org> --- 0-DAY CI Kernel Test Service, Intel Corporation -https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org +https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org diff --git a/a/content_digest b/N2/content_digest index 8233ac2..4b525f5 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,21 +1,18 @@ - "From\0kernel test robot <lkp@intel.com>\0" + "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0drivers/misc/habanalabs/common/command_submission.c:2457 hl_cs_poll_fences() error: we previously assumed 'fence' could be null (see line 2430)\0" - "Date\0Wed, 19 Jan 2022 01:09:18 +0800\0" - "To\0kbuild@lists.01.org\0" - "\01:1\0" + "Date\0Wed, 19 Jan 2022 08:39:58 +0300\0" + "To\0kbuild@lists.01.org" + " Ohad Sharabi <osharabi@habana.ai>\0" + "Cc\0lkp@intel.com" + kbuild-all@lists.01.org + linux-kernel@vger.kernel.org + " Oded Gabbay <ogabbay@kernel.org>\0" + "\00:1\0" "b\0" - "CC: kbuild-all(a)lists.01.org\n" - "CC: linux-kernel(a)vger.kernel.org\n" - "TO: Ohad Sharabi <osharabi@habana.ai>\n" - "CC: Oded Gabbay <ogabbay@kernel.org>\n" - "\n" "tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master\n" "head: 99613159ad749543621da8238acf1a122880144e\n" "commit: e2558f0f84d85bfe2407b91d57798f133d8ad32a habanalabs: prevent wait if CS in multi-CS list completed\n" - "date: 3 weeks ago\n" - ":::::: branch date: 5 hours ago\n" - ":::::: commit date: 3 weeks ago\n" - "config: s390-randconfig-m031-20220117 (https://download.01.org/0day-ci/archive/20220119/202201190048.qRDA3uFx-lkp(a)intel.com/config)\n" + "config: s390-randconfig-m031-20220117 (https://download.01.org/0day-ci/archive/20220119/202201190048.qRDA3uFx-lkp@intel.com/config)\n" "compiler: s390-linux-gcc (GCC) 11.2.0\n" "\n" "If you fix the issue, kindly add following tag as appropriate\n" @@ -27,22 +24,6 @@ "\n" "vim +/fence +2457 drivers/misc/habanalabs/common/command_submission.c\n" "\n" - "eff6f4a0e70b7b drivers/misc/habanalabs/command_submission.c Oded Gabbay 2019-02-16 2367 \n" - "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2368 /*\n" - "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2369 * hl_cs_poll_fences - iterate CS fences to check for CS completion\n" - "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2370 *\n" - "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2371 * @mcs_data: multi-CS internal data\n" - "e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2372 * @mcs_compl: multi-CS completion structure\n" - "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2373 *\n" - "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2374 * @return 0 on success, otherwise non 0 error code\n" - "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2375 *\n" - "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2376 * The function iterates on all CS sequence in the list and set bit in\n" - "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2377 * completion_bitmap for each completed CS.\n" - "e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2378 * While iterating, the function sets the stream map of each fence in the fence\n" - "e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2379 * array in the completion QID stream map to be used by CSs to perform\n" - "e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2380 * completion to the multi-CS context.\n" - "e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2381 * This function shall be called after taking context ref\n" - "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2382 */\n" "e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2383 static int hl_cs_poll_fences(struct multi_cs_data *mcs_data, struct multi_cs_completion *mcs_compl)\n" "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2384 {\n" "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2385 \tstruct hl_fence **fence_ptr = mcs_data->fence_arr;\n" @@ -84,13 +65,16 @@ "e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2421 \t\t * 1. for each fence set it's QID map in the multi-CS completion QID map. This way\n" "e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2422 \t\t * any CS can, potentially, complete the multi CS for the specific QID (note\n" "e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2423 \t\t * that once completion is initialized, calling complete* and then wait on the\n" - "e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2424 \t\t * completion will cause it to return@once)\n" + "e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2424 \t\t * completion will cause it to return at once)\n" "e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2425 \t\t * 2. only after allowing multi-CS completion for the specific QID we check whether\n" "e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2426 \t\t * the specific CS already completed (and thus the wait for completion part will\n" "e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2427 \t\t * be skipped). if the CS not completed it is guaranteed that completing CS will\n" "e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2428 \t\t * wake up the completion.\n" "e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2429 \t\t */\n" "e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 @2430 \t\tif (fence)\n" + " ^^^^^\n" + "\n" + "\n" "e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2431 \t\t\tmcs_compl->stream_master_qid_map |= fence->stream_master_qid_map;\n" "e2558f0f84d85b drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-12-07 2432 \n" "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2433 \t\t/*\n" @@ -118,6 +102,9 @@ "ea6eb91c09cd4f drivers/misc/habanalabs/common/command_submission.c Dani Liberman 2021-10-03 2455 \t\t\t * user waits for mcs.\n" "ea6eb91c09cd4f drivers/misc/habanalabs/common/command_submission.c Dani Liberman 2021-10-03 2456 \t\t\t */\n" "b2faac3887df87 drivers/misc/habanalabs/common/command_submission.c Dani Liberman 2021-10-12 @2457 \t\t\tif (!fence->mcs_handling_done)\n" + " ^^^^^^^\n" + "Unchecked derereference\n" + "\n" "b2faac3887df87 drivers/misc/habanalabs/common/command_submission.c Dani Liberman 2021-10-12 2458 \t\t\t\tbreak;\n" "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2459 \n" "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2460 \t\t\tmcs_data->completion_bitmap |= BIT(i);\n" @@ -156,16 +143,9 @@ "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2493 \n" "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2494 \treturn rc;\n" "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2495 }\n" - "215f0c1775d550 drivers/misc/habanalabs/common/command_submission.c Ohad Sharabi 2021-06-14 2496 \n" - "\n" - ":::::: The code at line 2457 was first introduced by commit\n" - ":::::: b2faac3887df87a6e4bc3356280ea35dc7459c0b habanalabs: refactor fence handling in hl_cs_poll_fences\n" - "\n" - ":::::: TO: Dani Liberman <dliberman@habana.ai>\n" - ":::::: CC: Oded Gabbay <ogabbay@kernel.org>\n" "\n" "---\n" "0-DAY CI Kernel Test Service, Intel Corporation\n" - https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org + https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org -b782334adc695ab15194e734104cd3cb692f21e113aa1e7d7f0a3a563530e680 +5fc59f92ed9dc979d3494ed3f3b1a2cdbb4c2677d373cf2c7eef132c59822f6d
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.