From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5050684305920209844==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: fs/notify/fanotify/fanotify_user.c:154:24: warning: variable 'info' set but not used Date: Wed, 19 Jan 2022 04:34:01 +0800 Message-ID: <202201190416.xidpRFf8-lkp@intel.com> List-Id: --===============5050684305920209844== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = master head: 99613159ad749543621da8238acf1a122880144e commit: 7326e382c21e9c23c89c88369afdc90b82a14da8 fanotify: report old and/o= r new parent+name in FAN_RENAME event date: 5 weeks ago config: x86_64-randconfig-m001-20220117 (https://download.01.org/0day-ci/ar= chive/20220119/202201190416.xidpRFf8-lkp(a)intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=3D1 build): # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.gi= t/commit/?id=3D7326e382c21e9c23c89c88369afdc90b82a14da8 git remote add linus https://git.kernel.org/pub/scm/linux/kernel/gi= t/torvalds/linux.git git fetch --no-tags linus master git checkout 7326e382c21e9c23c89c88369afdc90b82a14da8 # save the config file to linux build tree mkdir build_dir make W=3D1 O=3Dbuild_dir ARCH=3Dx86_64 SHELL=3D/bin/bash fs/notify/= mm// If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): fs/notify/fanotify/fanotify_user.c: In function 'fanotify_event_len': >> fs/notify/fanotify/fanotify_user.c:154:24: warning: variable 'info' set = but not used [-Wunused-but-set-variable] 154 | struct fanotify_info *info; | ^~~~ vim +/info +154 fs/notify/fanotify/fanotify_user.c 7326e382c21e9c Amir Goldstein 2021-11-29 149 = b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 150 static size_t fanot= ify_event_len(unsigned int info_mode, 929943b38daf81 Amir Goldstein 2020-07-16 151 struct fanotif= y_event *event) 5e469c830fdb5a Amir Goldstein 2019-01-10 152 { b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 153 size_t event_len = =3D FAN_EVENT_METADATA_LEN; b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 @154 struct fanotify_in= fo *info; b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 155 int fh_len; 929943b38daf81 Amir Goldstein 2020-07-16 156 int dot_len =3D 0; f454fa610a69b9 Amir Goldstein 2020-07-16 157 = b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 158 if (!info_mode) b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 159 return event_len; b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 160 = 130a3c742107ac Gabriel Krisman Bertazi 2021-10-25 161 if (fanotify_is_er= ror_event(event->mask)) 130a3c742107ac Gabriel Krisman Bertazi 2021-10-25 162 event_len +=3D FA= NOTIFY_ERROR_INFO_LEN; 130a3c742107ac Gabriel Krisman Bertazi 2021-10-25 163 = b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 164 info =3D fanotify_= event_info(event); b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 165 = 7326e382c21e9c Amir Goldstein 2021-11-29 166 if (fanotify_event= _has_any_dir_fh(event)) { 7326e382c21e9c Amir Goldstein 2021-11-29 167 event_len +=3D fa= notify_dir_name_info_len(event); d3424c9bac893b Matthew Bobrowski 2021-08-08 168 } else if ((info_m= ode & FAN_REPORT_NAME) && d3424c9bac893b Matthew Bobrowski 2021-08-08 169 (event->mask &= FAN_ONDIR)) { 929943b38daf81 Amir Goldstein 2020-07-16 170 /* 929943b38daf81 Amir Goldstein 2020-07-16 171 * With group fla= g FAN_REPORT_NAME, if name was not recorded in 929943b38daf81 Amir Goldstein 2020-07-16 172 * event on a dir= ectory, we will report the name ".". 929943b38daf81 Amir Goldstein 2020-07-16 173 */ 929943b38daf81 Amir Goldstein 2020-07-16 174 dot_len =3D 1; 929943b38daf81 Amir Goldstein 2020-07-16 175 } afc894c784c84c Jan Kara 2020-03-24 176 = af579beb666aef Matthew Bobrowski 2021-08-08 177 if (info_mode & FA= N_REPORT_PIDFD) b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 178 event_len +=3D FA= NOTIFY_PIDFD_INFO_HDR_LEN; af579beb666aef Matthew Bobrowski 2021-08-08 179 = 4bd5a5c8e6e5cd Gabriel Krisman Bertazi 2021-10-25 180 if (fanotify_event= _has_object_fh(event)) { 4bd5a5c8e6e5cd Gabriel Krisman Bertazi 2021-10-25 181 fh_len =3D fanoti= fy_event_object_fh_len(event); b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 182 event_len +=3D fa= notify_fid_info_len(fh_len, dot_len); 4bd5a5c8e6e5cd Gabriel Krisman Bertazi 2021-10-25 183 } 5e469c830fdb5a Amir Goldstein 2019-01-10 184 = b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 185 return event_len; 5e469c830fdb5a Amir Goldstein 2019-01-10 186 } 5e469c830fdb5a Amir Goldstein 2019-01-10 187 = :::::: The code at line 154 was first introduced by commit :::::: b9928e80dda84b349ba8de01780b9bef2fc36ffa fanotify: Fold event size c= alculation to its own function :::::: TO: Gabriel Krisman Bertazi :::::: CC: Jan Kara --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============5050684305920209844==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5536FC433EF for ; Tue, 18 Jan 2022 20:34:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349264AbiARUeP (ORCPT ); Tue, 18 Jan 2022 15:34:15 -0500 Received: from mga17.intel.com ([192.55.52.151]:13057 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349277AbiARUeM (ORCPT ); Tue, 18 Jan 2022 15:34:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642538052; x=1674074052; h=date:from:to:cc:subject:message-id:mime-version; bh=qnx4NIVe5acE+JiEz+X7YPRiFYVpjWSi9IFEffMbRpo=; b=JOBn4MBT/6KbeiJo2XMf/8bZdNgImyEsUtfQriYJzyZPlQoCRZgbpf03 e06ZvGHFlzXbCxEt5YdIeo5W1UPy2FKc3BF+NkbNadiRXNttuOHGMI5DG N23J9i51JQGJaX69Q1El9bYmKL+LbxG7AUips2ONAMpF960bRE0OH/b3K cJLJlgiNcZgBmndb38Gvft9qnV9wBUfP2CSi4bqaEUM27IrhV3bMtpHc8 87k9vbYuUFql2o//0TWNxPJeGA7ksvMHVmHNiBZWuw2GgHru/jE5JDKrV xzBonuiHsk859egrUuUwzPlVCHKcij+MLwhJlPffWAqKNwvTm5fykMfr6 g==; X-IronPort-AV: E=McAfee;i="6200,9189,10231"; a="225585024" X-IronPort-AV: E=Sophos;i="5.88,298,1635231600"; d="scan'208";a="225585024" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2022 12:34:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,298,1635231600"; d="scan'208";a="517907000" Received: from lkp-server01.sh.intel.com (HELO 276f1b88eecb) ([10.239.97.150]) by orsmga007.jf.intel.com with ESMTP; 18 Jan 2022 12:34:07 -0800 Received: from kbuild by 276f1b88eecb with local (Exim 4.92) (envelope-from ) id 1n9vB8-000Cvw-OJ; Tue, 18 Jan 2022 20:34:06 +0000 Date: Wed, 19 Jan 2022 04:34:01 +0800 From: kernel test robot To: Amir Goldstein Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Jan Kara Subject: fs/notify/fanotify/fanotify_user.c:154:24: warning: variable 'info' set but not used Message-ID: <202201190416.xidpRFf8-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 99613159ad749543621da8238acf1a122880144e commit: 7326e382c21e9c23c89c88369afdc90b82a14da8 fanotify: report old and/or new parent+name in FAN_RENAME event date: 5 weeks ago config: x86_64-randconfig-m001-20220117 (https://download.01.org/0day-ci/archive/20220119/202201190416.xidpRFf8-lkp@intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7326e382c21e9c23c89c88369afdc90b82a14da8 git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout 7326e382c21e9c23c89c88369afdc90b82a14da8 # save the config file to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/notify/ mm// If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): fs/notify/fanotify/fanotify_user.c: In function 'fanotify_event_len': >> fs/notify/fanotify/fanotify_user.c:154:24: warning: variable 'info' set but not used [-Wunused-but-set-variable] 154 | struct fanotify_info *info; | ^~~~ vim +/info +154 fs/notify/fanotify/fanotify_user.c 7326e382c21e9c Amir Goldstein 2021-11-29 149 b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 150 static size_t fanotify_event_len(unsigned int info_mode, 929943b38daf81 Amir Goldstein 2020-07-16 151 struct fanotify_event *event) 5e469c830fdb5a Amir Goldstein 2019-01-10 152 { b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 153 size_t event_len = FAN_EVENT_METADATA_LEN; b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 @154 struct fanotify_info *info; b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 155 int fh_len; 929943b38daf81 Amir Goldstein 2020-07-16 156 int dot_len = 0; f454fa610a69b9 Amir Goldstein 2020-07-16 157 b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 158 if (!info_mode) b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 159 return event_len; b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 160 130a3c742107ac Gabriel Krisman Bertazi 2021-10-25 161 if (fanotify_is_error_event(event->mask)) 130a3c742107ac Gabriel Krisman Bertazi 2021-10-25 162 event_len += FANOTIFY_ERROR_INFO_LEN; 130a3c742107ac Gabriel Krisman Bertazi 2021-10-25 163 b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 164 info = fanotify_event_info(event); b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 165 7326e382c21e9c Amir Goldstein 2021-11-29 166 if (fanotify_event_has_any_dir_fh(event)) { 7326e382c21e9c Amir Goldstein 2021-11-29 167 event_len += fanotify_dir_name_info_len(event); d3424c9bac893b Matthew Bobrowski 2021-08-08 168 } else if ((info_mode & FAN_REPORT_NAME) && d3424c9bac893b Matthew Bobrowski 2021-08-08 169 (event->mask & FAN_ONDIR)) { 929943b38daf81 Amir Goldstein 2020-07-16 170 /* 929943b38daf81 Amir Goldstein 2020-07-16 171 * With group flag FAN_REPORT_NAME, if name was not recorded in 929943b38daf81 Amir Goldstein 2020-07-16 172 * event on a directory, we will report the name ".". 929943b38daf81 Amir Goldstein 2020-07-16 173 */ 929943b38daf81 Amir Goldstein 2020-07-16 174 dot_len = 1; 929943b38daf81 Amir Goldstein 2020-07-16 175 } afc894c784c84c Jan Kara 2020-03-24 176 af579beb666aef Matthew Bobrowski 2021-08-08 177 if (info_mode & FAN_REPORT_PIDFD) b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 178 event_len += FANOTIFY_PIDFD_INFO_HDR_LEN; af579beb666aef Matthew Bobrowski 2021-08-08 179 4bd5a5c8e6e5cd Gabriel Krisman Bertazi 2021-10-25 180 if (fanotify_event_has_object_fh(event)) { 4bd5a5c8e6e5cd Gabriel Krisman Bertazi 2021-10-25 181 fh_len = fanotify_event_object_fh_len(event); b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 182 event_len += fanotify_fid_info_len(fh_len, dot_len); 4bd5a5c8e6e5cd Gabriel Krisman Bertazi 2021-10-25 183 } 5e469c830fdb5a Amir Goldstein 2019-01-10 184 b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 185 return event_len; 5e469c830fdb5a Amir Goldstein 2019-01-10 186 } 5e469c830fdb5a Amir Goldstein 2019-01-10 187 :::::: The code at line 154 was first introduced by commit :::::: b9928e80dda84b349ba8de01780b9bef2fc36ffa fanotify: Fold event size calculation to its own function :::::: TO: Gabriel Krisman Bertazi :::::: CC: Jan Kara --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org