From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: Parav Pandit <parav@nvidia.com>,
Max Gurtovoy <mgurtovoy@nvidia.com>,
"virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
Shahaf Shuler <shahafs@nvidia.com>, Oren Duer <oren@nvidia.com>,
"stefanha@redhat.com" <stefanha@redhat.com>
Subject: Re: [PATCH 4/5] virtio-net: add support for VIRTIO_F_ADMIN_VQ
Date: Wed, 19 Jan 2022 04:26:42 -0500 [thread overview]
Message-ID: <20220119042012-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CACGkMEucTZSOq=yZ6-DjksW_Z_pg9vcA+pM6+iWWiGdpmM8u0Q@mail.gmail.com>
On Wed, Jan 19, 2022 at 12:16:47PM +0800, Jason Wang wrote:
> > We also need
> > - something like injecting cvq commands to control rx mode from the admin device
> > - page fault / dirty page handling
> >
> > these two seem to call for a vq.
>
> Right, but vq is not necessarily for PF if we had PASID. And with
> PASID we don't even need a dedicated new cvq.
I don't think it's a good idea to mix transactions from
multiple PASIDs on the same vq.
Attaching a PASID to a queue seems more reasonable.
cvq is under guest control, so yes I think a separate
vq is preferable.
What is true is that with subfunctions you would have
PASID per subfunction and then one subfunction for control.
I think a sketch of how things will work with scalable iov can't hurt as
part of this proposal. And, I'm not sure we should have so much
flexibility: if there's an interface that works for SRIOV and SIOV then
that seems preferable than having distinct transports for SRIOV and
SIOV.
--
MST
next prev parent reply other threads:[~2022-01-19 9:26 UTC|newest]
Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 14:50 [PATCH v1 0/5] VIRTIO: Provision maximum MSI-X vectors for a VF Max Gurtovoy
2022-01-13 14:50 ` [PATCH 1/5] Add virtio Admin Virtqueue specification Max Gurtovoy
2022-01-13 17:53 ` Michael S. Tsirkin
2022-01-17 9:56 ` Max Gurtovoy
2022-01-17 21:30 ` Michael S. Tsirkin
2022-01-18 3:22 ` Parav Pandit
2022-01-18 6:17 ` Michael S. Tsirkin
2022-01-18 7:57 ` Parav Pandit
2022-01-18 8:05 ` Michael S. Tsirkin
2022-01-18 8:23 ` Parav Pandit
2022-01-18 10:26 ` Michael S. Tsirkin
2022-01-18 10:30 ` Parav Pandit
2022-01-18 10:41 ` Michael S. Tsirkin
2022-01-19 3:04 ` Jason Wang
2022-01-19 8:11 ` Michael S. Tsirkin
2022-01-25 3:35 ` Jason Wang
2022-01-17 14:12 ` Parav Pandit
2022-01-17 22:03 ` Michael S. Tsirkin
2022-01-18 3:36 ` Parav Pandit
2022-01-18 7:07 ` Michael S. Tsirkin
2022-01-18 7:14 ` Parav Pandit
2022-01-18 7:20 ` Michael S. Tsirkin
2022-01-19 11:33 ` Max Gurtovoy
2022-01-19 12:21 ` Parav Pandit
2022-01-19 14:47 ` Max Gurtovoy
2022-01-19 15:38 ` Michael S. Tsirkin
2022-01-19 15:47 ` Max Gurtovoy
2022-01-13 14:51 ` [PATCH 2/5] Introduce VIRTIO_F_ADMIN_VQ_INDIRECT_DESC/VIRTIO_F_ADMIN_VQ_IN_ORDER Max Gurtovoy
2022-01-13 15:33 ` Michael S. Tsirkin
2022-01-13 17:07 ` Max Gurtovoy
2022-01-13 17:25 ` Michael S. Tsirkin
2022-01-17 13:59 ` Parav Pandit
2022-01-17 22:14 ` Michael S. Tsirkin
2022-01-18 4:44 ` Parav Pandit
2022-01-18 6:23 ` Michael S. Tsirkin
2022-01-18 6:32 ` Parav Pandit
2022-01-18 6:54 ` Michael S. Tsirkin
2022-01-18 7:07 ` Parav Pandit
2022-01-18 7:12 ` Michael S. Tsirkin
2022-01-18 7:30 ` Parav Pandit
2022-01-18 7:40 ` Michael S. Tsirkin
2022-01-19 4:21 ` Jason Wang
2022-01-19 9:30 ` Michael S. Tsirkin
2022-01-25 3:39 ` Jason Wang
2022-01-18 10:38 ` Michael S. Tsirkin
2022-01-18 10:50 ` Parav Pandit
2022-01-18 15:09 ` Michael S. Tsirkin
2022-01-18 17:17 ` Parav Pandit
2022-01-19 7:20 ` Michael S. Tsirkin
2022-01-19 8:15 ` [virtio-dev] " Parav Pandit
2022-01-19 8:21 ` Michael S. Tsirkin
2022-01-19 10:10 ` Parav Pandit
2022-01-19 16:40 ` Michael S. Tsirkin
2022-01-19 17:07 ` Parav Pandit
2022-01-18 7:13 ` Michael S. Tsirkin
2022-01-18 7:21 ` Parav Pandit
2022-01-18 7:37 ` Michael S. Tsirkin
2022-01-19 4:03 ` Jason Wang
2022-01-19 4:48 ` Parav Pandit
2022-01-19 20:25 ` Parav Pandit
2022-01-25 3:45 ` Jason Wang
2022-01-25 4:07 ` Parav Pandit
2022-01-25 3:29 ` Jason Wang
2022-01-25 3:52 ` Parav Pandit
2022-01-25 10:59 ` Max Gurtovoy
2022-01-25 12:09 ` Michael S. Tsirkin
2022-01-26 13:29 ` Parav Pandit
2022-01-26 14:11 ` Michael S. Tsirkin
2022-01-27 3:49 ` Parav Pandit
2022-01-27 13:05 ` Michael S. Tsirkin
2022-01-27 13:25 ` [virtio-dev] " Parav Pandit
2022-01-28 4:35 ` Jason Wang
2022-01-26 7:03 ` Jason Wang
2022-01-26 9:27 ` Max Gurtovoy
2022-01-26 9:34 ` Jason Wang
2022-01-26 9:45 ` Max Gurtovoy
2022-01-27 3:46 ` Jason Wang
2022-01-26 5:04 ` Jason Wang
2022-01-26 5:26 ` Parav Pandit
2022-01-26 5:45 ` Jason Wang
2022-01-26 5:58 ` Parav Pandit
2022-01-26 6:06 ` Jason Wang
2022-01-26 6:24 ` Parav Pandit
2022-01-26 6:54 ` Jason Wang
2022-01-26 8:09 ` Parav Pandit
2022-01-26 9:07 ` Jason Wang
2022-01-26 9:47 ` Parav Pandit
2022-01-13 14:51 ` [PATCH 3/5] virtio-blk: add support for VIRTIO_F_ADMIN_VQ Max Gurtovoy
2022-01-13 18:24 ` Michael S. Tsirkin
2022-01-13 14:51 ` [PATCH 4/5] virtio-net: " Max Gurtovoy
2022-01-13 17:56 ` Michael S. Tsirkin
2022-01-16 9:47 ` Max Gurtovoy
2022-01-16 16:45 ` Michael S. Tsirkin
2022-01-17 14:07 ` Parav Pandit
2022-01-17 22:22 ` Michael S. Tsirkin
2022-01-18 2:18 ` Jason Wang
2022-01-18 5:25 ` Michael S. Tsirkin
2022-01-19 4:16 ` Jason Wang
2022-01-19 9:26 ` Michael S. Tsirkin [this message]
2022-01-25 3:53 ` Jason Wang
2022-01-25 7:19 ` Michael S. Tsirkin
2022-01-26 5:49 ` Jason Wang
2022-01-26 7:02 ` Michael S. Tsirkin
2022-01-26 7:10 ` Jason Wang
2022-01-13 14:51 ` [PATCH 5/5] Add support for dynamic MSI-X vector mgmt for VFs Max Gurtovoy
2022-01-13 18:20 ` Michael S. Tsirkin
2022-01-18 10:38 ` Michael S. Tsirkin
2022-01-13 18:32 ` [PATCH v1 0/5] VIRTIO: Provision maximum MSI-X vectors for a VF Michael S. Tsirkin
2022-01-17 10:00 ` Shahaf Shuler
2022-01-17 21:41 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220119042012-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=cohuck@redhat.com \
--cc=jasowang@redhat.com \
--cc=mgurtovoy@nvidia.com \
--cc=oren@nvidia.com \
--cc=parav@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=stefanha@redhat.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.