From: Rudi Heitbaum <rudi@heitbaum.com>
To: Vyacheslav Bocharov <adeep@lexina.in>
Cc: marcel@holtmann.org, johan.hedberg@gmail.com,
luiz.dentz@gmail.com, linux-bluetooth@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] Bluetooth: btrtl: Add support for RTL8822C hci_ver 0x08
Date: Wed, 19 Jan 2022 09:01:40 +0000 [thread overview]
Message-ID: <20220119090140.GA24@4f18b3450899> (raw)
In-Reply-To: <20211027091416.1577668-2-adeep@lexina.in>
On Wed, Oct 27, 2021 at 12:14:15PM +0300, Vyacheslav Bocharov wrote:
> Add detection of RTL8822CS controller with hci_ver = 0x08
>
> Signed-off-by: Vyacheslav Bocharov <adeep@lexina.in>
> ---
> drivers/bluetooth/btrtl.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
> index c2bdd1e6060e..38d547cc6fcd 100644
> --- a/drivers/bluetooth/btrtl.c
> +++ b/drivers/bluetooth/btrtl.c
> @@ -156,6 +156,13 @@ static const struct id_table ic_id_table[] = {
> .fw_name = "rtl_bt/rtl8822cs_fw.bin",
> .cfg_name = "rtl_bt/rtl8822cs_config" },
>
> + /* 8822C with UART interface */
> + { IC_INFO(RTL_ROM_LMP_8822B, 0xc, 0x8, HCI_UART),
> + .config_needed = true,
> + .has_rom_version = true,
> + .fw_name = "rtl_bt/rtl8822cs_fw.bin",
> + .cfg_name = "rtl_bt/rtl8822cs_config" },
> +
> /* 8822C with USB interface */
> { IC_INFO(RTL_ROM_LMP_8822B, 0xc, 0xa, HCI_USB),
> .config_needed = false,
Hi Vyacheslav,
Could I make a suggestion rebasing this patch against 5.16 and putting
the UART hci ver 0008 berore 000a
this has been tested on Tanix TX6.
Before:
[ 11.512883] Bluetooth: hci0: RTL: examining hci_ver=08 hci_rev=000c lmp_ver=08 lmp_subver=8822
[ 11.512940] Bluetooth: hci0: RTL: unknown IC info, lmp subver 8822, hci rev 000c, hci ver 0008
[ 11.512957] Bluetooth: hci0: RTL: no config loaded
After:
[ 12.642167] Bluetooth: hci0: RTL: examining hci_ver=08 hci_rev=000c lmp_ver=08 lmp_subver=8822
[ 12.671911] Bluetooth: hci0: RTL: rom_version status=0 version=3
[ 12.671961] Bluetooth: hci0: RTL: loading rtl_bt/rtl8822cs_fw.bin
[ 12.706248] Bluetooth: hci0: RTL: loading rtl_bt/rtl8822cs_config.bin
[ 12.730251] Bluetooth: hci0: RTL: cfg_sz 33, total sz 40737
[ 13.318832] Bluetooth: hci0: RTL: fw version 0x05a91a4a
Tested-by: Rudi Heitbaum <rudi@heitbaum.com>
---
drivers/bluetooth/btrtl.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
--- a/drivers/bluetooth/btrtl.c 2022-01-09 22:55:34.000000000 +0000
+++ b/drivers/bluetooth/btrtl.c 2022-01-15 07:12:21.102080089 +0000
@@ -148,7 +148,15 @@
.fw_name = "rtl_bt/rtl8761bu_fw.bin",
.cfg_name = "rtl_bt/rtl8761bu_config" },
+ /* 8822C (hci ver 0008) with UART interface */
+ { IC_INFO(RTL_ROM_LMP_8822B, 0xc, 0x8, HCI_UART),
+ .config_needed = true,
+ .has_rom_version = true,
+ .has_msft_ext = true,
+ .fw_name = "rtl_bt/rtl8822cs_fw.bin",
+ .cfg_name = "rtl_bt/rtl8822cs_config" },
+
- /* 8822C with UART interface */
+ /* 8822C (hci ver 000a) with UART interface */
{ IC_INFO(RTL_ROM_LMP_8822B, 0xc, 0xa, HCI_UART),
.config_needed = true,
.has_rom_version = true,
--
2.25.1
next prev parent reply other threads:[~2022-01-19 9:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 9:14 [PATCH v3 0/2] Bluetooth: hci_h5: btrtl: Add support for RTL8822CS hci_ver 0x08 Vyacheslav Bocharov
2021-10-27 9:14 ` [PATCH v3 1/2] Bluetooth: btrtl: Add support for RTL8822C " Vyacheslav Bocharov
2022-01-19 9:01 ` Rudi Heitbaum [this message]
2022-01-19 9:44 ` Vyacheslav
2021-10-27 9:14 ` [PATCH v3 2/2] Bluetooth: hci_h5: Add power reset via gpio in h5_btrtl_open Vyacheslav Bocharov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220119090140.GA24@4f18b3450899 \
--to=rudi@heitbaum.com \
--cc=adeep@lexina.in \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.