From: Lukas Wunner <lukas@wunner.de>
To: patrice.chotard@foss.st.com
Cc: Mark Brown <broonie@kernel.org>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
linux-spi@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, christophe.kerello@foss.st.com
Subject: Re: [PATCH v3] spi: stm32-qspi: Update spi registering
Date: Wed, 19 Jan 2022 16:29:50 +0100 [thread overview]
Message-ID: <20220119152950.GA4445@wunner.de> (raw)
In-Reply-To: <20220117121744.29729-1-patrice.chotard@foss.st.com>
On Mon, Jan 17, 2022 at 01:17:44PM +0100, patrice.chotard@foss.st.com wrote:
> Some device driver need to communicate to qspi device during the remove
> process, qspi controller must be functional when spi_unregister_master()
> is called.
>
> To ensure this, replace devm_spi_register_master() by spi_register_master()
> and spi_unregister_master() is called directly in .remove callback before
> stopping the qspi controller.
>
> This issue was put in evidence using kernel v5.11 and later
> with a spi-nor which supports the software reset feature introduced
> by commit d73ee7534cc5 ("mtd: spi-nor: core: perform a Soft Reset on
> shutdown")
>
> Fixes: c530cd1d9d5e ("spi: spi-mem: add stm32 qspi controller")
>
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
> Cc: <stable@vger.kernel.org> # 5.8.x
Reviewed-by: Lukas Wunner <lukas@wunner.de>
Thanks!
Lukas
next prev parent reply other threads:[~2022-01-19 15:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 12:17 [PATCH v3] spi: stm32-qspi: Update spi registering patrice.chotard
2022-01-17 12:17 ` patrice.chotard
2022-01-19 15:29 ` Lukas Wunner [this message]
2022-01-19 18:02 ` Mark Brown
2022-01-19 18:02 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220119152950.GA4445@wunner.de \
--to=lukas@wunner.de \
--cc=alexandre.torgue@foss.st.com \
--cc=broonie@kernel.org \
--cc=christophe.kerello@foss.st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=patrice.chotard@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.