From: Dan Carpenter <dan.carpenter@oracle.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Ajith P V <ajithpv.linux@gmail.com>,
gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: fwserial: rearrange comment to avoid warning
Date: Wed, 19 Jan 2022 20:57:39 +0300 [thread overview]
Message-ID: <20220119175739.GM1951@kadam> (raw)
In-Reply-To: <dd6c45ef-70a4-9a54-affe-2bab17e13ce0@infradead.org>
On Wed, Jan 19, 2022 at 07:19:24AM -0800, Randy Dunlap wrote:
> Hi--
>
> On 1/19/22 00:41, Ajith P V wrote:
> > fwserial.h comment contains word "bits" 2 times together.
> > The sentence required this however it produce warning.
> > Change the comment to make it proper.
>
> Is that a warning from checkpatch?
Yeah. You're right.
WARNING: Possible repeated word: 'bits'
#207: FILE: drivers/staging/fwserial/fwserial.h:207:
+ * bits 15..0 correspond to TIOCM_* bits
^^^^
+ * bits 19..16 reserved for mctrl
^^^^
> If so, it's OK to ignore something like that.
> checkpatch isn't perfect and we know that.
Yep. Checkpatch is not the boss of us.
regards,
dan carpenter
prev parent reply other threads:[~2022-01-19 17:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 8:41 [PATCH] staging: fwserial: rearrange comment to avoid warning Ajith P V
2022-01-19 15:19 ` Randy Dunlap
2022-01-19 17:57 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220119175739.GM1951@kadam \
--to=dan.carpenter@oracle.com \
--cc=ajithpv.linux@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.