From: Bjorn Helgaas <helgaas@kernel.org>
To: marek.vasut@gmail.com
Cc: linux-pci@vger.kernel.org,
"Marek Vasut" <marek.vasut+renesas@gmail.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Wolfram Sang" <wsa@the-dreams.de>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2 2/2] PCI: rcar: Return all Fs from read which triggered an exception
Date: Wed, 19 Jan 2022 17:27:07 -0600 [thread overview]
Message-ID: <20220119232707.GA975859@bhelgaas> (raw)
In-Reply-To: <20220118161314.GA871416@bhelgaas>
On Tue, Jan 18, 2022 at 10:13:14AM -0600, Bjorn Helgaas wrote:
> On Mon, Jan 17, 2022 at 11:03:55PM +0100, marek.vasut@gmail.com wrote:
> > + instr &= ~0xf;
> > + if ((instr == 0xf57ff060 || instr == 0xf3bf8f60) &&
> > + (pc == (u32)&rcar_pci_read_reg_workaround_start + 4)) {
> > + /*
> > + * If the instruction being executed was a read,
> > + * make it look like it read all-ones.
> > + */
> > + instr = *(unsigned long *)(pc - 4);
> > + reg = (instr >> 12) & 15;
> > +
> > + if ((instr & 0x0c100000) == 0x04100000) {
> > + if (instr & 0x00400000)
> > + val = 255;
> > + else
> > + val = -1;
>
> Can you please use PCI_SET_ERROR_RESPONSE() or something similar here
> to make this greppable?
I should have mentioned that PCI_SET_ERROR_RESPONSE() was added in the
current merge window, so it will appear in v5.17-rc1.
Bjorn
next prev parent reply other threads:[~2022-01-19 23:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 22:03 [PATCH v2 1/2] PCI: rcar: Finish transition to L1 state in rcar_pcie_config_access() marek.vasut
2022-01-17 22:03 ` [PATCH v2 2/2] PCI: rcar: Return all Fs from read which triggered an exception marek.vasut
2022-01-17 23:38 ` Arnd Bergmann
2022-01-18 16:13 ` Bjorn Helgaas
2022-01-19 23:27 ` Bjorn Helgaas [this message]
2022-01-18 8:30 ` [PATCH v2 1/2] PCI: rcar: Finish transition to L1 state in rcar_pcie_config_access() Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220119232707.GA975859@bhelgaas \
--to=helgaas@kernel.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=geert+renesas@glider.be \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=marek.vasut+renesas@gmail.com \
--cc=marek.vasut@gmail.com \
--cc=wsa@the-dreams.de \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.