From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42022C433F5 for ; Thu, 20 Jan 2022 08:38:46 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-522-blA5P4jmO8SqE0VB_NKbZw-1; Thu, 20 Jan 2022 03:38:41 -0500 X-MC-Unique: blA5P4jmO8SqE0VB_NKbZw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A9C381083F61; Thu, 20 Jan 2022 08:38:36 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 391D8108BEE2; Thu, 20 Jan 2022 08:38:36 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8AB014BB7C; Thu, 20 Jan 2022 08:38:35 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 20K8cWL1014509 for ; Thu, 20 Jan 2022 03:38:32 -0500 Received: by smtp.corp.redhat.com (Postfix) id 882852166B1B; Thu, 20 Jan 2022 08:38:32 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 827AF2166B13 for ; Thu, 20 Jan 2022 08:38:27 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 28565811E8D for ; Thu, 20 Jan 2022 08:38:27 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-622-klhl6d_6N1KvoX3EJQUT7A-1; Thu, 20 Jan 2022 03:37:51 -0500 X-MC-Unique: klhl6d_6N1KvoX3EJQUT7A-1 Received: by verein.lst.de (Postfix, from userid 2407) id D6EFC68B05; Thu, 20 Jan 2022 09:37:46 +0100 (CET) Date: Thu, 20 Jan 2022 09:37:46 +0100 From: Christoph Hellwig To: Jinpu Wang Message-ID: <20220120083746.GA5622@lst.de> References: <20220118071952.1243143-1-hch@lst.de> <20220118071952.1243143-11-hch@lst.de> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: dm-devel@redhat.com Cc: Jens Axboe , linux-block@vger.kernel.org, linux-nfs@vger.kernel.org, Pavel Begunkov , Mike Snitzer , Philipp Reisner , Christoph Hellwig , Konstantin Komarov , Roger Pau =?iso-8859-1?Q?Monn=E9?= , dm-devel@redhat.com, linux-nilfs@vger.kernel.org, "Md . Haris Iqbal" , Lars Ellenberg , linux-fsdevel@vger.kernel.org, xen-devel@lists.xenproject.org, Andrew Morton , ntfs3@lists.linux.dev, Ryusuke Konishi , drbd-dev@lists.linbit.com Subject: Re: [dm-devel] [PATCH 10/19] rnbd-srv: simplify bio mapping in process_rdma X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Jan 19, 2022 at 01:20:54AM +0100, Jinpu Wang wrote: > this changes lead to IO error all the time, because bio_add_page return len. > We need if (bio_add_page(bio, virt_to_page(data), datalen, > offset_in_page(data)) < datalen) Does this version look good to you? http://git.infradead.org/users/hch/block.git/commitdiff/62adb08e765b889dd8db4227cad33a710e36d631 -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E4DBC433F5 for ; Thu, 20 Jan 2022 08:37:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234250AbiATIhv (ORCPT ); Thu, 20 Jan 2022 03:37:51 -0500 Received: from verein.lst.de ([213.95.11.211]:43574 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234192AbiATIhv (ORCPT ); Thu, 20 Jan 2022 03:37:51 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id D6EFC68B05; Thu, 20 Jan 2022 09:37:46 +0100 (CET) Date: Thu, 20 Jan 2022 09:37:46 +0100 From: Christoph Hellwig To: Jinpu Wang Cc: Christoph Hellwig , Jens Axboe , Pavel Begunkov , Mike Snitzer , Ryusuke Konishi , Konstantin Komarov , Andrew Morton , "Md . Haris Iqbal" , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Philipp Reisner , Lars Ellenberg , linux-block@vger.kernel.org, dm-devel@redhat.com, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, xen-devel@lists.xenproject.org, drbd-dev@lists.linbit.com Subject: Re: [PATCH 10/19] rnbd-srv: simplify bio mapping in process_rdma Message-ID: <20220120083746.GA5622@lst.de> References: <20220118071952.1243143-1-hch@lst.de> <20220118071952.1243143-11-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Jan 19, 2022 at 01:20:54AM +0100, Jinpu Wang wrote: > this changes lead to IO error all the time, because bio_add_page return len. > We need if (bio_add_page(bio, virt_to_page(data), datalen, > offset_in_page(data)) < datalen) Does this version look good to you? http://git.infradead.org/users/hch/block.git/commitdiff/62adb08e765b889dd8db4227cad33a710e36d631 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 10/19] rnbd-srv: simplify bio mapping in process_rdma Date: Thu, 20 Jan 2022 09:37:46 +0100 Message-ID: <20220120083746.GA5622@lst.de> References: <20220118071952.1243143-1-hch@lst.de> <20220118071952.1243143-11-hch@lst.de> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jinpu Wang Cc: Christoph Hellwig , Jens Axboe , Pavel Begunkov , Mike Snitzer , Ryusuke Konishi , Konstantin Komarov , Andrew Morton , "Md . Haris Iqbal" , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Philipp Reisner , Lars Ellenberg , linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ntfs3-cunTk1MwBs/YUNznpcFYbw@public.gmane.org, xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b@public.gmane.org, drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org On Wed, Jan 19, 2022 at 01:20:54AM +0100, Jinpu Wang wrote: > this changes lead to IO error all the time, because bio_add_page return len. > We need if (bio_add_page(bio, virt_to_page(data), datalen, > offset_in_page(data)) < datalen) Does this version look good to you? http://git.infradead.org/users/hch/block.git/commitdiff/62adb08e765b889dd8db4227cad33a710e36d631 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id 1A6154201E2 for ; Thu, 20 Jan 2022 09:45:36 +0100 (CET) Date: Thu, 20 Jan 2022 09:37:46 +0100 From: Christoph Hellwig To: Jinpu Wang Message-ID: <20220120083746.GA5622@lst.de> References: <20220118071952.1243143-1-hch@lst.de> <20220118071952.1243143-11-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: Jens Axboe , linux-block@vger.kernel.org, linux-nfs@vger.kernel.org, Pavel Begunkov , Mike Snitzer , Philipp Reisner , Christoph Hellwig , Konstantin Komarov , Roger Pau =?iso-8859-1?Q?Monn=E9?= , dm-devel@redhat.com, linux-nilfs@vger.kernel.org, "Md . Haris Iqbal" , Lars Ellenberg , linux-fsdevel@vger.kernel.org, xen-devel@lists.xenproject.org, Andrew Morton , ntfs3@lists.linux.dev, Ryusuke Konishi , drbd-dev@lists.linbit.com Subject: Re: [Drbd-dev] [PATCH 10/19] rnbd-srv: simplify bio mapping in process_rdma List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Jan 19, 2022 at 01:20:54AM +0100, Jinpu Wang wrote: > this changes lead to IO error all the time, because bio_add_page return len. > We need if (bio_add_page(bio, virt_to_page(data), datalen, > offset_in_page(data)) < datalen) Does this version look good to you? http://git.infradead.org/users/hch/block.git/commitdiff/62adb08e765b889dd8db4227cad33a710e36d631