All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Skripkin <paskripkin@gmail.com>
To: mchehab@kernel.org
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Pavel Skripkin" <paskripkin@gmail.com>,
	"Hans Verkuil" <hverkuil-cisco@xs4all.nl>,
	"Maximilian Böhm" <maximilian.boehm@elbmurf.de>
Subject: [PATCH] Revert "media: em28xx: add missing em28xx_close_extension"
Date: Thu, 20 Jan 2022 22:37:30 +0300	[thread overview]
Message-ID: <20220120193730.28155-1-paskripkin@gmail.com> (raw)
In-Reply-To: <a0ba3685-8c59-cb89-7f81-280c38a92c40@elbmurf.de>

This reverts commit 2c98b8a3458df03abdc6945bbef67ef91d181938.

Reverted patch causes problems with Hauppauge WinTV dualHD as Maximilian
reported [1]. Since quick solution didn't come up let's just revert it
to make this device work with upstream kernels.

Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Link: https://lore.kernel.org/all/6a72a37b-e972-187d-0322-16336e12bdc5@elbmurf.de/ [1]
Reported-by: Maximilian Böhm <maximilian.boehm@elbmurf.de>
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
---
 drivers/media/usb/em28xx/em28xx-cards.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/media/usb/em28xx/em28xx-cards.c b/drivers/media/usb/em28xx/em28xx-cards.c
index b451ce3cb169..4a46ef50baf9 100644
--- a/drivers/media/usb/em28xx/em28xx-cards.c
+++ b/drivers/media/usb/em28xx/em28xx-cards.c
@@ -4150,11 +4150,8 @@ static void em28xx_usb_disconnect(struct usb_interface *intf)
 
 	em28xx_close_extension(dev);
 
-	if (dev->dev_next) {
-		em28xx_close_extension(dev->dev_next);
+	if (dev->dev_next)
 		em28xx_release_resources(dev->dev_next);
-	}
-
 	em28xx_release_resources(dev);
 
 	if (dev->dev_next) {
-- 
2.34.1


  reply	other threads:[~2022-01-20 19:38 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-18  1:09 Kernel hangs after DVB patch from July 2021 with Hauppauge WinTV dualHD Maximilian Böhm
2021-12-18  9:15 ` Mauro Carvalho Chehab
2021-12-18 14:23   ` Pavel Skripkin
2021-12-18 22:50     ` Maximilian Böhm
2021-12-20 14:39       ` Pavel Skripkin
2022-01-04 17:22         ` Maximilian Böhm
2022-01-04 17:31           ` Pavel Skripkin
2022-01-04 17:58             ` Maximilian Böhm
2022-01-06 11:54               ` Pavel Skripkin
2022-01-06 11:57                 ` Pavel Skripkin
2022-01-20 19:29                   ` Maximilian Böhm
2022-01-20 19:37                     ` Pavel Skripkin [this message]
2022-01-21 18:30                       ` [PATCH] Revert "media: em28xx: add missing em28xx_close_extension" Maximilian Böhm
2022-01-20 19:42                     ` Kernel hangs after DVB patch from July 2021 with Hauppauge WinTV dualHD Pavel Skripkin
2022-02-17 11:14                     ` Hans Verkuil
2022-02-18  0:16                       ` Maximilian Böhm
2022-02-18  7:58                         ` Hans Verkuil
2021-12-18 20:33   ` Robert Schlabbach
2021-12-18 20:51     ` Pavel Skripkin
2021-12-18 23:19   ` Maximilian Böhm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220120193730.28155-1-paskripkin@gmail.com \
    --to=paskripkin@gmail.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=maximilian.boehm@elbmurf.de \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.