All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali@kernel.org>
To: "Martin Mares" <mj@ucw.cz>, "Bjorn Helgaas" <helgaas@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Matthew Wilcox" <willy@infradead.org>,
	linux-pci@vger.kernel.org
Subject: [PATCH pciutils 4/4] lspci: Do not show -[00]- bus in tree output
Date: Fri, 21 Jan 2022 15:22:58 +0100	[thread overview]
Message-ID: <20220121142258.28170-5-pali@kernel.org> (raw)
In-Reply-To: <20220121142258.28170-1-pali@kernel.org>

Secondary or subordinate bus cannot be zero. Zero value could indicate
either invalid secondary bus value or the fact that secondary bus value was
not filled or indicates non-compliant PCI-to-PCI bridge. This change makes
tree output better readable when bus numbers are not known or not provided.
---
 ls-tree.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/ls-tree.c b/ls-tree.c
index fede581156e4..f8154a2b034a 100644
--- a/ls-tree.c
+++ b/ls-tree.c
@@ -258,7 +258,9 @@ show_tree_dev(struct device *d, char *line, char *p)
   for (b=&host_bridge; b; b=b->chain)
     if (b->br_dev == d)
       {
-	if (b->secondary == b->subordinate)
+	if (b->secondary == 0)
+	  p = tree_printf(line, p, "-");
+	else if (b->secondary == b->subordinate)
 	  p = tree_printf(line, p, "-[%02x]-", b->secondary);
 	else
 	  p = tree_printf(line, p, "-[%02x-%02x]-", b->secondary, b->subordinate);
-- 
2.20.1


  parent reply	other threads:[~2022-01-21 14:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-21 14:22 [PATCH pciutils 0/4] Support for PCI_FILL_PARENT Pali Rohár
2022-01-21 14:22 ` [PATCH pciutils 1/4] libpci: Add new option PCI_FILL_PARENT Pali Rohár
2022-01-21 14:22 ` [PATCH pciutils 2/4] libpci: sysfs: Implement support for PCI_FILL_PARENT Pali Rohár
2022-01-21 14:22 ` [PATCH pciutils 3/4] lspci: Build tree based on PCI_FILL_PARENT information Pali Rohár
2022-01-21 14:22 ` Pali Rohár [this message]
2022-01-21 14:51 ` [PATCH pciutils 0/4] Support for PCI_FILL_PARENT Martin Mareš
2022-01-21 15:21   ` Pali Rohár
2022-01-21 15:28     ` Martin Mareš

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220121142258.28170-5-pali@kernel.org \
    --to=pali@kernel.org \
    --cc=helgaas@kernel.org \
    --cc=kw@linux.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=mj@ucw.cz \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.