From: Nico Boehr <nrb@linux.ibm.com>
To: kvm@vger.kernel.org, linux-s390@vger.kernel.org
Cc: frankja@linux.ibm.com, imbrenda@linux.ibm.com, thuth@redhat.com,
david@redhat.com
Subject: [PATCH kvm-unit-tests v1 5/8] s390x: Add more tests for SSCH
Date: Fri, 21 Jan 2022 16:09:28 +0100 [thread overview]
Message-ID: <20220121150931.371720-6-nrb@linux.ibm.com> (raw)
In-Reply-To: <20220121150931.371720-1-nrb@linux.ibm.com>
We already have some coverage of SSCH due to its use in
start_ccw1_chain() in css_lib, but two more cases deserve our
attention:
- unaligned operand address. We check for misalignment by 1 and 2 bytes.
- an invalid ORB structure.
Signed-off-by: Nico Boehr <nrb@linux.ibm.com>
Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
Reviewed-by: Pierre Morel <pmorel@linux.ibm.com>
---
s390x/css.c | 33 +++++++++++++++++++++++++++++++++
1 file changed, 33 insertions(+)
diff --git a/s390x/css.c b/s390x/css.c
index 3f9dbac173e3..aa3c22eb91bd 100644
--- a/s390x/css.c
+++ b/s390x/css.c
@@ -462,6 +462,38 @@ static void test_stcrw(void)
report_prefix_pop();
}
+static void test_ssch(void)
+{
+ const int align_to = 4;
+ struct orb orb;
+
+ if (!test_device_sid) {
+ report_skip("No device");
+ return;
+ }
+
+ report_prefix_push("Unaligned");
+ for (int i = 1; i < align_to; i *= 2) {
+ report_prefix_pushf("%d", i);
+
+ expect_pgm_int();
+ ssch(test_device_sid, (struct orb *)(alignment_test_page + i));
+ check_pgm_int_code(PGM_INT_CODE_SPECIFICATION);
+
+ report_prefix_pop();
+ }
+ report_prefix_pop();
+
+ report_prefix_push("Invalid ORB");
+
+ memset(&orb, 0xff, sizeof(orb));
+ expect_pgm_int();
+ ssch(test_device_sid, &orb);
+ check_pgm_int_code(PGM_INT_CODE_OPERAND);
+
+ report_prefix_pop();
+}
+
static struct {
const char *name;
void (*func)(void);
@@ -476,6 +508,7 @@ static struct {
{ "measurement block format1", test_schm_fmt1 },
{ "msch", test_msch },
{ "stcrw", test_stcrw },
+ { "ssch", test_ssch },
{ NULL, NULL }
};
--
2.31.1
next prev parent reply other threads:[~2022-01-21 15:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 15:09 [PATCH kvm-unit-tests v1 0/8] s390x: Extend instruction interception tests Nico Boehr
2022-01-21 15:09 ` [PATCH kvm-unit-tests v1 1/8] s390x: Add more tests for MSCH Nico Boehr
2022-01-25 11:54 ` Thomas Huth
2022-01-25 12:57 ` Nico Boehr
2022-01-21 15:09 ` [PATCH kvm-unit-tests v1 2/8] s390x: Add test for PFMF low-address protection Nico Boehr
2022-01-25 13:00 ` Thomas Huth
2022-01-21 15:09 ` [PATCH kvm-unit-tests v1 3/8] s390x: Add sck tests Nico Boehr
2022-01-21 15:09 ` [PATCH kvm-unit-tests v1 4/8] s390x: Add tests for STCRW Nico Boehr
2022-01-21 15:09 ` Nico Boehr [this message]
2022-01-21 15:09 ` [PATCH kvm-unit-tests v1 6/8] s390x: Add more tests for STSCH Nico Boehr
2022-01-21 15:09 ` [PATCH kvm-unit-tests v1 7/8] s390x: Add tests for TSCH Nico Boehr
2022-01-21 15:09 ` [PATCH kvm-unit-tests v1 8/8] s390x: Add EPSW test Nico Boehr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220121150931.371720-6-nrb@linux.ibm.com \
--to=nrb@linux.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.