From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63B2FC433EF for ; Sat, 22 Jan 2022 13:26:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BFC0C83065; Sat, 22 Jan 2022 14:26:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="M3elawGm"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E63F883003; Sat, 22 Jan 2022 14:26:21 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A90228350D for ; Sat, 22 Jan 2022 14:26:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F22B160C8A; Sat, 22 Jan 2022 13:26:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43FFAC004E1; Sat, 22 Jan 2022 13:26:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642857974; bh=3iFLjksdxQ+DJqSMVOMMeF71p9BQjQ4GXskgAAeVupA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=M3elawGmgm8+/C2TN2YJWSmncAUjia2/l3pZiwpSL2qWuTLSUDcAcxi/iyKs+ioN5 rvRI09g1LFD/06GhOtA/JrZOLazBJF98vn9NQKFKsaskQamLQAja91I/UdsLk2OujY yllH0TLlQTS7WiKw4P3xLNzrJgDhJ12q6jihw+YQcKiQllid+MMp3viTs5oT+icm0E sgfL3F1DeQrcEedfUpNk4zsHsGTFBO7YHAaOYoigakZW1P+k9P09hhLSzIm63oQnHG SJGRhOPVUU86IyIIzSDQjp/wk7C0HdpI4ipPGFG09scTv24Y3wGGpDvjE0YIcQgo84 /8wFDOz6GSsSw== Received: by pali.im (Postfix) id 9D088883; Sat, 22 Jan 2022 14:26:11 +0100 (CET) Date: Sat, 22 Jan 2022 14:26:11 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Simon Glass Cc: U-Boot Mailing List , Anatolij Gustschin , Tom Rini , Marek =?utf-8?B?QmVow7pu?= , Stefan Roese , Stefano Babic Subject: Re: [PATCH 17/23] video: Convert CONFIG_VIDEO_LOGO to Kconfig Message-ID: <20220122132611.schnplwxozqzd7ys@pali> References: <20211119202408.1815506-1-sjg@chromium.org> <20211119202408.1815506-18-sjg@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211119202408.1815506-18-sjg@chromium.org> User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Friday 19 November 2021 13:24:01 Simon Glass wrote: > This converts the following to Kconfig: > CONFIG_VIDEO_LOGO > > Note that this option depends on CONFIG_DM_VIDEO now, since cfb_console is > deprecated. The only relevant code is now in splash.c > > Drop the check for DM_VIDEO in that file. > > Signed-off-by: Simon Glass > --- ... > include/configs/nokia_rx51.h | 1 - ... > diff --git a/include/configs/nokia_rx51.h b/include/configs/nokia_rx51.h > index b37e05406e9..afb91d96a54 100644 > --- a/include/configs/nokia_rx51.h > +++ b/include/configs/nokia_rx51.h > @@ -75,7 +75,6 @@ > * Framebuffer > */ > /* Video console */ > -#define CONFIG_VIDEO_LOGO > #define VIDEO_FB_16BPP_PIXEL_SWAP > #define VIDEO_FB_16BPP_WORD_SWAP Hello! This change is now in master branch and it broke support for video logo on Nokia N900 :-( It does not work anymore and reason is because CONFIG_VIDEO_LOGO was removed from Nokia N900 config files completely, despite commit subject says CONFIG_VIDEO_LOGO was converted to Kconfig. Seems that conversion for Nokia N900 is missing. Could you please look at this issue? It is visible also in qemu, so no real hardware is needed for reproducing it.