From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5037AC433F5 for ; Sat, 22 Jan 2022 15:29:45 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AC3FC83065; Sat, 22 Jan 2022 16:29:42 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="cfBbgjEc"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7B72783041; Sat, 22 Jan 2022 16:29:40 +0100 (CET) Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C61468209A for ; Sat, 22 Jan 2022 16:29:37 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2b.google.com with SMTP id s6so7177115qvv.11 for ; Sat, 22 Jan 2022 07:29:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RCEj0I3CeVBg93quxVh1SVh/dTykhvuQhH41WWV/k7M=; b=cfBbgjEcbld1jfvbI530iYlKqeki8Zg5mjXNjQq/MwbNAZVuEBfYkT5hdlnHU8nnZS dTnWjYWjVCPSWNGrTwvsJSAvdrgpJN92N18KZbVZCqyFuBlbg+BxoPqxHuRMO15yKpQ4 otpJc7KwTbDVSFRjIZltTJFDG9sLpvLJ8O0b4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RCEj0I3CeVBg93quxVh1SVh/dTykhvuQhH41WWV/k7M=; b=Aj3uPTiEbBBLy3RHFA+naBLYhelhgK8X5qRI9YNed3/FN8KiPTYifTyzET0NZkqKif V7aUjRQH7U/CdJ8EH3Mxe7Fs/Ma1W/viGmhW2muIirVqMJt4AlfQOHS3gmSJwyZtX5O+ qiTU7eCaHit7MFRpxHU2kfd26YKGY0CNIsquOrP8hbC9UXpEuMLiPbC3zji14SeSf0RE 6OC2Z25LLkaAIT7L+OsgR6q1XTENGbltuM33+CtKxrAXiPA7Jz7KlZHJzSYSuh8GfKu0 IKevH9P+gAiZUBD1OouB2EntQyAFLzdzexUSTWOIoO4Cp8+DoMOmeeTI1zmKGb7+WDkG GrpQ== X-Gm-Message-State: AOAM531ILN0uQrAyztCD7SJv7Zu/GdH+qkI8G8dq2h+L31cwz4bRE5wG c8dkMWwK1tjFdyIBj8rNza/8Fg== X-Google-Smtp-Source: ABdhPJy8zPfUCOu2OlMPmQ8Q5crAA2saHJt6HxMy858FkyVP18iiJN6awjiY9SZnyCFvI5+kTsI4ng== X-Received: by 2002:ad4:5e86:: with SMTP id jl6mr8355964qvb.62.1642865376659; Sat, 22 Jan 2022 07:29:36 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id d20sm4706010qtb.80.2022.01.22.07.29.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Jan 2022 07:29:36 -0800 (PST) Date: Sat, 22 Jan 2022 10:29:34 -0500 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Simon Glass , U-Boot Mailing List , Anatolij Gustschin , Marek =?iso-8859-1?Q?Beh=FAn?= , Stefan Roese , Stefano Babic Subject: Re: [PATCH 17/23] video: Convert CONFIG_VIDEO_LOGO to Kconfig Message-ID: <20220122152934.GQ7004@bill-the-cat> References: <20211119202408.1815506-1-sjg@chromium.org> <20211119202408.1815506-18-sjg@chromium.org> <20220122132611.schnplwxozqzd7ys@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7kgF7nVBI97QWIGi" Content-Disposition: inline In-Reply-To: <20220122132611.schnplwxozqzd7ys@pali> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --7kgF7nVBI97QWIGi Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 22, 2022 at 02:26:11PM +0100, Pali Roh=E1r wrote: > On Friday 19 November 2021 13:24:01 Simon Glass wrote: > > This converts the following to Kconfig: > > CONFIG_VIDEO_LOGO > >=20 > > Note that this option depends on CONFIG_DM_VIDEO now, since cfb_console= is > > deprecated. The only relevant code is now in splash.c > >=20 > > Drop the check for DM_VIDEO in that file. > >=20 > > Signed-off-by: Simon Glass > > --- > ... > > include/configs/nokia_rx51.h | 1 - > ... > > diff --git a/include/configs/nokia_rx51.h b/include/configs/nokia_rx51.h > > index b37e05406e9..afb91d96a54 100644 > > --- a/include/configs/nokia_rx51.h > > +++ b/include/configs/nokia_rx51.h > > @@ -75,7 +75,6 @@ > > * Framebuffer > > */ > > /* Video console */ > > -#define CONFIG_VIDEO_LOGO > > #define VIDEO_FB_16BPP_PIXEL_SWAP > > #define VIDEO_FB_16BPP_WORD_SWAP >=20 > Hello! >=20 > This change is now in master branch and it broke support for video logo > on Nokia N900 :-( It does not work anymore and reason is because > CONFIG_VIDEO_LOGO was removed from Nokia N900 config files completely, > despite commit subject says CONFIG_VIDEO_LOGO was converted to Kconfig. >=20 > Seems that conversion for Nokia N900 is missing. Could you please look > at this issue? It is visible also in qemu, so no real hardware is needed > for reproducing it. This is perhaps as good/bad time as any to ask about the conversion efforts for N900 USB things that were discussed before? --=20 Tom --7kgF7nVBI97QWIGi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmHsItoACgkQFHw5/5Y0 tyyqNAv9GsZ1maDXD1syuIfYny5eWALgcgAVRwcfso7BcnCe3Ki9zVwU76cBQ9LI hAnghl2asQHwn9uZr/nJX72uJZkcKYUNDHjL4Km0Pa5jqOPIKbY6nEjDO0drobPn 3SiOxLja4gX+BwNnikTq5vZv40jA6BgsjXunv8MnkKDGJu5BNQ87hJiRuxtsSsrT UIUT8O+g/bWbZbxwGYPTRTneOdUMJZzd0enxPxF41HshuMGw2LIHEko/3g3TmAFS eBw/vOzcf7yJJxJ481Mk8nED56nIu9RGk01m6b9OJ1RKuU9W7/qOVc/otDVGv2il B59JxuA+iAWh3OpGfabVqEi6ZfMSWRRDlhhwVUwrcs9XHOm+/szFF16I07qOGsLr WY/0DpoPqJEyWIa7AEChwYI1X4DRPLemEnCC5ccHICThXG2/AQFtKTLlnbZVW8Fg RYKdSL6uLHKBD+no7an1We/wI2ywk/xeQkAc/Y8dN1bFq8HgQNGKZCo7K3S4eroz luPDK8It =nile -----END PGP SIGNATURE----- --7kgF7nVBI97QWIGi--