From: Jonathan Cameron <jic23@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH][next] iio: hw_consumer: Use struct_size() helper in kzalloc()
Date: Sat, 22 Jan 2022 16:56:49 +0000 [thread overview]
Message-ID: <20220122165649.4c3a3f9e@jic23-huawei> (raw)
In-Reply-To: <202201201532.1F9C5BD@keescook>
On Thu, 20 Jan 2022 15:33:14 -0800
Kees Cook <keescook@chromium.org> wrote:
> On Thu, Jan 20, 2022 at 04:52:43PM -0600, Gustavo A. R. Silva wrote:
> > Make use of the struct_size() helper instead of an open-coded version,
> > in order to avoid any potential type mistakes or integer overflows that,
> > in the worst scenario, could lead to heap overflows.
> >
> > Also, address the following sparse warnings:
> > drivers/iio/buffer/industrialio-hw-consumer.c:63:23: warning: using sizeof on a flexible structure
> >
> > Link: https://github.com/KSPP/linux/issues/174
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>
> Looks good to me.
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
>
Good thing to tidy up, but I'm a little curious why I'm not
seeing these reports with latest sparse?
Ah. Found it via the report linked
CF='-Wflexible-array-sizeof'
Probably worth mentioned that in the patch descriptions. I've added it
to this one.
I'm still setting the sparse report even with this patch.
What am I missing?
Jonathan
prev parent reply other threads:[~2022-01-22 16:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 22:52 [PATCH][next] iio: hw_consumer: Use struct_size() helper in kzalloc() Gustavo A. R. Silva
2022-01-20 23:33 ` Kees Cook
2022-01-22 16:56 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220122165649.4c3a3f9e@jic23-huawei \
--to=jic23@kernel.org \
--cc=gustavoars@kernel.org \
--cc=keescook@chromium.org \
--cc=lars@metafoo.de \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.