From: Allison Henderson <allison.henderson@oracle.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH v26 10/12] xfs: Add larp debug option
Date: Sun, 23 Jan 2022 22:27:06 -0700 [thread overview]
Message-ID: <20220124052708.580016-11-allison.henderson@oracle.com> (raw)
In-Reply-To: <20220124052708.580016-1-allison.henderson@oracle.com>
This patch adds a debug option to enable log attribute replay. Eventually
this can be removed when delayed attrs becomes permanent.
Signed-off-by: Allison Henderson <allison.henderson@oracle.com>
Reviewed-by: Chandan Babu R <chandanrlinux@gmail.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
---
fs/xfs/libxfs/xfs_attr.h | 4 ++++
fs/xfs/xfs_globals.c | 1 +
fs/xfs/xfs_sysctl.h | 1 +
fs/xfs/xfs_sysfs.c | 24 ++++++++++++++++++++++++
4 files changed, 30 insertions(+)
diff --git a/fs/xfs/libxfs/xfs_attr.h b/fs/xfs/libxfs/xfs_attr.h
index 5331551d5939..78884e826ca4 100644
--- a/fs/xfs/libxfs/xfs_attr.h
+++ b/fs/xfs/libxfs/xfs_attr.h
@@ -30,7 +30,11 @@ struct xfs_attr_list_context;
static inline bool xfs_has_larp(struct xfs_mount *mp)
{
+#ifdef DEBUG
+ return xfs_globals.larp;
+#else
return false;
+#endif
}
/*
diff --git a/fs/xfs/xfs_globals.c b/fs/xfs/xfs_globals.c
index f62fa652c2fd..4d0a98f920ca 100644
--- a/fs/xfs/xfs_globals.c
+++ b/fs/xfs/xfs_globals.c
@@ -41,5 +41,6 @@ struct xfs_globals xfs_globals = {
#endif
#ifdef DEBUG
.pwork_threads = -1, /* automatic thread detection */
+ .larp = false, /* log attribute replay */
#endif
};
diff --git a/fs/xfs/xfs_sysctl.h b/fs/xfs/xfs_sysctl.h
index 7692e76ead33..f78ad6b10ea5 100644
--- a/fs/xfs/xfs_sysctl.h
+++ b/fs/xfs/xfs_sysctl.h
@@ -83,6 +83,7 @@ extern xfs_param_t xfs_params;
struct xfs_globals {
#ifdef DEBUG
int pwork_threads; /* parallel workqueue threads */
+ bool larp; /* log attribute replay */
#endif
int log_recovery_delay; /* log recovery delay (secs) */
int mount_delay; /* mount setup delay (secs) */
diff --git a/fs/xfs/xfs_sysfs.c b/fs/xfs/xfs_sysfs.c
index 574b80c29fe1..f7faf6e70d7f 100644
--- a/fs/xfs/xfs_sysfs.c
+++ b/fs/xfs/xfs_sysfs.c
@@ -228,6 +228,29 @@ pwork_threads_show(
return sysfs_emit(buf, "%d\n", xfs_globals.pwork_threads);
}
XFS_SYSFS_ATTR_RW(pwork_threads);
+
+static ssize_t
+larp_store(
+ struct kobject *kobject,
+ const char *buf,
+ size_t count)
+{
+ ssize_t ret;
+
+ ret = kstrtobool(buf, &xfs_globals.larp);
+ if (ret < 0)
+ return ret;
+ return count;
+}
+
+STATIC ssize_t
+larp_show(
+ struct kobject *kobject,
+ char *buf)
+{
+ return snprintf(buf, PAGE_SIZE, "%d\n", xfs_globals.larp);
+}
+XFS_SYSFS_ATTR_RW(larp);
#endif /* DEBUG */
static struct attribute *xfs_dbg_attrs[] = {
@@ -237,6 +260,7 @@ static struct attribute *xfs_dbg_attrs[] = {
ATTR_LIST(always_cow),
#ifdef DEBUG
ATTR_LIST(pwork_threads),
+ ATTR_LIST(larp),
#endif
NULL,
};
--
2.25.1
next prev parent reply other threads:[~2022-01-24 5:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 5:26 [PATCH v26 00/12] xfs: Log Attribute Replay Allison Henderson
2022-01-24 5:26 ` [PATCH v26 01/12] xfs: Fix double unlock in defer capture code Allison Henderson
2022-01-27 5:38 ` Chandan Babu R
2022-01-27 22:54 ` Allison Henderson
2022-01-24 5:26 ` [PATCH v26 02/12] xfs: don't commit the first deferred transaction without intents Allison Henderson
2022-01-25 0:52 ` Darrick J. Wong
2022-01-27 6:45 ` Allison Henderson
2022-01-24 5:26 ` [PATCH v26 03/12] xfs: Return from xfs_attr_set_iter if there are no more rmtblks to process Allison Henderson
2022-01-24 5:27 ` [PATCH v26 04/12] xfs: Set up infrastructure for log attribute replay Allison Henderson
2022-01-25 1:10 ` Darrick J. Wong
2022-01-27 6:45 ` Allison Henderson
2022-01-24 5:27 ` [PATCH v26 05/12] xfs: Implement attr logging and replay Allison Henderson
2022-01-25 1:19 ` Darrick J. Wong
2022-01-27 6:45 ` Allison Henderson
2022-01-24 5:27 ` [PATCH v26 06/12] xfs: Skip flip flags for delayed attrs Allison Henderson
2022-01-24 5:27 ` [PATCH v26 07/12] xfs: Add xfs_attr_set_deferred and xfs_attr_remove_deferred Allison Henderson
2022-01-24 5:27 ` [PATCH v26 08/12] xfs: Remove unused xfs_attr_*_args Allison Henderson
2022-01-24 5:27 ` [PATCH v26 09/12] xfs: Add log attribute error tag Allison Henderson
2022-01-24 5:27 ` Allison Henderson [this message]
2022-01-24 5:27 ` [PATCH v26 11/12] xfs: Merge xfs_delattr_context into xfs_attr_item Allison Henderson
2022-01-24 5:27 ` [PATCH v26 12/12] xfs: Add helper function xfs_attr_leaf_addname Allison Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220124052708.580016-11-allison.henderson@oracle.com \
--to=allison.henderson@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.