From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: drivers/gpu/drm/vc4/vc4_kms.c:414 vc4_atomic_commit_setup() warn: passing zero to 'PTR_ERR'
Date: Mon, 24 Jan 2022 06:59:31 +0800 [thread overview]
Message-ID: <202201240642.kNVBulZh-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 3395 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Maxime Ripard <maxime@cerno.tech>
CC: Dave Stevenson <dave.stevenson@raspberrypi.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: dd81e1c7d5fb126e5fbc5c9e334d7b3ec29a16a0
commit: f927767978d201d4ac023fcd797adbb963a6565d drm/vc4: kms: Fix return code check
date: 8 weeks ago
:::::: branch date: 7 hours ago
:::::: commit date: 8 weeks ago
config: powerpc64-randconfig-m031-20220120 (https://download.01.org/0day-ci/archive/20220124/202201240642.kNVBulZh-lkp(a)intel.com/config)
compiler: powerpc64-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/gpu/drm/vc4/vc4_kms.c:414 vc4_atomic_commit_setup() warn: passing zero to 'PTR_ERR'
drivers/gpu/drm/vc4/vc4_kms.c:425 vc4_atomic_commit_setup() error: 'hvs_state' dereferencing possible ERR_PTR()
vim +/PTR_ERR +414 drivers/gpu/drm/vc4/vc4_kms.c
b501bacc6060fd Eric Anholt 2015-11-30 404
9ec03d7f1ed394 Maxime Ripard 2020-12-04 405 static int vc4_atomic_commit_setup(struct drm_atomic_state *state)
9ec03d7f1ed394 Maxime Ripard 2020-12-04 406 {
9ec03d7f1ed394 Maxime Ripard 2020-12-04 407 struct drm_crtc_state *crtc_state;
9ec03d7f1ed394 Maxime Ripard 2020-12-04 408 struct vc4_hvs_state *hvs_state;
9ec03d7f1ed394 Maxime Ripard 2020-12-04 409 struct drm_crtc *crtc;
9ec03d7f1ed394 Maxime Ripard 2020-12-04 410 unsigned int i;
9ec03d7f1ed394 Maxime Ripard 2020-12-04 411
9ec03d7f1ed394 Maxime Ripard 2020-12-04 412 hvs_state = vc4_hvs_get_new_global_state(state);
f927767978d201 Maxime Ripard 2021-11-17 413 if (WARN_ON(IS_ERR(hvs_state)))
f927767978d201 Maxime Ripard 2021-11-17 @414 return PTR_ERR(hvs_state);
9ec03d7f1ed394 Maxime Ripard 2020-12-04 415
9ec03d7f1ed394 Maxime Ripard 2020-12-04 416 for_each_new_crtc_in_state(state, crtc, crtc_state, i) {
9ec03d7f1ed394 Maxime Ripard 2020-12-04 417 struct vc4_crtc_state *vc4_crtc_state =
9ec03d7f1ed394 Maxime Ripard 2020-12-04 418 to_vc4_crtc_state(crtc_state);
9ec03d7f1ed394 Maxime Ripard 2020-12-04 419 unsigned int channel =
9ec03d7f1ed394 Maxime Ripard 2020-12-04 420 vc4_crtc_state->assigned_channel;
9ec03d7f1ed394 Maxime Ripard 2020-12-04 421
9ec03d7f1ed394 Maxime Ripard 2020-12-04 422 if (channel == VC4_HVS_CHANNEL_DISABLED)
9ec03d7f1ed394 Maxime Ripard 2020-12-04 423 continue;
9ec03d7f1ed394 Maxime Ripard 2020-12-04 424
9ec03d7f1ed394 Maxime Ripard 2020-12-04 @425 if (!hvs_state->fifo_state[channel].in_use)
9ec03d7f1ed394 Maxime Ripard 2020-12-04 426 continue;
9ec03d7f1ed394 Maxime Ripard 2020-12-04 427
9ec03d7f1ed394 Maxime Ripard 2020-12-04 428 hvs_state->fifo_state[channel].pending_commit =
9ec03d7f1ed394 Maxime Ripard 2020-12-04 429 drm_crtc_commit_get(crtc_state->commit);
9ec03d7f1ed394 Maxime Ripard 2020-12-04 430 }
9ec03d7f1ed394 Maxime Ripard 2020-12-04 431
9ec03d7f1ed394 Maxime Ripard 2020-12-04 432 return 0;
9ec03d7f1ed394 Maxime Ripard 2020-12-04 433 }
9ec03d7f1ed394 Maxime Ripard 2020-12-04 434
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next reply other threads:[~2022-01-23 22:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-23 22:59 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-01-23 4:58 drivers/gpu/drm/vc4/vc4_kms.c:414 vc4_atomic_commit_setup() warn: passing zero to 'PTR_ERR' kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202201240642.kNVBulZh-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.