From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A318BC433EF for ; Mon, 24 Jan 2022 09:29:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233715AbiAXJ3D (ORCPT ); Mon, 24 Jan 2022 04:29:03 -0500 Received: from mga01.intel.com ([192.55.52.88]:33652 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233202AbiAXJ3C (ORCPT ); Mon, 24 Jan 2022 04:29:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643016542; x=1674552542; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=qiYa68DZset/+GHU23v7gsmy5RVOLlEdSLnfR9RS/NA=; b=A7BCxH+tfAQN3t9uIKjNUJu64qt97wZ11c8GholSXLT5pUP0w1RepbxX 2cUcuPNPGtAJCYgU+D9Wn+3Dyh+4fpQ8fdmdl9MYqlG6Xy/5JqcSY+eHL c1jpb2K6bT+LMAgenqyufSHToBLyjEz0EVEo/DU1xxcXkh0Yh21t7tDOr rUxuKNJzRYijHIFkPF1xCI5xR5H05fARp+VnqykUvVUWYV1CQRPFFKIYl RlBxDiLtYsCJyISkLQ0pc3kjUGtgwmULteava/8h+v/2bevLePED9ZVso mA8MIoVgn3YvZ3CqsZup8jVH1gGK5fCbuZnuwazmpn9yJrEOgm0gkKCpO w==; X-IronPort-AV: E=McAfee;i="6200,9189,10236"; a="270439681" X-IronPort-AV: E=Sophos;i="5.88,311,1635231600"; d="scan'208";a="270439681" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2022 01:28:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,311,1635231600"; d="scan'208";a="476657671" Received: from lkp-server01.sh.intel.com (HELO 276f1b88eecb) ([10.239.97.150]) by orsmga003.jf.intel.com with ESMTP; 24 Jan 2022 01:28:26 -0800 Received: from kbuild by 276f1b88eecb with local (Exim 4.92) (envelope-from ) id 1nBveE-000I6R-5k; Mon, 24 Jan 2022 09:28:26 +0000 Date: Mon, 24 Jan 2022 17:27:35 +0800 From: kernel test robot To: NeilBrown , Trond Myklebust , Anna Schumaker , Chuck Lever , Andrew Morton , Mel Gorman , Christoph Hellwig , David Howells Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, Linux Memory Management List , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 09/23] MM: submit multipage reads for SWP_FS_OPS swap-space Message-ID: <202201241747.X9gXaaeP-lkp@intel.com> References: <164299611278.26253.14950274629759580371.stgit@noble.brown> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <164299611278.26253.14950274629759580371.stgit@noble.brown> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Hi NeilBrown, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.17-rc1 next-20220124] [cannot apply to trondmy-nfs/linux-next cifs/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/NeilBrown/Repair-SWAP-over_NFS/20220124-115716 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git dd81e1c7d5fb126e5fbc5c9e334d7b3ec29a16a0 config: i386-randconfig-a011-20220124 (https://download.01.org/0day-ci/archive/20220124/202201241747.X9gXaaeP-lkp@intel.com/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 9006bf424847bf91f0a624ffc27ad165c7b804c4) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/63bff668aa0537d7ccef9ed428809fc16c1a6b6c git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review NeilBrown/Repair-SWAP-over_NFS/20220124-115716 git checkout 63bff668aa0537d7ccef9ed428809fc16c1a6b6c # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from mm/vmscan.c:61: mm/swap.h:66:12: warning: declaration of 'struct swap_iocb' will not be visible outside of this function [-Wvisibility] struct swap_iocb **plug); ^ >> mm/swap.h:67:1: error: expected identifier or '(' { ^ 1 warning and 1 error generated. -- In file included from mm/shmem.c:41: mm/swap.h:66:12: warning: declaration of 'struct swap_iocb' will not be visible outside of this function [-Wvisibility] struct swap_iocb **plug); ^ >> mm/swap.h:67:1: error: expected identifier or '(' { ^ In file included from mm/shmem.c:56: include/linux/mman.h:158:9: warning: division by zero is undefined [-Wdivision-by-zero] _calc_vm_trans(flags, MAP_SYNC, VM_SYNC ) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/mman.h:136:21: note: expanded from macro '_calc_vm_trans' : ((x) & (bit1)) / ((bit1) / (bit2)))) ^ ~~~~~~~~~~~~~~~~~ 2 warnings and 1 error generated. -- In file included from mm/page_alloc.c:84: mm/swap.h:66:12: warning: declaration of 'struct swap_iocb' will not be visible outside of this function [-Wvisibility] struct swap_iocb **plug); ^ >> mm/swap.h:67:1: error: expected identifier or '(' { ^ mm/page_alloc.c:3821:15: warning: no previous prototype for function 'should_fail_alloc_page' [-Wmissing-prototypes] noinline bool should_fail_alloc_page(gfp_t gfp_mask, unsigned int order) ^ mm/page_alloc.c:3821:10: note: declare 'static' if the function is not intended to be used outside of this translation unit noinline bool should_fail_alloc_page(gfp_t gfp_mask, unsigned int order) ^ static 2 warnings and 1 error generated. vim +67 mm/swap.h 50dceef273a619 NeilBrown 2022-01-24 45 50dceef273a619 NeilBrown 2022-01-24 46 struct page *read_swap_cache_async(swp_entry_t, gfp_t, 50dceef273a619 NeilBrown 2022-01-24 47 struct vm_area_struct *vma, 50dceef273a619 NeilBrown 2022-01-24 48 unsigned long addr, 63bff668aa0537 NeilBrown 2022-01-24 49 bool do_poll, 63bff668aa0537 NeilBrown 2022-01-24 50 struct swap_iocb **plug); 50dceef273a619 NeilBrown 2022-01-24 51 struct page *__read_swap_cache_async(swp_entry_t, gfp_t, 50dceef273a619 NeilBrown 2022-01-24 52 struct vm_area_struct *vma, 50dceef273a619 NeilBrown 2022-01-24 53 unsigned long addr, 50dceef273a619 NeilBrown 2022-01-24 54 bool *new_page_allocated); 50dceef273a619 NeilBrown 2022-01-24 55 struct page *swap_cluster_readahead(swp_entry_t entry, gfp_t flag, 50dceef273a619 NeilBrown 2022-01-24 56 struct vm_fault *vmf); 50dceef273a619 NeilBrown 2022-01-24 57 struct page *swapin_readahead(swp_entry_t entry, gfp_t flag, 50dceef273a619 NeilBrown 2022-01-24 58 struct vm_fault *vmf); 50dceef273a619 NeilBrown 2022-01-24 59 12cf545fe71035 NeilBrown 2022-01-24 60 static inline unsigned int page_swap_flags(struct page *page) 12cf545fe71035 NeilBrown 2022-01-24 61 { 12cf545fe71035 NeilBrown 2022-01-24 62 return page_swap_info(page)->flags; 12cf545fe71035 NeilBrown 2022-01-24 63 } 50dceef273a619 NeilBrown 2022-01-24 64 #else /* CONFIG_SWAP */ 63bff668aa0537 NeilBrown 2022-01-24 65 static inline int swap_readpage(struct page *page, bool do_poll, 63bff668aa0537 NeilBrown 2022-01-24 @66 struct swap_iocb **plug); 50dceef273a619 NeilBrown 2022-01-24 @67 { 50dceef273a619 NeilBrown 2022-01-24 68 return 0; 50dceef273a619 NeilBrown 2022-01-24 69 } 50dceef273a619 NeilBrown 2022-01-24 70 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============2195883654713513500==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH 09/23] MM: submit multipage reads for SWP_FS_OPS swap-space Date: Mon, 24 Jan 2022 17:27:35 +0800 Message-ID: <202201241747.X9gXaaeP-lkp@intel.com> In-Reply-To: <164299611278.26253.14950274629759580371.stgit@noble.brown> List-Id: --===============2195883654713513500== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi NeilBrown, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.17-rc1 next-20220124] [cannot apply to trondmy-nfs/linux-next cifs/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/NeilBrown/Repair-SWAP-over= _NFS/20220124-115716 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = dd81e1c7d5fb126e5fbc5c9e334d7b3ec29a16a0 config: i386-randconfig-a011-20220124 (https://download.01.org/0day-ci/arch= ive/20220124/202201241747.X9gXaaeP-lkp(a)intel.com/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 9006bf= 424847bf91f0a624ffc27ad165c7b804c4) reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/63bff668aa0537d7ccef9ed42= 8809fc16c1a6b6c git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review NeilBrown/Repair-SWAP-over_NFS/202= 20124-115716 git checkout 63bff668aa0537d7ccef9ed428809fc16c1a6b6c # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dclang make.cross W=3D= 1 O=3Dbuild_dir ARCH=3Di386 SHELL=3D/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from mm/vmscan.c:61: mm/swap.h:66:12: warning: declaration of 'struct swap_iocb' will not be = visible outside of this function [-Wvisibility] struct swap_iocb **plug); ^ >> mm/swap.h:67:1: error: expected identifier or '(' { ^ 1 warning and 1 error generated. -- In file included from mm/shmem.c:41: mm/swap.h:66:12: warning: declaration of 'struct swap_iocb' will not be = visible outside of this function [-Wvisibility] struct swap_iocb **plug); ^ >> mm/swap.h:67:1: error: expected identifier or '(' { ^ In file included from mm/shmem.c:56: include/linux/mman.h:158:9: warning: division by zero is undefined [-Wdi= vision-by-zero] _calc_vm_trans(flags, MAP_SYNC, VM_SYNC ) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/mman.h:136:21: note: expanded from macro '_calc_vm_trans' : ((x) & (bit1)) / ((bit1) / (bit2)))) ^ ~~~~~~~~~~~~~~~~~ 2 warnings and 1 error generated. -- In file included from mm/page_alloc.c:84: mm/swap.h:66:12: warning: declaration of 'struct swap_iocb' will not be = visible outside of this function [-Wvisibility] struct swap_iocb **plug); ^ >> mm/swap.h:67:1: error: expected identifier or '(' { ^ mm/page_alloc.c:3821:15: warning: no previous prototype for function 'sh= ould_fail_alloc_page' [-Wmissing-prototypes] noinline bool should_fail_alloc_page(gfp_t gfp_mask, unsigned int order) ^ mm/page_alloc.c:3821:10: note: declare 'static' if the function is not i= ntended to be used outside of this translation unit noinline bool should_fail_alloc_page(gfp_t gfp_mask, unsigned int order) ^ static = 2 warnings and 1 error generated. vim +67 mm/swap.h 50dceef273a619 NeilBrown 2022-01-24 45 = 50dceef273a619 NeilBrown 2022-01-24 46 struct page *read_swap_cache_async= (swp_entry_t, gfp_t, 50dceef273a619 NeilBrown 2022-01-24 47 struct vm_area_struct *vma, 50dceef273a619 NeilBrown 2022-01-24 48 unsigned long addr, 63bff668aa0537 NeilBrown 2022-01-24 49 bool do_poll, 63bff668aa0537 NeilBrown 2022-01-24 50 struct swap_iocb **plug); 50dceef273a619 NeilBrown 2022-01-24 51 struct page *__read_swap_cache_asy= nc(swp_entry_t, gfp_t, 50dceef273a619 NeilBrown 2022-01-24 52 struct vm_area_struct *vm= a, 50dceef273a619 NeilBrown 2022-01-24 53 unsigned long addr, 50dceef273a619 NeilBrown 2022-01-24 54 bool *new_page_allocated); 50dceef273a619 NeilBrown 2022-01-24 55 struct page *swap_cluster_readahea= d(swp_entry_t entry, gfp_t flag, 50dceef273a619 NeilBrown 2022-01-24 56 struct vm_fault *vmf); 50dceef273a619 NeilBrown 2022-01-24 57 struct page *swapin_readahead(swp_= entry_t entry, gfp_t flag, 50dceef273a619 NeilBrown 2022-01-24 58 struct vm_fault *vmf); 50dceef273a619 NeilBrown 2022-01-24 59 = 12cf545fe71035 NeilBrown 2022-01-24 60 static inline unsigned int page_sw= ap_flags(struct page *page) 12cf545fe71035 NeilBrown 2022-01-24 61 { 12cf545fe71035 NeilBrown 2022-01-24 62 return page_swap_info(page)->flag= s; 12cf545fe71035 NeilBrown 2022-01-24 63 } 50dceef273a619 NeilBrown 2022-01-24 64 #else /* CONFIG_SWAP */ 63bff668aa0537 NeilBrown 2022-01-24 65 static inline int swap_readpage(st= ruct page *page, bool do_poll, 63bff668aa0537 NeilBrown 2022-01-24 @66 struct swap_iocb **plug); 50dceef273a619 NeilBrown 2022-01-24 @67 { 50dceef273a619 NeilBrown 2022-01-24 68 return 0; 50dceef273a619 NeilBrown 2022-01-24 69 } 50dceef273a619 NeilBrown 2022-01-24 70 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============2195883654713513500==--