From: Denys Dmytriyenko <denis@denix.org>
To: Ross Burton <ross@burtonini.com>
Cc: meta-arm@lists.yoctoproject.org,
Richard Purdie <richard.purdie@linuxfoundation.org>
Subject: Re: [meta-arm] [PATCH 2/2] CI: fix check-layer indeterminism
Date: Mon, 24 Jan 2022 13:06:27 -0500 [thread overview]
Message-ID: <20220124180627.GU26229@denix.org> (raw)
In-Reply-To: <20220124174012.3916927-2-ross.burton@arm.com>
On Mon, Jan 24, 2022 at 05:40:12PM +0000, Ross Burton wrote:
> yocto-check-layers is very greedy when searching for layers, and will
> find the test layers in Bitbake if given the chance, for example:
>
> bitbake/lib/layerindexlib/tests/testdata/layer4
>
> This layer has the collection name openembedded-layer and is only
> compatible with Sumo. The selection of layer from collection name is
> not deterministic, so it's possible that this layer is selected which
> then fails the check as it isn't compatible.
>
> Solve this by restricting the dependency layers in meta-arm to just
> meta-arm/meta-*, so it doesn't recurse into meta-arm/work/poky/bitbake.
FWIW, I've fallen into this trap before - should this Sumo remnant be removed
from Bitbake then?
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
> .gitlab-ci.yml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 9a60f672..4c5d74e9 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -79,7 +79,7 @@ check-layers:
> extends: .setup
> script:
> - kas shell --update --force-checkout ci/base.yml:ci/meta-openembedded.yml --command \
> - "yocto-check-layer-wrapper $CI_PROJECT_DIR/$LAYER --dependency $CI_PROJECT_DIR $KAS_WORK_DIR/meta-openembedded/meta-oe --no-auto-dependency"
> + "yocto-check-layer-wrapper $CI_PROJECT_DIR/$LAYER --dependency $CI_PROJECT_DIR/meta-* $KAS_WORK_DIR/meta-openembedded/meta-oe --no-auto-dependency"
> parallel:
> matrix:
> - LAYER: [meta-arm, meta-arm-bsp, meta-arm-toolchain, meta-gem5]
> --
> 2.25.1
>
--
Regards,
Denys Dmytriyenko <denis@denix.org>
PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
Fingerprint: 25FC E4A5 8A72 2F69 1186 6D76 4209 0272 9A92 C964
next prev parent reply other threads:[~2022-01-24 18:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 17:40 [PATCH 1/2] CI: update for meta-zephyr changes Ross Burton
2022-01-24 17:40 ` [PATCH 2/2] CI: fix check-layer indeterminism Ross Burton
2022-01-24 18:06 ` Denys Dmytriyenko [this message]
2022-01-24 18:24 ` [meta-arm] " Ross Burton
2022-01-24 19:53 ` [PATCH 1/2] CI: update for meta-zephyr changes Jon Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220124180627.GU26229@denix.org \
--to=denis@denix.org \
--cc=meta-arm@lists.yoctoproject.org \
--cc=richard.purdie@linuxfoundation.org \
--cc=ross@burtonini.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.