All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Johnston <matt@codeconstruct.com.au>
To: unlisted-recipients:; (no To-header on input)
Cc: "Kevin Darbyshire-Bryant" <ldir@darbyshire-bryant.me.uk>,
	"Toke Høiland-Jørgensen" <toke@redhat.com>,
	"David S . Miller" <davem@davemloft.net>,
	"Jakub Kicinski" <kuba@kernel.org>,
	netdev@vger.kernel.org, cake@lists.bufferbloat.net
Subject: [PATCH net] sch_cake: diffserv8 CS1 should be bulk
Date: Tue, 25 Jan 2022 14:04:10 +0800	[thread overview]
Message-ID: <20220125060410.2691029-1-matt@codeconstruct.com.au> (raw)

The CS1 priority (index 0x08) was changed from 0 to 1 when LE (index
0x01) was added. This looks unintentional, it doesn't match the
docs and CS1 shouldn't be the same tin as AF1x

Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>
Fixes: b8392808eb3f ("sch_cake: add RFC 8622 LE PHB support to CAKE diffserv handling")
---
 net/sched/sch_cake.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c
index 857aaebd49f4..6ff2ddc5b812 100644
--- a/net/sched/sch_cake.c
+++ b/net/sched/sch_cake.c
@@ -313,7 +313,7 @@ static const u8 precedence[] = {
 
 static const u8 diffserv8[] = {
 	2, 0, 1, 2, 4, 2, 2, 2,
-	1, 2, 1, 2, 1, 2, 1, 2,
+	0, 2, 1, 2, 1, 2, 1, 2,
 	5, 2, 4, 2, 4, 2, 4, 2,
 	3, 2, 3, 2, 3, 2, 3, 2,
 	6, 2, 3, 2, 3, 2, 3, 2,
-- 
2.32.0


             reply	other threads:[~2022-01-25  6:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-25  6:04 Matt Johnston [this message]
2022-01-25 10:58 ` [PATCH net] sch_cake: diffserv8 CS1 should be bulk Toke Høiland-Jørgensen
2022-01-25 11:54   ` [Cake] " Sebastian Moeller
2022-01-27  3:14     ` Matt Johnston
2022-01-27 16:00       ` Sebastian Moeller
2022-01-28  4:31         ` Matt Johnston
2022-01-27  9:00   ` Kevin 'ldir' Darbyshire-Bryant
2022-01-27 16:02     ` [Cake] " Sebastian Moeller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220125060410.2691029-1-matt@codeconstruct.com.au \
    --to=matt@codeconstruct.com.au \
    --cc=cake@lists.bufferbloat.net \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=ldir@darbyshire-bryant.me.uk \
    --cc=netdev@vger.kernel.org \
    --cc=toke@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.