diff for duplicates of <202201250715.EbP8D1XT-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index 958646e..3a62692 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,13 +1,7 @@ -CC: kbuild-all(a)lists.01.org -CC: linux-kernel(a)vger.kernel.org -TO: Allison Henderson <allison.henderson@oracle.com> - -tree: https://github.com/allisonhenderson/xfs_work.git delayed_attrs_v26_extended +tree: https://github.com/allisonhenderson/xfs_work.git delayed_attrs_v26_extended head: 19459f5cfa422b0a6a9cd3898892e43ecb49f8f3 commit: 38f492d29e0c25066170d87572b7ade7bf2af72b [28/30] xfs: Add parent pointer ioctl -:::::: branch date: 29 hours ago -:::::: commit date: 29 hours ago -config: nios2-randconfig-m031-20220124 (https://download.01.org/0day-ci/archive/20220125/202201250715.EbP8D1XT-lkp(a)intel.com/config) +config: nios2-randconfig-m031-20220124 (https://download.01.org/0day-ci/archive/20220125/202201250715.EbP8D1XT-lkp(a)intel.com/config ) compiler: nios2-linux-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate @@ -22,18 +16,6 @@ arch/nios2/include/asm/thread_info.h:71 current_thread_info() error: uninitializ vim +1753 fs/xfs/xfs_ioctl.c -36fd6e863cb732 Darrick J. Wong 2017-10-17 1674 -38f492d29e0c25 Allison Henderson 2021-07-23 1675 /* -38f492d29e0c25 Allison Henderson 2021-07-23 1676 * IOCTL routine to get the parent pointers of an inode and return it to user -38f492d29e0c25 Allison Henderson 2021-07-23 1677 * space. Caller must pass a buffer space containing a struct xfs_pptr_info, -38f492d29e0c25 Allison Henderson 2021-07-23 1678 * followed by a region large enough to contain an array of struct -38f492d29e0c25 Allison Henderson 2021-07-23 1679 * xfs_parent_ptr of a size specified in pi_ptrs_size. If the inode contains -38f492d29e0c25 Allison Henderson 2021-07-23 1680 * more parent pointers than can fit in the buffer space, caller may re-call -38f492d29e0c25 Allison Henderson 2021-07-23 1681 * the function using the returned pi_cursor to resume iteration. The -38f492d29e0c25 Allison Henderson 2021-07-23 1682 * number of xfs_parent_ptr returned will be stored in pi_ptrs_used. -38f492d29e0c25 Allison Henderson 2021-07-23 1683 * -38f492d29e0c25 Allison Henderson 2021-07-23 1684 * Returns 0 on success or non-zero on failure -38f492d29e0c25 Allison Henderson 2021-07-23 1685 */ 38f492d29e0c25 Allison Henderson 2021-07-23 1686 STATIC int 38f492d29e0c25 Allison Henderson 2021-07-23 1687 xfs_ioc_get_parent_pointer( 38f492d29e0c25 Allison Henderson 2021-07-23 1688 struct file *filp, @@ -98,13 +80,23 @@ vim +1753 fs/xfs/xfs_ioctl.c 38f492d29e0c25 Allison Henderson 2021-07-23 1747 XFS_PPTR_INFO_SIZEOF(ppi->pi_ptrs_size)); 38f492d29e0c25 Allison Henderson 2021-07-23 1748 if (error) 38f492d29e0c25 Allison Henderson 2021-07-23 1749 goto out; + +This should be + + if (copy_to_user(arg, ppi, XFS_PPTR_INFO_SIZEOF(ppi->pi_ptrs_size))) { + err = -EFAULT; + goto out; + } + 38f492d29e0c25 Allison Henderson 2021-07-23 1750 38f492d29e0c25 Allison Henderson 2021-07-23 1751 out: 38f492d29e0c25 Allison Henderson 2021-07-23 1752 kmem_free(ppi); 38f492d29e0c25 Allison Henderson 2021-07-23 @1753 return error; 38f492d29e0c25 Allison Henderson 2021-07-23 1754 } -38f492d29e0c25 Allison Henderson 2021-07-23 1755 --- 0-DAY CI Kernel Test Service, Intel Corporation -https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org +https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org +_______________________________________________ +kbuild mailing list -- kbuild(a)lists.01.org +To unsubscribe send an email to kbuild-leave(a)lists.01.org diff --git a/a/content_digest b/N1/content_digest index 13eb1c3..edf7458 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,19 +1,13 @@ - "From\0kernel test robot <lkp@intel.com>\0" - "Subject\0[allisonhenderson-xfs-work:delayed_attrs_v26_extended 28/30] fs/xfs/xfs_ioctl.c:1753 xfs_ioc_get_parent_pointer() warn: maybe return -EFAULT instead of the bytes remaining?\0" - "Date\0Tue, 25 Jan 2022 08:26:31 +0800\0" - "To\0kbuild@lists.01.org\0" + "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" + "Subject\0[kbuild] [allisonhenderson-xfs-work:delayed_attrs_v26_extended 28/30] fs/xfs/xfs_ioctl.c:1753 xfs_ioc_get_parent_pointer() warn: maybe return -EFAULT instead of the bytes remaining?\0" + "Date\0Tue, 25 Jan 2022 12:23:34 +0300\0" + "To\0kbuild-all@lists.01.org\0" "\01:1\0" "b\0" - "CC: kbuild-all(a)lists.01.org\n" - "CC: linux-kernel(a)vger.kernel.org\n" - "TO: Allison Henderson <allison.henderson@oracle.com>\n" - "\n" - "tree: https://github.com/allisonhenderson/xfs_work.git delayed_attrs_v26_extended\n" + "tree: https://github.com/allisonhenderson/xfs_work.git delayed_attrs_v26_extended\n" "head: 19459f5cfa422b0a6a9cd3898892e43ecb49f8f3\n" "commit: 38f492d29e0c25066170d87572b7ade7bf2af72b [28/30] xfs: Add parent pointer ioctl\n" - ":::::: branch date: 29 hours ago\n" - ":::::: commit date: 29 hours ago\n" - "config: nios2-randconfig-m031-20220124 (https://download.01.org/0day-ci/archive/20220125/202201250715.EbP8D1XT-lkp(a)intel.com/config)\n" + "config: nios2-randconfig-m031-20220124 (https://download.01.org/0day-ci/archive/20220125/202201250715.EbP8D1XT-lkp(a)intel.com/config )\n" "compiler: nios2-linux-gcc (GCC) 11.2.0\n" "\n" "If you fix the issue, kindly add following tag as appropriate\n" @@ -28,18 +22,6 @@ "\n" "vim +1753 fs/xfs/xfs_ioctl.c\n" "\n" - "36fd6e863cb732 Darrick J. Wong 2017-10-17 1674 \n" - "38f492d29e0c25 Allison Henderson 2021-07-23 1675 /*\n" - "38f492d29e0c25 Allison Henderson 2021-07-23 1676 * IOCTL routine to get the parent pointers of an inode and return it to user\n" - "38f492d29e0c25 Allison Henderson 2021-07-23 1677 * space. Caller must pass a buffer space containing a struct xfs_pptr_info,\n" - "38f492d29e0c25 Allison Henderson 2021-07-23 1678 * followed by a region large enough to contain an array of struct\n" - "38f492d29e0c25 Allison Henderson 2021-07-23 1679 * xfs_parent_ptr of a size specified in pi_ptrs_size. If the inode contains\n" - "38f492d29e0c25 Allison Henderson 2021-07-23 1680 * more parent pointers than can fit in the buffer space, caller may re-call\n" - "38f492d29e0c25 Allison Henderson 2021-07-23 1681 * the function using the returned pi_cursor to resume iteration. The\n" - "38f492d29e0c25 Allison Henderson 2021-07-23 1682 * number of xfs_parent_ptr returned will be stored in pi_ptrs_used.\n" - "38f492d29e0c25 Allison Henderson 2021-07-23 1683 *\n" - "38f492d29e0c25 Allison Henderson 2021-07-23 1684 * Returns 0 on success or non-zero on failure\n" - "38f492d29e0c25 Allison Henderson 2021-07-23 1685 */\n" "38f492d29e0c25 Allison Henderson 2021-07-23 1686 STATIC int\n" "38f492d29e0c25 Allison Henderson 2021-07-23 1687 xfs_ioc_get_parent_pointer(\n" "38f492d29e0c25 Allison Henderson 2021-07-23 1688 \tstruct file\t\t\t*filp,\n" @@ -104,15 +86,25 @@ "38f492d29e0c25 Allison Henderson 2021-07-23 1747 \t\t\tXFS_PPTR_INFO_SIZEOF(ppi->pi_ptrs_size));\n" "38f492d29e0c25 Allison Henderson 2021-07-23 1748 \tif (error)\n" "38f492d29e0c25 Allison Henderson 2021-07-23 1749 \t\tgoto out;\n" + "\n" + "This should be\n" + "\n" + "\tif (copy_to_user(arg, ppi, XFS_PPTR_INFO_SIZEOF(ppi->pi_ptrs_size))) {\n" + "\t\terr = -EFAULT;\n" + "\t\tgoto out;\n" + "\t}\n" + "\n" "38f492d29e0c25 Allison Henderson 2021-07-23 1750 \n" "38f492d29e0c25 Allison Henderson 2021-07-23 1751 out:\n" "38f492d29e0c25 Allison Henderson 2021-07-23 1752 \tkmem_free(ppi);\n" "38f492d29e0c25 Allison Henderson 2021-07-23 @1753 \treturn error;\n" "38f492d29e0c25 Allison Henderson 2021-07-23 1754 }\n" - "38f492d29e0c25 Allison Henderson 2021-07-23 1755 \n" "\n" "---\n" "0-DAY CI Kernel Test Service, Intel Corporation\n" - https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org + "https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org \n" + "_______________________________________________\n" + "kbuild mailing list -- kbuild(a)lists.01.org\n" + To unsubscribe send an email to kbuild-leave(a)lists.01.org -270c225334b601d4b5fbc7acd12825f937c078f8c85504612e4329a1f62005ad +4415d6cf6519ce80b50b5d61610d354a7df0d4da6c1a7cfa42308f9e075789d0
diff --git a/a/1.txt b/N2/1.txt index 958646e..d993da9 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,13 +1,7 @@ -CC: kbuild-all(a)lists.01.org -CC: linux-kernel(a)vger.kernel.org -TO: Allison Henderson <allison.henderson@oracle.com> - -tree: https://github.com/allisonhenderson/xfs_work.git delayed_attrs_v26_extended +tree: https://github.com/allisonhenderson/xfs_work.git delayed_attrs_v26_extended head: 19459f5cfa422b0a6a9cd3898892e43ecb49f8f3 commit: 38f492d29e0c25066170d87572b7ade7bf2af72b [28/30] xfs: Add parent pointer ioctl -:::::: branch date: 29 hours ago -:::::: commit date: 29 hours ago -config: nios2-randconfig-m031-20220124 (https://download.01.org/0day-ci/archive/20220125/202201250715.EbP8D1XT-lkp(a)intel.com/config) +config: nios2-randconfig-m031-20220124 (https://download.01.org/0day-ci/archive/20220125/202201250715.EbP8D1XT-lkp@intel.com/config ) compiler: nios2-linux-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate @@ -22,18 +16,6 @@ arch/nios2/include/asm/thread_info.h:71 current_thread_info() error: uninitializ vim +1753 fs/xfs/xfs_ioctl.c -36fd6e863cb732 Darrick J. Wong 2017-10-17 1674 -38f492d29e0c25 Allison Henderson 2021-07-23 1675 /* -38f492d29e0c25 Allison Henderson 2021-07-23 1676 * IOCTL routine to get the parent pointers of an inode and return it to user -38f492d29e0c25 Allison Henderson 2021-07-23 1677 * space. Caller must pass a buffer space containing a struct xfs_pptr_info, -38f492d29e0c25 Allison Henderson 2021-07-23 1678 * followed by a region large enough to contain an array of struct -38f492d29e0c25 Allison Henderson 2021-07-23 1679 * xfs_parent_ptr of a size specified in pi_ptrs_size. If the inode contains -38f492d29e0c25 Allison Henderson 2021-07-23 1680 * more parent pointers than can fit in the buffer space, caller may re-call -38f492d29e0c25 Allison Henderson 2021-07-23 1681 * the function using the returned pi_cursor to resume iteration. The -38f492d29e0c25 Allison Henderson 2021-07-23 1682 * number of xfs_parent_ptr returned will be stored in pi_ptrs_used. -38f492d29e0c25 Allison Henderson 2021-07-23 1683 * -38f492d29e0c25 Allison Henderson 2021-07-23 1684 * Returns 0 on success or non-zero on failure -38f492d29e0c25 Allison Henderson 2021-07-23 1685 */ 38f492d29e0c25 Allison Henderson 2021-07-23 1686 STATIC int 38f492d29e0c25 Allison Henderson 2021-07-23 1687 xfs_ioc_get_parent_pointer( 38f492d29e0c25 Allison Henderson 2021-07-23 1688 struct file *filp, @@ -98,13 +80,23 @@ vim +1753 fs/xfs/xfs_ioctl.c 38f492d29e0c25 Allison Henderson 2021-07-23 1747 XFS_PPTR_INFO_SIZEOF(ppi->pi_ptrs_size)); 38f492d29e0c25 Allison Henderson 2021-07-23 1748 if (error) 38f492d29e0c25 Allison Henderson 2021-07-23 1749 goto out; + +This should be + + if (copy_to_user(arg, ppi, XFS_PPTR_INFO_SIZEOF(ppi->pi_ptrs_size))) { + err = -EFAULT; + goto out; + } + 38f492d29e0c25 Allison Henderson 2021-07-23 1750 38f492d29e0c25 Allison Henderson 2021-07-23 1751 out: 38f492d29e0c25 Allison Henderson 2021-07-23 1752 kmem_free(ppi); 38f492d29e0c25 Allison Henderson 2021-07-23 @1753 return error; 38f492d29e0c25 Allison Henderson 2021-07-23 1754 } -38f492d29e0c25 Allison Henderson 2021-07-23 1755 --- 0-DAY CI Kernel Test Service, Intel Corporation -https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org +https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org +_______________________________________________ +kbuild mailing list -- kbuild@lists.01.org +To unsubscribe send an email to kbuild-leave@lists.01.org diff --git a/a/content_digest b/N2/content_digest index 13eb1c3..32cb370 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,19 +1,17 @@ - "From\0kernel test robot <lkp@intel.com>\0" - "Subject\0[allisonhenderson-xfs-work:delayed_attrs_v26_extended 28/30] fs/xfs/xfs_ioctl.c:1753 xfs_ioc_get_parent_pointer() warn: maybe return -EFAULT instead of the bytes remaining?\0" - "Date\0Tue, 25 Jan 2022 08:26:31 +0800\0" - "To\0kbuild@lists.01.org\0" - "\01:1\0" + "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" + "Subject\0[kbuild] [allisonhenderson-xfs-work:delayed_attrs_v26_extended 28/30] fs/xfs/xfs_ioctl.c:1753 xfs_ioc_get_parent_pointer() warn: maybe return -EFAULT instead of the bytes remaining?\0" + "Date\0Tue, 25 Jan 2022 12:23:34 +0300\0" + "To\0kbuild@lists.01.org" + " Allison Henderson <allison.henderson@oracle.com>\0" + "Cc\0lkp@intel.com" + kbuild-all@lists.01.org + " linux-kernel@vger.kernel.org\0" + "\00:1\0" "b\0" - "CC: kbuild-all(a)lists.01.org\n" - "CC: linux-kernel(a)vger.kernel.org\n" - "TO: Allison Henderson <allison.henderson@oracle.com>\n" - "\n" - "tree: https://github.com/allisonhenderson/xfs_work.git delayed_attrs_v26_extended\n" + "tree: https://github.com/allisonhenderson/xfs_work.git delayed_attrs_v26_extended\n" "head: 19459f5cfa422b0a6a9cd3898892e43ecb49f8f3\n" "commit: 38f492d29e0c25066170d87572b7ade7bf2af72b [28/30] xfs: Add parent pointer ioctl\n" - ":::::: branch date: 29 hours ago\n" - ":::::: commit date: 29 hours ago\n" - "config: nios2-randconfig-m031-20220124 (https://download.01.org/0day-ci/archive/20220125/202201250715.EbP8D1XT-lkp(a)intel.com/config)\n" + "config: nios2-randconfig-m031-20220124 (https://download.01.org/0day-ci/archive/20220125/202201250715.EbP8D1XT-lkp@intel.com/config )\n" "compiler: nios2-linux-gcc (GCC) 11.2.0\n" "\n" "If you fix the issue, kindly add following tag as appropriate\n" @@ -28,18 +26,6 @@ "\n" "vim +1753 fs/xfs/xfs_ioctl.c\n" "\n" - "36fd6e863cb732 Darrick J. Wong 2017-10-17 1674 \n" - "38f492d29e0c25 Allison Henderson 2021-07-23 1675 /*\n" - "38f492d29e0c25 Allison Henderson 2021-07-23 1676 * IOCTL routine to get the parent pointers of an inode and return it to user\n" - "38f492d29e0c25 Allison Henderson 2021-07-23 1677 * space. Caller must pass a buffer space containing a struct xfs_pptr_info,\n" - "38f492d29e0c25 Allison Henderson 2021-07-23 1678 * followed by a region large enough to contain an array of struct\n" - "38f492d29e0c25 Allison Henderson 2021-07-23 1679 * xfs_parent_ptr of a size specified in pi_ptrs_size. If the inode contains\n" - "38f492d29e0c25 Allison Henderson 2021-07-23 1680 * more parent pointers than can fit in the buffer space, caller may re-call\n" - "38f492d29e0c25 Allison Henderson 2021-07-23 1681 * the function using the returned pi_cursor to resume iteration. The\n" - "38f492d29e0c25 Allison Henderson 2021-07-23 1682 * number of xfs_parent_ptr returned will be stored in pi_ptrs_used.\n" - "38f492d29e0c25 Allison Henderson 2021-07-23 1683 *\n" - "38f492d29e0c25 Allison Henderson 2021-07-23 1684 * Returns 0 on success or non-zero on failure\n" - "38f492d29e0c25 Allison Henderson 2021-07-23 1685 */\n" "38f492d29e0c25 Allison Henderson 2021-07-23 1686 STATIC int\n" "38f492d29e0c25 Allison Henderson 2021-07-23 1687 xfs_ioc_get_parent_pointer(\n" "38f492d29e0c25 Allison Henderson 2021-07-23 1688 \tstruct file\t\t\t*filp,\n" @@ -104,15 +90,25 @@ "38f492d29e0c25 Allison Henderson 2021-07-23 1747 \t\t\tXFS_PPTR_INFO_SIZEOF(ppi->pi_ptrs_size));\n" "38f492d29e0c25 Allison Henderson 2021-07-23 1748 \tif (error)\n" "38f492d29e0c25 Allison Henderson 2021-07-23 1749 \t\tgoto out;\n" + "\n" + "This should be\n" + "\n" + "\tif (copy_to_user(arg, ppi, XFS_PPTR_INFO_SIZEOF(ppi->pi_ptrs_size))) {\n" + "\t\terr = -EFAULT;\n" + "\t\tgoto out;\n" + "\t}\n" + "\n" "38f492d29e0c25 Allison Henderson 2021-07-23 1750 \n" "38f492d29e0c25 Allison Henderson 2021-07-23 1751 out:\n" "38f492d29e0c25 Allison Henderson 2021-07-23 1752 \tkmem_free(ppi);\n" "38f492d29e0c25 Allison Henderson 2021-07-23 @1753 \treturn error;\n" "38f492d29e0c25 Allison Henderson 2021-07-23 1754 }\n" - "38f492d29e0c25 Allison Henderson 2021-07-23 1755 \n" "\n" "---\n" "0-DAY CI Kernel Test Service, Intel Corporation\n" - https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org + "https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org \n" + "_______________________________________________\n" + "kbuild mailing list -- kbuild@lists.01.org\n" + To unsubscribe send an email to kbuild-leave@lists.01.org -270c225334b601d4b5fbc7acd12825f937c078f8c85504612e4329a1f62005ad +f9d36781a7f5526cf256537a3c924ec747d22117f4379563b102fd9aaa2285b0
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.