From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1EE99C433FE for ; Fri, 28 Jan 2022 09:28:05 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3CE5416BC; Fri, 28 Jan 2022 10:27:13 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3CE5416BC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1643362083; bh=sq7lSLT317ehgznsg5Cxd/YMQA14YQxyZQ1SejW1pYk=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=E0sHXUVruBOuwf/iwa3flwdBvjxgqNhZpP7zGAY5oVWZ+z9a9T555iM4tm535sLb1 ySu35TFSIA5KW9mvRKlKQzyuclwZUfu7FrO0DdK5nhGRoy16yGjyL4/vnMuubamW1O yO3yjBep863blg3ZHvmwzJWNXAggExsZ8EQHGwOU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 13BBDF8052E; Fri, 28 Jan 2022 10:24:50 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 419FAF80161; Tue, 25 Jan 2022 11:20:12 +0100 (CET) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 23BDBF80161 for ; Tue, 25 Jan 2022 11:20:05 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 23BDBF80161 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id DC28B2000C; Tue, 25 Jan 2022 10:19:29 +0000 (UTC) Date: Tue, 25 Jan 2022 11:19:28 +0100 From: Miquel Raynal To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Subject: Re: [PATCH 5/5] spi: make remove callback a void function Message-ID: <20220125111928.781d0bb3@xps13> In-Reply-To: <20220123175201.34839-6-u.kleine-koenig@pengutronix.de> References: <20220123175201.34839-1-u.kleine-koenig@pengutronix.de> <20220123175201.34839-6-u.kleine-koenig@pengutronix.de> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Fri, 28 Jan 2022 10:24:41 +0100 Cc: Andrew Lunn , Gwendal Grignou , Yasunari Takiguchi , Claudius Heine , Geert Uytterhoeven , Nanyong Sun , Linus Walleij , dri-devel@lists.freedesktop.org, Frieder Schrempf , Pavel Machek , Matt Kline , Christian Lamparter , Ajay Singh , linux-clk@vger.kernel.org, Stefan Schmidt , Sidong Yang , libertas-dev@lists.infradead.org, linux-omap@vger.kernel.org, Antti Palosaari , Guenter Roeck , Jean Delvare , linux-serial@vger.kernel.org, =?UTF-8?B?xYF1?= =?UTF-8?B?a2Fzeg==?= Stelmach , Mark Tomlinson , James Schulman , Kamlesh Gurudasani , Jingoo Han , Zhang Qilong , Randy Dunlap , linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Michael Walle , Noralf =?UTF-8?B?VHLDuG5uZXM=?= , kernel@pengutronix.de, Greg Kroah-Hartman , linux-mtd@lists.infradead.org, Andrew Morton , Vladimir Oltean , linux-wpan@vger.kernel.org, Claudiu Beznea , Alexandre Belloni , Dan Robertson , Markuss Broks , Lucas Tanure , David Airlie , linux-wireless@vger.kernel.org, Marco Felsch , David Rhodes , Thierry Reding , Solomon Peachy , Marek =?UTF-8?B?QmVow7pu?= , Lars-Peter Clausen , Krzysztof Kozlowski , Emmanuel Gil Peyrot , Jiri Slaby , Helge Deller , Tudor Ambarus , Minghao Chi , Jon Hunter , dingsenjie , Heiko Schocher , Wolfgang Grandegger , linux-media@vger.kernel.org, Woojung Huh , Charles Keepax , Michael Hennerich , Mike Looijmans , Ronald =?UTF-8?B?VHNjaGFsw6Ry?= , Daniel Thompson , Maxime Ripard , linux-can@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Hans de Goede , Stephen Boyd , Davidlohr Bueso , UNGLinuxDriver@microchip.com, Jarkko Sakkinen , linux-usb@vger.kernel.org, Maxime Coquelin , linux-integrity@vger.kernel.org, Jonathan Cameron , Heiner Kallweit , Ulf Hansson , linux-staging@lists.linux.dev, linux-iio@vger.kernel.org, Michael Turquette , alsa-devel@alsa-project.org, Nuno =?UTF-8?B?U8Oh?= , netdev@vger.kernel.org, Wei Yongjun , Sam Ravnborg , =?UTF-8?B?SsOpcsO0bWU=?= Pouiller , linux-rtc@vger.kernel.org, Marcus Folkesson , Florian Fainelli , Aditya Srivastava , Varka Bhadram , wengjianfeng , linux-input@vger.kernel.org, Arnd Bergmann , Jonathan =?UTF-8?B?TmV1c2Now6RmZXI=?= , Mark Greer , Mark Gross , Richard Fitzgerald , Mark Brown , linux-fbdev@vger.kernel.org, Mauro Carvalho Chehab , Benson Leung , Stefan =?UTF-8?B?TcOkdGpl?= , linux-hwmon@vger.kernel.org, Felipe Balbi , Paulo Miguel Almeida , Support Opensource , Dmitry Torokhov , linux-mmc@vger.kernel.org, Liam Girdwood , Julia Lawall , Yang Li , Dan Carpenter , patches@opensource.cirrus.com, Kent Gustavsson , "David S. Miller" , Charles-Antoine Couret , Alexander Aring , Jiri Prchal , Vignesh Raghavendra , Emma Anholt , Peter Zijlstra , Alexandre Torgue , Alexandru Ardelean , Antoniu Miclaus , Peter Huewe , Torin Cooper-Bennun , Lee Jones , linux-leds@vger.kernel.org, Eric Piel , Stephan Gerhold , Richard Weinberger , Russell King , Jason Gunthorpe , Thomas Kopp , Jakub Kicinski , Vivien Didelot , platform-driver-x86@vger.kernel.org, Stefan Wahren , Xue Liu , David Lechner , Will Deacon , Manivannan Sadhasivam , Kalle Valo , Rui Miguel Silva , Marc Kleine-Budde , Fabio Estevam , Harry Morris , Andy Shevchenko , Vincent Mailhol , Alessandro Zummo , Yang Shen , Thomas Zimmermann , Takashi Iwai , Cai Huoqing , Daniel Mack , Daniel Vetter , Colin Ian King , Bartosz Golaszewski , Alan Ott X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Uwe, u.kleine-koenig@pengutronix.de wrote on Sun, 23 Jan 2022 18:52:01 +0100: > The value returned by an spi driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) >=20 > So change the prototype of the remove function to return no value. This > way driver authors are not tempted to assume that passing an error to > the upper layer is a good idea. All drivers are adapted accordingly. > There is no intended change of behaviour, all callbacks were prepared to > return 0 before. >=20 > Signed-off-by: Uwe Kleine-K=C3=B6nig > --- [...] > drivers/mtd/devices/mchp23k256.c | 4 +--- > drivers/mtd/devices/mchp48l640.c | 4 +--- > drivers/mtd/devices/mtd_dataflash.c | 4 +--- > drivers/mtd/devices/sst25l.c | 4 +--- For MTD devices: Acked-by: Miquel Raynal Thanks, Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06FE3C4321E for ; Tue, 25 Jan 2022 10:24:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349621AbiAYKX7 convert rfc822-to-8bit (ORCPT ); Tue, 25 Jan 2022 05:23:59 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:33293 "EHLO relay7-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243263AbiAYKUa (ORCPT ); Tue, 25 Jan 2022 05:20:30 -0500 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id DC28B2000C; Tue, 25 Jan 2022 10:19:29 +0000 (UTC) Date: Tue, 25 Jan 2022 11:19:28 +0100 From: Miquel Raynal To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Cc: Mark Brown , Marek =?UTF-8?B?QmVow7pu?= , Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , Michael Turquette , Stephen Boyd , Linus Walleij , Bartosz Golaszewski , Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Markuss Broks , Emma Anholt , David Lechner , Kamlesh Gurudasani , Noralf =?UTF-8?B?VHLDuG5uZXM=?= , Jean Delvare , Guenter Roeck , Dan Robertson , Jonathan Cameron , Lars-Peter Clausen , Michael Hennerich , Marcus Folkesson , Kent Gustavsson , Rui Miguel Silva , Dmitry Torokhov , Pavel Machek , Yasunari Takiguchi , Mauro Carvalho Chehab , Charles-Antoine Couret , Antti Palosaari , Lee Jones , Support Opensource , Charles Keepax , Richard Fitzgerald , Maxime Coquelin , Alexandre Torgue , Arnd Bergmann , Greg Kroah-Hartman , Eric Piel , Ulf Hansson , Richard Weinberger , Vignesh Raghavendra , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Jakub Kicinski , Manivannan Sadhasivam , Thomas Kopp , Florian Fainelli , Andrew Lunn , Vivien Didelot , Vladimir Oltean , Woojung Huh , UNGLinuxDriver@microchip.com, =?UTF-8?B?xYF1?= =?UTF-8?B?a2Fzeg==?= Stelmach , Alexander Aring , Stefan Schmidt , Harry Morris , Varka Bhadram , Xue Liu , Alan Ott , Heiner Kallweit , Russell King , Christian Lamparter , Kalle Valo , Ajay Singh , Claudiu Beznea , Solomon Peachy , Krzysztof Kozlowski , Mark Greer , Benson Leung , Hans de Goede , Mark Gross , Alessandro Zummo , Alexandre Belloni , =?UTF-8?B?SsOpcsO0bWU=?= Pouiller , Jiri Slaby , Felipe Balbi , Daniel Thompson , Jingoo Han , Helge Deller , James Schulman , David Rhodes , Lucas Tanure , Jaroslav Kysela , Takashi Iwai , Nuno =?UTF-8?B?U8Oh?= , Liam Girdwood , Daniel Mack , Thomas Zimmermann , Maxime Ripard , Andy Shevchenko , Stephan Gerhold , Alexandru Ardelean , Mike Looijmans , Gwendal Grignou , Cai Huoqing , Minghao Chi , Antoniu Miclaus , Julia Lawall , Ronald =?UTF-8?B?VHNjaGFsw6Ry?= , Marco Felsch , Jonathan =?UTF-8?B?TmV1c2Now6RmZXI=?= , Emmanuel Gil Peyrot , Jon Hunter , Andrew Morton , Heiko Schocher , Fabio Estevam , Colin Ian King , Dan Carpenter , Tudor Ambarus , Matt Kline , Torin Cooper-Bennun , Vincent Mailhol , Stefan =?UTF-8?B?TcOkdGpl?= , Frieder Schrempf , Wei Yongjun , Randy Dunlap , Nanyong Sun , Yang Shen , dingsenjie , Aditya Srivastava , Stefan Wahren , Peter Zijlstra , Michael Walle , Yang Li , Geert Uytterhoeven , wengjianfeng , Sidong Yang , Paulo Miguel Almeida , Zhang Qilong , Will Deacon , Mark Tomlinson , Davidlohr Bueso , Claudius Heine , Jiri Prchal , linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-media@vger.kernel.org, patches@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-wpan@vger.kernel.org, linux-wireless@vger.kernel.org, libertas-dev@lists.infradead.org, platform-driver-x86@vger.kernel.org, linux-rtc@vger.kernel.org, linux-spi@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 5/5] spi: make remove callback a void function Message-ID: <20220125111928.781d0bb3@xps13> In-Reply-To: <20220123175201.34839-6-u.kleine-koenig@pengutronix.de> References: <20220123175201.34839-1-u.kleine-koenig@pengutronix.de> <20220123175201.34839-6-u.kleine-koenig@pengutronix.de> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org Hi Uwe, u.kleine-koenig@pengutronix.de wrote on Sun, 23 Jan 2022 18:52:01 +0100: > The value returned by an spi driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) > > So change the prototype of the remove function to return no value. This > way driver authors are not tempted to assume that passing an error to > the upper layer is a good idea. All drivers are adapted accordingly. > There is no intended change of behaviour, all callbacks were prepared to > return 0 before. > > Signed-off-by: Uwe Kleine-König > --- [...] > drivers/mtd/devices/mchp23k256.c | 4 +--- > drivers/mtd/devices/mchp48l640.c | 4 +--- > drivers/mtd/devices/mtd_dataflash.c | 4 +--- > drivers/mtd/devices/sst25l.c | 4 +--- For MTD devices: Acked-by: Miquel Raynal Thanks, Miquèl From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1D99C433F5 for ; Tue, 25 Jan 2022 10:21:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YY8Y2Ok+jIz4/R8VMySxt6724VLwpsYH1XbLVKF/yws=; b=A0EIm8OjWTwKDa qY7Wb4WAxVsh9iqcZVswf5iEb66ovcK/MU/aV6cQMjKu9uZk5dcMKO0IuGhp2PCZ00W4AdnzDFesH 75IoK91FhGyRt3GQMbeO5Of+mvMHR7F84eJAOVJiXshosmWIBsXyz3sdT+K8Vxi9yDy3kmeXYGSmJ p3S41EWFjmPn7ewgRuSP6nE5N7X1mkJAAw+R3QiIBG3D+PfDn1zOMp/rA9KyXeausJ66t8M7fNyFQ NMfq3FoinFyIY0ekI8ebglYxDqwhB8yqu73Z551GymZe0tP5tOwRVuZR106JVCIu7QKmRjXng6qPe JosdTgfeuLl7kGPM22yQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCIvv-007PL4-DX; Tue, 25 Jan 2022 10:20:15 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCIvp-007PJ0-5d; Tue, 25 Jan 2022 10:20:11 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id DC28B2000C; Tue, 25 Jan 2022 10:19:29 +0000 (UTC) Date: Tue, 25 Jan 2022 11:19:28 +0100 From: Miquel Raynal To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Cc: Mark Brown , Marek =?UTF-8?B?QmVow7pu?= , Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , Michael Turquette , Stephen Boyd , Linus Walleij , Bartosz Golaszewski , Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Markuss Broks , Emma Anholt , David Lechner , Kamlesh Gurudasani , Noralf =?UTF-8?B?VHLDuG5uZXM=?= , Jean Delvare , Guenter Roeck , Dan Robertson , Jonathan Cameron , Lars-Peter Clausen , Michael Hennerich , Marcus Folkesson , Kent Gustavsson , Rui Miguel Silva , Dmitry Torokhov , Pavel Machek , Yasunari Takiguchi , Mauro Carvalho Chehab , Charles-Antoine Couret , Antti Palosaari , Lee Jones , Support Opensource , Charles Keepax , Richard Fitzgerald , Maxime Coquelin , Alexandre Torgue , Arnd Bergmann , Greg Kroah-Hartman , Eric Piel , Ulf Hansson , Richard Weinberger , Vignesh Raghavendra , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Jakub Kicinski , Manivannan Sadhasivam , Thomas Kopp , Florian Fainelli , Andrew Lunn , Vivien Didelot , Vladimir Oltean , Woojung Huh , UNGLinuxDriver@microchip.com, =?UTF-8?B?xYF1?= =?UTF-8?B?a2Fzeg==?= Stelmach , Alexander Aring , Stefan Schmidt , Harry Morris , Varka Bhadram , Xue Liu , Alan Ott , Heiner Kallweit , Russell King , Christian Lamparter , Kalle Valo , Ajay Singh , Claudiu Beznea , Solomon Peachy , Krzysztof Kozlowski , Mark Greer , Benson Leung , Hans de Goede , Mark Gross , Alessandro Zummo , Alexandre Belloni , =?UTF-8?B?SsOpcsO0bWU=?= Pouiller , Jiri Slaby , Felipe Balbi , Daniel Thompson , Jingoo Han , Helge Deller , James Schulman , David Rhodes , Lucas Tanure , Jaroslav Kysela , Takashi Iwai , Nuno =?UTF-8?B?U8Oh?= , Liam Girdwood , Daniel Mack , Thomas Zimmermann , Maxime Ripard , Andy Shevchenko , Stephan Gerhold , Alexandru Ardelean , Mike Looijmans , Gwendal Grignou , Cai Huoqing , Minghao Chi , Antoniu Miclaus , Julia Lawall , Ronald =?UTF-8?B?VHNjaGFsw6Ry?= , Marco Felsch , Jonathan =?UTF-8?B?TmV1c2Now6RmZXI=?= , Emmanuel Gil Peyrot , Jon Hunter , Andrew Morton , Heiko Schocher , Fabio Estevam , Colin Ian King , Dan Carpenter , Tudor Ambarus , Matt Kline , Torin Cooper-Bennun , Vincent Mailhol , Stefan =?UTF-8?B?TcOkdGpl?= , Frieder Schrempf , Wei Yongjun , Randy Dunlap , Nanyong Sun , Yang Shen , dingsenjie , Aditya Srivastava , Stefan Wahren , Peter Zijlstra , Michael Walle , Yang Li , Geert Uytterhoeven , wengjianfeng , Sidong Yang , Paulo Miguel Almeida , Zhang Qilong , Will Deacon , Mark Tomlinson , Davidlohr Bueso , Claudius Heine , Jiri Prchal , linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-media@vger.kernel.org, patches@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-wpan@vger.kernel.org, linux-wireless@vger.kernel.org, libertas-dev@lists.infradead.org, platform-driver-x86@vger.kernel.org, linux-rtc@vger.kernel.org, linux-spi@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 5/5] spi: make remove callback a void function Message-ID: <20220125111928.781d0bb3@xps13> In-Reply-To: <20220123175201.34839-6-u.kleine-koenig@pengutronix.de> References: <20220123175201.34839-1-u.kleine-koenig@pengutronix.de> <20220123175201.34839-6-u.kleine-koenig@pengutronix.de> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220125_022009_540650_20F58135 X-CRM114-Status: GOOD ( 17.89 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgVXdlLAoKdS5rbGVpbmUta29lbmlnQHBlbmd1dHJvbml4LmRlIHdyb3RlIG9uIFN1biwgMjMg SmFuIDIwMjIgMTg6NTI6MDEgKzAxMDA6Cgo+IFRoZSB2YWx1ZSByZXR1cm5lZCBieSBhbiBzcGkg ZHJpdmVyJ3MgcmVtb3ZlIGZ1bmN0aW9uIGlzIG1vc3RseSBpZ25vcmVkLgo+IChPbmx5IGFuIGVy cm9yIG1lc3NhZ2UgaXMgcHJpbnRlZCBpZiB0aGUgdmFsdWUgaXMgbm9uLXplcm8gdGhhdCB0aGUK PiBlcnJvciBpcyBpZ25vcmVkLikKPiAKPiBTbyBjaGFuZ2UgdGhlIHByb3RvdHlwZSBvZiB0aGUg cmVtb3ZlIGZ1bmN0aW9uIHRvIHJldHVybiBubyB2YWx1ZS4gVGhpcwo+IHdheSBkcml2ZXIgYXV0 aG9ycyBhcmUgbm90IHRlbXB0ZWQgdG8gYXNzdW1lIHRoYXQgcGFzc2luZyBhbiBlcnJvciB0bwo+ IHRoZSB1cHBlciBsYXllciBpcyBhIGdvb2QgaWRlYS4gQWxsIGRyaXZlcnMgYXJlIGFkYXB0ZWQg YWNjb3JkaW5nbHkuCj4gVGhlcmUgaXMgbm8gaW50ZW5kZWQgY2hhbmdlIG9mIGJlaGF2aW91ciwg YWxsIGNhbGxiYWNrcyB3ZXJlIHByZXBhcmVkIHRvCj4gcmV0dXJuIDAgYmVmb3JlLgo+IAo+IFNp Z25lZC1vZmYtYnk6IFV3ZSBLbGVpbmUtS8O2bmlnIDx1LmtsZWluZS1rb2VuaWdAcGVuZ3V0cm9u aXguZGU+Cj4gLS0tCgpbLi4uXQoKPiAgZHJpdmVycy9tdGQvZGV2aWNlcy9tY2hwMjNrMjU2LmMg ICAgICAgICAgICAgICAgICAgICAgfCAgNCArLS0tCj4gIGRyaXZlcnMvbXRkL2RldmljZXMvbWNo cDQ4bDY0MC5jICAgICAgICAgICAgICAgICAgICAgIHwgIDQgKy0tLQo+ICBkcml2ZXJzL210ZC9k ZXZpY2VzL210ZF9kYXRhZmxhc2guYyAgICAgICAgICAgICAgICAgICB8ICA0ICstLS0KPiAgZHJp dmVycy9tdGQvZGV2aWNlcy9zc3QyNWwuYyAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgNCAr LS0tCgpGb3IgTVREIGRldmljZXM6CkFja2VkLWJ5OiBNaXF1ZWwgUmF5bmFsIDxtaXF1ZWwucmF5 bmFsQGJvb3RsaW4uY29tPgoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFp bGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 325F1C28CF5 for ; Wed, 26 Jan 2022 08:35:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3563E10E7BC; Wed, 26 Jan 2022 08:35:33 +0000 (UTC) X-Greylist: delayed 718 seconds by postgrey-1.36 at gabe; Tue, 25 Jan 2022 10:32:08 UTC Received: from mslow1.mail.gandi.net (mslow1.mail.gandi.net [IPv6:2001:4b98:dc4:8::240]) by gabe.freedesktop.org (Postfix) with ESMTPS id 288B410F1C4 for ; Tue, 25 Jan 2022 10:32:08 +0000 (UTC) Received: from relay7-d.mail.gandi.net (unknown [217.70.183.200]) by mslow1.mail.gandi.net (Postfix) with ESMTP id BC624C2E30 for ; Tue, 25 Jan 2022 10:20:10 +0000 (UTC) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id DC28B2000C; Tue, 25 Jan 2022 10:19:29 +0000 (UTC) Date: Tue, 25 Jan 2022 11:19:28 +0100 From: Miquel Raynal To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Subject: Re: [PATCH 5/5] spi: make remove callback a void function Message-ID: <20220125111928.781d0bb3@xps13> In-Reply-To: <20220123175201.34839-6-u.kleine-koenig@pengutronix.de> References: <20220123175201.34839-1-u.kleine-koenig@pengutronix.de> <20220123175201.34839-6-u.kleine-koenig@pengutronix.de> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Wed, 26 Jan 2022 08:35:29 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Gwendal Grignou , Yasunari Takiguchi , Claudius Heine , Geert Uytterhoeven , Nanyong Sun , dri-devel@lists.freedesktop.org, Jaroslav Kysela , Frieder Schrempf , Pavel Machek , Matt Kline , Christian Lamparter , Ajay Singh , linux-clk@vger.kernel.org, Stefan Schmidt , Sidong Yang , libertas-dev@lists.infradead.org, linux-omap@vger.kernel.org, Guenter Roeck , Jean Delvare , linux-serial@vger.kernel.org, =?UTF-8?B?xYF1?= =?UTF-8?B?a2Fzeg==?= Stelmach , Mark Tomlinson , James Schulman , Kamlesh Gurudasani , Jingoo Han , Zhang Qilong , Randy Dunlap , linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Michael Walle , Noralf =?UTF-8?B?VHLDuG5uZXM=?= , kernel@pengutronix.de, Greg Kroah-Hartman , linux-mtd@lists.infradead.org, Andrew Morton , Vladimir Oltean , linux-wpan@vger.kernel.org, Claudiu Beznea , Alexandre Belloni , Dan Robertson , Markuss Broks , Lucas Tanure , David Airlie , linux-wireless@vger.kernel.org, Marco Felsch , David Rhodes , Thierry Reding , Solomon Peachy , Marek =?UTF-8?B?QmVow7pu?= , Krzysztof Kozlowski , Emmanuel Gil Peyrot , Jiri Slaby , Helge Deller , Tudor Ambarus , Minghao Chi , Jon Hunter , dingsenjie , Heiko Schocher , Wolfgang Grandegger , linux-media@vger.kernel.org, Woojung Huh , Charles Keepax , Michael Hennerich , Mike Looijmans , Ronald =?UTF-8?B?VHNjaGFsw6Ry?= , Daniel Thompson , linux-can@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Hans de Goede , Stephen Boyd , Davidlohr Bueso , UNGLinuxDriver@microchip.com, Jarkko Sakkinen , linux-usb@vger.kernel.org, Maxime Coquelin , linux-integrity@vger.kernel.org, Jonathan Cameron , Heiner Kallweit , Ulf Hansson , linux-staging@lists.linux.dev, linux-iio@vger.kernel.org, Michael Turquette , alsa-devel@alsa-project.org, Nuno =?UTF-8?B?U8Oh?= , netdev@vger.kernel.org, Wei Yongjun , Sam Ravnborg , =?UTF-8?B?SsOpcsO0bWU=?= Pouiller , linux-rtc@vger.kernel.org, Marcus Folkesson , Florian Fainelli , Aditya Srivastava , Varka Bhadram , wengjianfeng , linux-input@vger.kernel.org, Arnd Bergmann , Jonathan =?UTF-8?B?TmV1c2Now6RmZXI=?= , Mark Greer , Mark Gross , Richard Fitzgerald , Mark Brown , linux-fbdev@vger.kernel.org, Mauro Carvalho Chehab , Stefan =?UTF-8?B?TcOkdGpl?= , linux-hwmon@vger.kernel.org, Felipe Balbi , Paulo Miguel Almeida , Support Opensource , Dmitry Torokhov , linux-mmc@vger.kernel.org, Liam Girdwood , Julia Lawall , Yang Li , Dan Carpenter , patches@opensource.cirrus.com, Kent Gustavsson , "David S. Miller" , Charles-Antoine Couret , Alexander Aring , Jiri Prchal , Vignesh Raghavendra , Emma Anholt , Peter Zijlstra , Alexandre Torgue , Alexandru Ardelean , Antoniu Miclaus , Peter Huewe , Torin Cooper-Bennun , Lee Jones , linux-leds@vger.kernel.org, Eric Piel , Stephan Gerhold , Richard Weinberger , Russell King , Jason Gunthorpe , Thomas Kopp , Jakub Kicinski , Vivien Didelot , platform-driver-x86@vger.kernel.org, Stefan Wahren , Xue Liu , David Lechner , Will Deacon , Manivannan Sadhasivam , Kalle Valo , Rui Miguel Silva , Marc Kleine-Budde , Harry Morris , Andy Shevchenko , Vincent Mailhol , Alessandro Zummo , Yang Shen , Thomas Zimmermann , Takashi Iwai , Cai Huoqing , Daniel Mack , Colin Ian King , Bartosz Golaszewski , Alan Ott Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Uwe, u.kleine-koenig@pengutronix.de wrote on Sun, 23 Jan 2022 18:52:01 +0100: > The value returned by an spi driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) >=20 > So change the prototype of the remove function to return no value. This > way driver authors are not tempted to assume that passing an error to > the upper layer is a good idea. All drivers are adapted accordingly. > There is no intended change of behaviour, all callbacks were prepared to > return 0 before. >=20 > Signed-off-by: Uwe Kleine-K=C3=B6nig > --- [...] > drivers/mtd/devices/mchp23k256.c | 4 +--- > drivers/mtd/devices/mchp48l640.c | 4 +--- > drivers/mtd/devices/mtd_dataflash.c | 4 +--- > drivers/mtd/devices/sst25l.c | 4 +--- For MTD devices: Acked-by: Miquel Raynal Thanks, Miqu=C3=A8l