From: Dan Aloni <dan.aloni@vastdata.com>
To: Chuck Lever III <chuck.lever@oracle.com>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] xrpcrdma: add missing error checks in rpcrdma_ep_destroy
Date: Tue, 25 Jan 2022 21:46:56 +0200 [thread overview]
Message-ID: <20220125194656.njd7r22stkrtk6fk@gmail.com> (raw)
In-Reply-To: <48846140-72B7-4B4A-8948-6F35F1670FCD@oracle.com>
On Tue, Jan 25, 2022 at 07:30:05PM +0000, Chuck Lever III wrote:
>
>
> > On Jan 25, 2022, at 2:17 PM, Dan Aloni <dan.aloni@vastdata.com> wrote:
> >
> > These pointers can be non-NULL and contain errors if initialization is
> > aborted early. This is similar to how `__svc_rdma_free` takes care of
> > it.
>
> IIUC the only place that can set these values to an
> ERR_PTR is rpcrdma_ep_create() ? I think I'd rather
> have rpcrdma_ep_create() set the fields to NULL in
> the error cases.
Actually that was my initialization draft but then I saw
`__svc_rdma_free`. Will send over.
> Good catch. I'm afraid to ask how you found this.
Just some adapter entering error state in firmware.
--
Dan Aloni
next prev parent reply other threads:[~2022-01-25 19:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 19:17 [PATCH] xrpcrdma: add missing error checks in rpcrdma_ep_destroy Dan Aloni
2022-01-25 19:30 ` Chuck Lever III
2022-01-25 19:46 ` Dan Aloni [this message]
2022-01-25 20:06 ` [PATCH] xprtrdma: fix pointer derefs in error cases of rpcrdma_ep_create Dan Aloni
2022-01-25 20:08 ` Chuck Lever III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220125194656.njd7r22stkrtk6fk@gmail.com \
--to=dan.aloni@vastdata.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.