From: "Michael S. Tsirkin" <mst@redhat.com>
To: Zhu Lingshan <lingshan.zhu@intel.com>
Cc: netdev@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH V3 0/4] vDPA/ifcvf: implement shared IRQ feature
Date: Wed, 26 Jan 2022 09:14:03 -0500 [thread overview]
Message-ID: <20220126091329-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20220126124912.90205-1-lingshan.zhu@intel.com>
On Wed, Jan 26, 2022 at 08:49:08PM +0800, Zhu Lingshan wrote:
> It has been observed that on some platforms/devices, there may
> not be enough MSI vectors for virtqueues and the config change.
> Under such circumstances, the interrupt sources of a device
> have to share vectors/IRQs.
>
> This series implemented a shared IRQ feature for ifcvf.
>
> Please help review.
Given the history, can you please report which tests
were performed with this patchset? Which configs tested?
Thanks?
> Changes from V2:
> (1) Fix misuse of nvectors(in ifcvf_alloc_vectors return value)(Michael)
> (2) Fix misuse of irq = get_vq_irq() in setup irqbypass(Michael)
> (3) Coding style improvements(Michael)
> (4) Better naming of device shared irq/shared vq irq
>
> Changes from V1:
> (1) Enable config interrupt when only one vector is allocated(Michael)
> (2) Clean vectors/IRQs if failed to request config interrupt
> since config interrupt is a must(Michael)
> (3) Keep local vdpa_ops, disable irq_bypass by setting IRQ = -EINVAL
> for shared IRQ case(Michael)
> (4) Improvements on error messages(Michael)
> (5) Squash functions implementation patches to the callers(Michael)
>
> Zhu Lingshan (4):
> vDPA/ifcvf: implement IO read/write helpers in the header file
> vDPA/ifcvf: implement device MSIX vector allocator
> vhost_vdpa: don't setup irq offloading when irq_num < 0
> vDPA/ifcvf: implement shared IRQ feature
>
> drivers/vdpa/ifcvf/ifcvf_base.c | 67 +++-----
> drivers/vdpa/ifcvf/ifcvf_base.h | 60 +++++++-
> drivers/vdpa/ifcvf/ifcvf_main.c | 260 ++++++++++++++++++++++++++++----
> drivers/vhost/vdpa.c | 4 +
> 4 files changed, 312 insertions(+), 79 deletions(-)
>
> --
> 2.27.0
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
parent reply other threads:[~2022-01-26 14:14 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20220126124912.90205-1-lingshan.zhu@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220126091329-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=lingshan.zhu@intel.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.