Re: [PATCH] ARM: dts: imx: Add missing LVDS decoder on M53Menlo

[Shawn Guo <shawnguo@kernel.org>]

On Wed, Jan 26, 2022 at 01:39:00PM +0100, Marek Vasut wrote:
> On 1/26/22 13:19, Shawn Guo wrote:
> > On Sat, Dec 18, 2021 at 04:25:16PM +0100, Marek Vasut wrote:
> > > The M53Menlo display unit uses an LVDS-to-DPI bridge, TI DS90CF364A.
> > > Describe this bridge in DT, otherwise the DT incorrectly describes
> > > DPI panel attached directly to LVDS source.
> > > 
> > > Fixes: 716be61d1869 ("ARM: dts: imx53: Add Menlosystems M53 board")
> > > Signed-off-by: Marek Vasut <marex@denx.de>
> > > Cc: Shawn Guo <shawnguo@kernel.org>
> > > Cc: Fabio Estevam <festevam@gmail.com>
> > > Cc: NXP Linux Team <linux-imx@nxp.com>
> > > ---
> > >   arch/arm/boot/dts/imx53-m53menlo.dts | 27 +++++++++++++++++++++++++--
> > >   1 file changed, 25 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/arch/arm/boot/dts/imx53-m53menlo.dts b/arch/arm/boot/dts/imx53-m53menlo.dts
> > > index 4f88e96d81dd..a1eb36229ef8 100644
> > > --- a/arch/arm/boot/dts/imx53-m53menlo.dts
> > > +++ b/arch/arm/boot/dts/imx53-m53menlo.dts
> > > @@ -53,6 +53,29 @@ eth {
> > >   		};
> > >   	};
> > > +	lvds-decoder {
> > > +		compatible = "ti,ds90cf364a", "lvds-decoder";
> > 
> > Is this "ti,ds90cf364a" documented anywhere?
> 
> Here is a RB'd patch, currently waiting for someone from dri-devel to pick
> it:
> 
> https://patchwork.freedesktop.org/series/98203/

I will have to wait till it lands.

Shawn

> 
> > > +
> > > +		ports {
> > > +			#address-cells = <1>;
> > > +			#size-cells = <0>;
> > > +
> > > +			port@0 {
> > > +				reg = <0>;
> > 
> > Please have a newline between property and child node.
> 
> Maybe you can fix this up when applying ?
> 
> Thanks

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel