All of lore.kernel.org
 help / color / mirror / Atom feed
From: Diederik de Haas <didi.debian at cknow.org>
To: iwd at lists.01.org
Subject: [PATCH] Remove 'at_console' and add 'netdev' D-Bus policy setting
Date: Wed, 26 Jan 2022 15:04:23 +0100	[thread overview]
Message-ID: <20220126140423.3974-1-didi.debian@cknow.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1148 bytes --]

The 'at_console' D-Bus policy setting has been deprecated for more then
10 years and could be ignored at any time in the future. Moreover, while the
intend was to allow locally logged on users to interact with iwd, it didn't
actually do that. https://www.spinics.net/lists/linux-bluetooth/msg75267.html
and https://gitlab.freedesktop.org/dbus/dbus/-/issues/52 contain more
details. Therefor remove the 'at_console_ setting block.

On Debian (based) systems, there is a standard defined group which is
allowed to manage network interfaces, and that is the 'netdev' group.
So add a D-Bus setting block to grant the 'netdev' group that access.
---
 src/iwd-dbus.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/iwd-dbus.conf b/src/iwd-dbus.conf
index 6b07ba9e..257b0b14 100644
--- a/src/iwd-dbus.conf
+++ b/src/iwd-dbus.conf
@@ -18,7 +18,7 @@
     <allow send_interface="net.connman.iwd.Agent"/>
   </policy>
 
-  <policy at_console="true">
+  <policy group="netdev">
     <allow send_destination="net.connman.iwd"/>
     <allow send_interface="net.connman.iwd.Agent"/>
   </policy>
-- 
2.34.1

             reply	other threads:[~2022-01-26 14:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-26 14:04 Diederik de Haas [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-01-26 14:12 [PATCH] Remove 'at_console' and add 'netdev' D-Bus policy setting Diederik de Haas
2022-01-26 19:14 Diederik de Haas
2022-01-26 19:15 Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220126140423.3974-1-didi.debian@cknow.org \
    --to=unknown@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.