From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Jonathan Borne <jborne@kalray.eu>
Cc: ysionneaux@kalray.eu,
Baruch Siach via buildroot <buildroot@buildroot.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
jmaselbas@kalray.eu
Subject: Re: [Buildroot] [RFC PATCH 0/1] Fix binutils/libiberty target install directory
Date: Wed, 26 Jan 2022 18:14:50 +0100 [thread overview]
Message-ID: <20220126171450.GI457876@scaer> (raw)
In-Reply-To: <608336144.1670038.1643211044586.JavaMail.zimbra@kalray.eu>
Jonathan, All,
On 2022-01-26 16:30 +0100, Jonathan Borne via buildroot spake thusly:
> ----- On Jan 24, 2022, at 10:53 PM, Thomas Petazzoni thomas.petazzoni@bootlin.com wrote:
> > On Mon, 24 Jan 2022 22:21:49 +0100
> > "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> >> As such, when BR2_PACKAGE_BINUTILS_TARGET=n, then the full binutils are
> >> instaleld in target, so the libs will be installed in target.
> I think you made a typo here...
> The full binutils install to target is made when BR2_PACKAGE_BINUTILS_TARGET=y.
Hehe... ;-)
> >> So whatever gets in staging is present in target, but target can be a
> >> superset of what is in staging, so whatever links to a binutils lib from
> >> staging will find it in target.
>
> Agreed! So if I understand correctly, as was suggested by Romain and Thomas,
> we could indeed get rid of
>
> $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/libiberty DESTDIR=$(STAGING_DIR) install
>
> in BINUTILS_INSTALL_TARGET_CMDS.
Yes, but to avoid any confusion, please also add a comment above the
staging installation commands that states that libiberty is static only,
as Baruch pointed out earlier.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-01-26 17:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 17:35 [Buildroot] [RFC PATCH 0/1] Fix binutils/libiberty target install directory Jonathan Borne via buildroot
2022-01-24 17:35 ` [Buildroot] [RFC PATCH 1/1] " Jonathan Borne via buildroot
2022-01-24 17:44 ` [Buildroot] [RFC PATCH 0/1] " Baruch Siach via buildroot
2022-01-24 18:12 ` Romain Naour
2022-01-24 21:02 ` Thomas Petazzoni
2022-01-24 21:21 ` Yann E. MORIN
2022-01-24 21:53 ` Thomas Petazzoni
2022-01-26 15:30 ` Jonathan Borne via buildroot
2022-01-26 15:52 ` Thomas Petazzoni
2022-01-26 17:14 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220126171450.GI457876@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=jborne@kalray.eu \
--cc=jmaselbas@kalray.eu \
--cc=thomas.petazzoni@bootlin.com \
--cc=ysionneaux@kalray.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.