From: Alison Schofield <alison.schofield@intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Ben Widawsky <ben.widawsky@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Linux NVDIMM <nvdimm@lists.linux.dev>,
linux-cxl@vger.kernel.org
Subject: Re: [ndctl PATCH v3 4/6] cxl: add memdev partition information to cxl-list
Date: Wed, 26 Jan 2022 11:03:45 -0800 [thread overview]
Message-ID: <20220126190345.GA888573@alison-desk> (raw)
In-Reply-To: <CAPcyv4g3s=4AV+B3EHgANHXedrvOeY8vasE7uR5vznUX5BX24w@mail.gmail.com>
On Wed, Jan 26, 2022 at 09:23:23AM -0800, Dan Williams wrote:
> On Tue, Jan 18, 2022 at 12:20 PM <alison.schofield@intel.com> wrote:
> >
snip
> > +# cxl list -m mem0 -I
> > +[
> > + {
> > + "memdev":"mem0",
> > + "pmem_size":0,
> > + "ram_size":273535729664,
> > + "partition_info":{
> > + "active_volatile_bytes":273535729664,
> > + "active_persistent_bytes":0,
> > + "next_volatile_bytes":0,
> > + "next_persistent_bytes":0,
> > + "total_bytes":273535729664,
> > + "volatile_only_bytes":0,
> > + "persistent_only_bytes":0,
> > + "partition_alignment_bytes":268435456
>
> I think it's confusing to include "_bytes" in the json listing as it's
> not used in any of the other byte oriented output fields across 'cxl
> list' and 'ndctl list'. "_size" would match similar fields in other
> json objects.
Got it. Will drop the _bytes in v4. Thanks!
>
> Other than that,
>
> Reviewed-by: Dan Williams <dan.j.williams@intel.com>
next prev parent reply other threads:[~2022-01-26 18:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 20:25 [ndctl PATCH v3 0/6] Add partitioning support for CXL memdevs alison.schofield
2022-01-18 20:25 ` [ndctl PATCH v3 1/6] libcxl: add GET_PARTITION_INFO mailbox command and accessors alison.schofield
2022-01-26 16:07 ` Dan Williams
2022-01-26 16:37 ` Alison Schofield
2022-01-26 17:50 ` Verma, Vishal L
2022-01-18 20:25 ` [ndctl PATCH v3 2/6] libcxl: add accessors for capacity fields of the IDENTIFY command alison.schofield
2022-01-26 16:16 ` Dan Williams
2022-01-18 20:25 ` [ndctl PATCH v3 3/6] libcxl: return the partition alignment field in bytes alison.schofield
2022-01-26 16:40 ` Dan Williams
2022-01-18 20:25 ` [ndctl PATCH v3 4/6] cxl: add memdev partition information to cxl-list alison.schofield
2022-01-26 17:23 ` Dan Williams
2022-01-26 19:03 ` Alison Schofield [this message]
2022-01-18 20:25 ` [ndctl PATCH v3 5/6] libcxl: add interfaces for SET_PARTITION_INFO mailbox command alison.schofield
2022-01-26 23:41 ` Dan Williams
2022-01-27 20:50 ` Alison Schofield
2022-02-01 1:24 ` Dan Williams
2022-02-01 1:34 ` Alison Schofield
2022-02-01 1:25 ` Alison Schofield
2022-02-01 1:32 ` Dan Williams
2022-01-18 20:25 ` [ndctl PATCH v3 6/6] cxl: add command set-partition-info alison.schofield
2022-01-27 1:44 ` Dan Williams
2022-01-27 5:44 ` Alison Schofield
2022-01-27 19:03 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220126190345.GA888573@alison-desk \
--to=alison.schofield@intel.com \
--cc=ben.widawsky@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.