From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Michael Fischer <mf@go-sys.de>
Cc: buildroot@busybox.net, "Yann E. MORIN" <yann.morin.1998@free.fr>
Subject: Re: [Buildroot] [PATCH 1/1] package/network-manager: add optional nmcli support
Date: Wed, 26 Jan 2022 23:14:32 +0100 [thread overview]
Message-ID: <20220126231432.37374caf@windsurf> (raw)
In-Reply-To: <20220126090457.32015-1-mf@go-sys.de>
Hello,
+Yann on legacy handling (see below)
On Wed, 26 Jan 2022 10:04:57 +0100
Michael Fischer <mf@go-sys.de> wrote:
> When NetworkManager is built without the READLINE package the nmcli was not build.
Well, this was kind of expected, and isn't really a correct
explanation for this change.
A better explanation I believe is more something like this:
"""
The network-manager package builds the nmcli utility when the readline
package is enabled. However, this is not necessarily obvious to the
user. Therefore, this commit adds an explicit option to enable the
nmcli tool, which automatically selects readline.
"""
>
> Signed-off-by: Michael Fischer <mf@go-sys.de>
> +config BR2_PACKAGE_NETWORK_MANAGER_CLI
> + bool "nmcli support"
> + select BR2_PACKAGE_READLINE
> + help
> + This option enables support for NetworkManager Command Line Interface
I think this line is too long, make sure to run "make check-package".
But a bigger problem is the legacy handling. Indeed, before your patch,
a configuration with BR2_PACKAGE_NETWORK_MANAGER=y and
BR2_PACKAGE_READLINE=y gets nmcli. After your patch, such a
configuration no longer has nmcli compiled, because
BR2_PACKAGE_NETWORK_MANAGER_CLI is not enabled.
Is this important to address, I don't know.
Is it possible to address is by doing:
config BR2_PACKAGE_NETWORK_MANAGER_CLI
bool "nmcli support"
default y if BR2_PACKAGE_READLINE
select BR2_PACKAGE_READLINE
I don't know if Kconfig is happy about such a construct. Yann? :-)
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-01-26 22:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 9:04 [Buildroot] [PATCH 1/1] package/network-manager: add optional nmcli support Michael Fischer
2022-01-26 22:14 ` Thomas Petazzoni [this message]
2022-01-26 22:28 ` Yann E. MORIN
2022-01-27 10:46 ` [Buildroot] [PATCH v2 " Michael Fischer
2022-08-21 15:29 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220126231432.37374caf@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
--cc=mf@go-sys.de \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.