From: Stephane Eranian <eranian@google.com>
To: linux-kernel@vger.kernel.org
Cc: peterz@infradead.org, kim.phillips@amd.com, acme@redhat.com,
jolsa@redhat.com, songliubraving@fb.com
Subject: [PATCH v5 10/13] perf evsel: Make evsel__env always return a valid env
Date: Wed, 26 Jan 2022 15:34:51 -0800 [thread overview]
Message-ID: <20220126233454.3362047-11-eranian@google.com> (raw)
In-Reply-To: <20220126233454.3362047-1-eranian@google.com>
From: Kim Phillips <kim.phillips@amd.com>
It's possible to have an evsel and evsel->evlist populated without
an evsel->evlist->env, when, e.g., cmd_record is in its error path.
Future patches will add support for evsel__open_strerror to be able
to customize error messaging based on perf_env__{arch,cpuid}, so
let's have evsel__env return &perf_env instead of NULL in that case.
Signed-off-by: Kim Phillips <kim.phillips@amd.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Joao Martins <joao.m.martins@oracle.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Michael Petlan <mpetlan@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Robert Richter <robert.richter@amd.com>
Cc: Stephane Eranian <eranian@google.com>
---
tools/perf/util/evsel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index 22d3267ce294..14b0e7ffa2c7 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -2965,7 +2965,7 @@ int evsel__open_strerror(struct evsel *evsel, struct target *target,
struct perf_env *evsel__env(struct evsel *evsel)
{
- if (evsel && evsel->evlist)
+ if (evsel && evsel->evlist && evsel->evlist->env)
return evsel->evlist->env;
return &perf_env;
}
--
2.35.0.rc0.227.g00780c9af4-goog
next prev parent reply other threads:[~2022-01-26 23:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 23:34 [PATCH v5 00/14] perf/x86/amd: Add AMD Fam19h Branch Sampling support Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 01/13] perf/core: add perf_clear_branch_entry_bitfields() helper Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 02/13] x86/cpufeatures: add AMD Fam19h Branch Sampling feature Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 03/13] perf/x86/amd: add AMD Fam19h Branch Sampling support Stephane Eranian
2022-01-27 1:52 ` kernel test robot
2022-01-27 6:09 ` kernel test robot
2022-01-27 6:09 ` kernel test robot
2022-01-26 23:34 ` [PATCH v5 04/13] perf/x86/amd: add branch-brs helper event for Fam19h BRS Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 05/13] perf/x86/amd: enable branch sampling priv level filtering Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 06/13] perf/x86/amd: add AMD branch sampling period adjustment Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 07/13] perf/x86/amd: make Zen3 branch sampling opt-in Stephane Eranian
2022-01-27 12:51 ` Peter Zijlstra
2022-02-01 7:28 ` Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 08/13] ACPI: add perf low power callback Stephane Eranian
2022-01-27 4:58 ` kernel test robot
2022-01-27 7:41 ` kernel test robot
2022-01-27 7:41 ` kernel test robot
2022-01-27 13:06 ` Peter Zijlstra
2022-02-01 7:33 ` Stephane Eranian
2022-02-01 10:20 ` Peter Zijlstra
2022-01-26 23:34 ` [PATCH v5 09/13] perf/x86/amd: add idle hooks for branch sampling Stephane Eranian
2022-01-27 13:07 ` Peter Zijlstra
2022-02-01 7:34 ` Stephane Eranian
2022-01-26 23:34 ` Stephane Eranian [this message]
2022-01-26 23:34 ` [PATCH v5 11/13] perf tools: Improve IBS error handling Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 12/13] perf tools: Improve error handling of AMD Branch Sampling Stephane Eranian
2022-01-26 23:34 ` [PATCH v5 13/13] perf report: add addr_from/addr_to sort dimensions Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220126233454.3362047-11-eranian@google.com \
--to=eranian@google.com \
--cc=acme@redhat.com \
--cc=jolsa@redhat.com \
--cc=kim.phillips@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.