From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============1576208523431992144==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH v2 1/4] panic: Add panic_in_progress helper Date: Thu, 27 Jan 2022 08:29:37 +0800 Message-ID: <202201270809.uw81DRNS-lkp@intel.com> In-Reply-To: <20220126230236.750229-2-stephen.s.brennan@oracle.com> List-Id: --===============1576208523431992144== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Stephen, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.17-rc1 next-20220125] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Stephen-Brennan/printk-red= uce-deadlocks-during-panic/20220127-070450 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = 0280e3c58f92b2fe0e8fbbdf8d386449168de4a8 config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20220127= /202201270809.uw81DRNS-lkp(a)intel.com/config) compiler: m68k-linux-gcc (GCC) 11.2.0 reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/1a13d274a7781724644b4267d= ce99e45c9232a29 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Stephen-Brennan/printk-reduce-dead= locks-during-panic/20220127-070450 git checkout 1a13d274a7781724644b4267dce99e45c9232a29 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.cross= O=3Dbuild_dir ARCH=3Dm68k prepare If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from include/asm-generic/preempt.h:5, from ./arch/m68k/include/generated/asm/preempt.h:1, from include/linux/preempt.h:78, from arch/m68k/include/asm/irqflags.h:6, from include/linux/irqflags.h:16, from arch/m68k/include/asm/atomic.h:6, from include/linux/atomic.h:7, from include/linux/panic.h:7, from include/asm-generic/bug.h:21, from arch/m68k/include/asm/bug.h:32, from include/linux/bug.h:5, from include/linux/page-flags.h:10, from kernel/bounds.c:10: include/linux/thread_info.h: In function 'copy_overflow': >> include/linux/thread_info.h:214:9: error: implicit declaration of functi= on 'WARN' [-Werror=3Dimplicit-function-declaration] 214 | WARN(1, "Buffer overflow detected (%d < %lu)!\n", size, = count); | ^~~~ include/linux/thread_info.h: In function 'check_copy_size': >> include/linux/thread_info.h:230:13: error: implicit declaration of funct= ion 'WARN_ON_ONCE' [-Werror=3Dimplicit-function-declaration] 230 | if (WARN_ON_ONCE(bytes > INT_MAX)) | ^~~~~~~~~~~~ cc1: some warnings being treated as errors make[2]: *** [scripts/Makefile.build:121: kernel/bounds.s] Error 1 make[2]: Target '__build' not remade because of errors. make[1]: *** [Makefile:1191: prepare0] Error 2 make[1]: Target 'prepare' not remade because of errors. make: *** [Makefile:219: __sub-make] Error 2 make: Target 'prepare' not remade because of errors. vim +/WARN +214 include/linux/thread_info.h b0377fedb65280 Al Viro 2017-06-29 211 = b0377fedb65280 Al Viro 2017-06-29 212 static inline void copy_overflow(= int size, unsigned long count) b0377fedb65280 Al Viro 2017-06-29 213 { b0377fedb65280 Al Viro 2017-06-29 @214 WARN(1, "Buffer overflow detecte= d (%d < %lu)!\n", size, count); b0377fedb65280 Al Viro 2017-06-29 215 } b0377fedb65280 Al Viro 2017-06-29 216 = 9dd819a15162f8 Kees Cook 2019-09-25 217 static __always_inline __must_che= ck bool b0377fedb65280 Al Viro 2017-06-29 218 check_copy_size(const void *addr,= size_t bytes, bool is_source) b0377fedb65280 Al Viro 2017-06-29 219 { c80d92fbb67b2c Kees Cook 2021-06-17 220 int sz =3D __builtin_object_size= (addr, 0); b0377fedb65280 Al Viro 2017-06-29 221 if (unlikely(sz >=3D 0 && sz < b= ytes)) { b0377fedb65280 Al Viro 2017-06-29 222 if (!__builtin_constant_p(bytes= )) b0377fedb65280 Al Viro 2017-06-29 223 copy_overflow(sz, bytes); b0377fedb65280 Al Viro 2017-06-29 224 else if (is_source) b0377fedb65280 Al Viro 2017-06-29 225 __bad_copy_from(); b0377fedb65280 Al Viro 2017-06-29 226 else b0377fedb65280 Al Viro 2017-06-29 227 __bad_copy_to(); b0377fedb65280 Al Viro 2017-06-29 228 return false; b0377fedb65280 Al Viro 2017-06-29 229 } 6d13de1489b6bf Kees Cook 2019-12-04 @230 if (WARN_ON_ONCE(bytes > INT_MAX= )) 6d13de1489b6bf Kees Cook 2019-12-04 231 return false; b0377fedb65280 Al Viro 2017-06-29 232 check_object_size(addr, bytes, i= s_source); b0377fedb65280 Al Viro 2017-06-29 233 return true; b0377fedb65280 Al Viro 2017-06-29 234 } b0377fedb65280 Al Viro 2017-06-29 235 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============1576208523431992144==--