Re: [Buildroot] [PATCH v3 2/2] package/buildah: new package

[Thomas Petazzoni <thomas.petazzoni@bootlin.com>]

Hello,

On Wed, 26 Jan 2022 22:25:04 -0800
Christian Stewart <christian@paral.in> wrote:


> v1 -> v2:
> 
>  - add package to developers
>  - add host runc dependency for host package
>  - add libgpgme runtime dependency

Considering that there are runtime dependency concerns, it would be
nice to have a simple test case in support/testing/.


> diff --git a/package/buildah/buildah.hash b/package/buildah/buildah.hash
> new file mode 100644
> index 0000000000..c7e00d02a7
> --- /dev/null
> +++ b/package/buildah/buildah.hash
> @@ -0,0 +1,3 @@
> +# Locally calculated
> +sha256  d99b5187a25bc9d7385408732a0e155df0458b4d2cea6e8d002f3fa2cbaac76f  buildah-1.24.0.tar.gz
> +sha256  b40930bbcf80744c86c46a12bc9da056641d722716c378f5659b9e555ef833e1  LICENSE
> diff --git a/package/buildah/buildah.mk b/package/buildah/buildah.mk
> new file mode 100644
> index 0000000000..658d7ef56f
> --- /dev/null
> +++ b/package/buildah/buildah.mk
> @@ -0,0 +1,46 @@
> +################################################################################
> +#
> +# buildah
> +#
> +################################################################################
> +
> +BUILDAH_VERSION = 1.24.0
> +BUILDAH_SITE = $(call github,containers,buildah,v$(BUILDAH_VERSION))
> +
> +BUILDAH_LICENSE = Apache-2.0
> +BUILDAH_LICENSE_FILES = LICENSE
> +
> +BUILDAH_DEPENDENCIES = libgpgme

Is libgpgme really a runtime dependency, as noted in your changelog? If
it is, then it's not needed in BUILDAH_DEPENDENCIES. However, it would
be somewhat surprising for it to be only a runtime dependency. Could
you confirm? Does it get dlopen()ed at runtime? Or it's not the library
that is used at runtime, but some program that is installed by libgpgme?


> +define BUILDAH_INSTALL_CONFIG
> +	$(INSTALL) -D -m 644 $(@D)/contrib/buildroot/policy.json \
> +		$(TARGET_DIR)/etc/containers/policy.json
> +endef
> +
> +BUILDAH_POST_INSTALL_TARGET_HOOKS += BUILDAH_INSTALL_CONFIG
> +
> +HOST_BUILDAH_BUILD_TARGETS = $(BUILDAH_BUILD_TARGETS)
> +HOST_BUILDAH_TAGS = $(BUILDAH_TAGS)
> +HOST_BUILDAH_LDFLAGS = $(BUILDAH_LDFLAGS)
> +HOST_BUILDAH_INSTALL_BINS = $(BUILDAH_INSTALL_BINS)

That "repetition" also makes me think we should have some level of
inheritance between target and host variables in the golang-package
infrastructure. For BUILD_TARGETS, TAGS and INSTALL_BINS, it sounds
fine to do it. However, for LDFLAGS, it's a bit weird, as normally,
LDFLAGS are different between host and target. However here, there are
mostly used to pass these version-related -X options, that are in fact
the same between host and target. Should we have a separate variable to
pass those flags ? Not sure.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot