From: Stephen Hemminger <stephen@networkplumber.org>
To: Wojciech Drewek <wojciech.drewek@intel.com>
Cc: netdev@vger.kernel.org, dsahern@gmail.com,
michal.swiatkowski@linux.intel.com,
marcin.szycik@linux.intel.com
Subject: Re: [PATCH iproute2-next 2/2] f_flower: Implement gtp options support
Date: Thu, 27 Jan 2022 09:15:41 -0800 [thread overview]
Message-ID: <20220127091541.6667d4d1@hermes.local> (raw)
In-Reply-To: <20220127131355.126824-3-wojciech.drewek@intel.com>
On Thu, 27 Jan 2022 14:13:55 +0100
Wojciech Drewek <wojciech.drewek@intel.com> wrote:
> + open_json_array(PRINT_JSON, name);
> + open_json_object(NULL);
> + print_uint(PRINT_JSON, "pdu_type", NULL, pdu_type);
> + print_uint(PRINT_JSON, "qfi", NULL, qfi);
> + close_json_object();
> + close_json_array(PRINT_JSON, name);
> +
> + sprintf(strbuf, "%02x:%02x", pdu_type, qfi);
Doing JSON specific code is not necessary here?
And why an array of two named elements? Seems confusing
next prev parent reply other threads:[~2022-01-27 17:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 13:13 [PATCH iproute2-next 0/2] GTP support for ip link and tc flower Wojciech Drewek
2022-01-27 13:13 ` [PATCH iproute2-next 1/2] ip: GTP support in ip link Wojciech Drewek
2022-01-27 17:11 ` Stephen Hemminger
2022-01-27 17:12 ` Stephen Hemminger
2022-01-27 17:13 ` Stephen Hemminger
2022-01-27 19:52 ` Drewek, Wojciech
2022-01-27 13:13 ` [PATCH iproute2-next 2/2] f_flower: Implement gtp options support Wojciech Drewek
2022-01-27 17:15 ` Stephen Hemminger [this message]
2022-01-27 19:48 ` Drewek, Wojciech
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220127091541.6667d4d1@hermes.local \
--to=stephen@networkplumber.org \
--cc=dsahern@gmail.com \
--cc=marcin.szycik@linux.intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.